Re: Intel i219 network card support

Hi, On Mon, Feb 08, 2016 at 02:35:32PM +, Stuart Henderson wrote: > On 2016/02/08 13:53, Christian Ehrhardt wrote: > > If you own a skylake based onboard NIC, please give this diff a try. > > The most important bit, especially at this point in the release cycle, > is whether it makes any

Re: hexdump(1) - bug when skip == sb.st_size

Hi, Michal Mazurek wrote on Mon, Feb 08, 2016 at 02:11:19PM +0100: > When running > hexdump -s $NUM file > where NUM is the size of the file, hexdump will print the entire file, > instead of skipping over the content. This looks correct and works for me. OK to commit? Ingo > "od -j

Re: df(1) - unneeded headers

Michal Mazurek wrote: > This was ok tb@ but never commited. > > Remove uneeded includes, and sort those that can be sorted (some can't): Committed (mostly). Thanks! I left stdlib.h and unistd.h because I think that C99 requires that those be included when using libc, although failing to do so

Re: [patch] vi enable -pedantic

On 02/09/16 01:18, Jonathan Gray wrote: > I don't think we should enable -pedantic anywhere in the tree. Different > versions of gcc are going to have different ideas of what pedantic is. That's why I tested this on all the compilers at my direct disposal. What about the changes in general,

Re: vi.1: remove more predefined strings

On Mon, Feb 08, 2016 at 01:28:40PM -0500, Michael Reed wrote: > Done for the same reason as rev. 1.57[1]. I observed no diff in the > generated output for terminals, but I'm unsure if these strings are > wanted for prettier pdf/ps/html/... output. > > Regards, > Michael Reed > > [1]: >

OpenSMTPD and mask-source flag.

Dear OpenSMTPD Developers! I think there is a little "bug/feature" with respect to handling "mask-source" parameter with "listen on" directive in smtpd.conf. The behavior makes perfect sense from the perspective of documentation. Unfortunately it is not uniform from the perspective of the client.

Re: OpenSMTPD and mask-source flag.

On Mon, Feb 08, 2016 at 08:32:31PM -0500, Peter Bisroev wrote: > Dear OpenSMTPD Developers! > Dear Peter, > I think there is a little "bug/feature" with respect to handling "mask-source" > parameter with "listen on" directive in smtpd.conf. The behavior makes perfect > sense from the

Re: Intel i219 network card support

On 2016/02/08 13:53, Christian Ehrhardt wrote: > If you own a skylake based onboard NIC, please give this diff a try. The most important bit, especially at this point in the release cycle, is whether it makes any changes that cause problems with other chips. I don't have time to look closely now

Intel i219 network card support

Hi everyone, based on the latest release of the Intel driver for FreeBSD (em-7.5.2), I've adapted the em(4) driver to support the skylake based i219 onboard ethernet chips. I do not have access to relevant specs, everything below is based on reading the Intel code referenced above. The diff

hexdump(1) - don't declare main

main() doesn't need to be declared. Index: hexdump.c === RCS file: /cvs/src/usr.bin/hexdump/hexdump.c,v retrieving revision 1.19 diff -u -p -r1.19 hexdump.c --- hexdump.c 9 Oct 2015 01:37:07 - 1.19 +++ hexdump.c 8 Feb

hexdump(1) - unneeded headers

These headers appear to be unneeded: Index: conv.c === RCS file: /cvs/src/usr.bin/hexdump/conv.c,v retrieving revision 1.10 diff -u -p -r1.10 conv.c --- conv.c 19 Apr 2014 09:28:20 - 1.10 +++ conv.c 8 Feb 2016

df(1) - unneeded headers

This was ok tb@ but never commited. Remove uneeded includes, and sort those that can be sorted (some can't): Index: df.c === RCS file: /cvs/src/bin/df/df.c,v retrieving revision 1.54 diff -u -p -r1.54 df.c --- df.c9 Oct

hexdump(1) - bug when skip == sb.st_size

When running hexdump -s $NUM file where NUM is the size of the file, hexdump will print the entire file, instead of skipping over the content. "od -j $NUM" has the same issue. Index: display.c === RCS file:

Re: Ntpd log message readably tweak.

On Sun, Feb 07, 2016 at 02:18:46PM +, Gerald Hanuer wrote: > Hello tech@, > > https://marc.info/?l=openbsd-misc=145479483809799=2 > > ntpd[9279]: adjusting local clock by 9.096751s > > ntpd[9279]: adjusting local clock by 7.971861s > > ntpd[9279]: adjusting local clock by 6.838999s > >

hexdump(1) - tidy declarations

Move some declarations out of hexdump.h Mark some declarations as __dead or static Remove a commented out declaration Convert some spaces to tabs Index: display.c === RCS file: /cvs/src/usr.bin/hexdump/display.c,v retrieving revision

Re: pkg_add.1

On Sun, Feb 07, 2016 at 09:42:32AM -0600, joshua stein wrote: > We don't recommend FTP mirrors anymore, installing a package via a > pipe doesn't seem to work anymore, and packages have to be signed to > be installed so the advice about miscreants is not very relevant. > > installing packages

Re: Ntpd log message readably tweak.

Hello tech@, Otto thanks for the clarification. https://marc.info/?l=openbsd-misc=145480059910903=2 I had not seen Naddy's comment before firing off the diff. The explanations given are clear and helpfull. Regards, Gerald Hanuer

Re: pkg_add.1

Sent from my iPhone > On Feb 8, 2016, at 12:28 PM, Marc Espie wrote: > >> On Sun, Feb 07, 2016 at 09:42:32AM -0600, joshua stein wrote: >> We don't recommend FTP mirrors anymore, installing a package via a >> pipe doesn't seem to work anymore, and packages have to be signed

vi.1: remove more predefined strings

Done for the same reason as rev. 1.57[1]. I observed no diff in the generated output for terminals, but I'm unsure if these strings are wanted for prettier pdf/ps/html/... output. Regards, Michael Reed [1]:

Re: ufs/ffs/ext2fs uiomove() conversion

Martin Natano wrote: > Below the conversion to uiomovei() for ufs. While there I changed all > instances of 'blkoffset', 'size' and 'xfersize' that where declared as > long integers to be plain integers instead for consistency with the > surrounding code. These variables are limited by fs_bsize

doas do CR before printing challenge

Hello tech@, The following patch adds a carriage return before printing the regular challenge. If you're like me and you sometimes forget to wait before the prompt comes up before typing your password it might be a little less stressful if the message returns to the start of the line instead of

Re: Intel i219 network card support

On Mon, Feb 08, 2016 at 01:53:20PM +0100, Christian Ehrhardt wrote: > The diff was initially done for 5.7, bluhm@ did the forward port > to current. The resulting diff is below. I am running this diff with my Thinkpad T430s, no problems so far. em0 at pci0 dev 25 function 0 "Intel 82579LM" rev

Re: ufs/ffs/ext2fs uiomove() conversion

> One unrelated thing noted while reviewing: > > ufs/ext2fs/ext2fs_readwrite.c: > static int > ext2_ind_read(struct vnode *vp, struct inode *ip, struct m_ext2fs *fs, > struct uio *uio) > { > ... > > if (vp->v_type == VLNK) { > if ((int)ext2fs_size(ip) <

Re: rtadvd unicast

On Tue, Feb 09, 2016 at 12:23:51AM +0100, J??r??mie Courr??ges-Anglas wrote: > > > rtadvd contains code to send unicast replies, RFC4861 mentions this > > possibility (section 6.2.6) but I'm having a hard time thinking how it > > could be useful. > > > > Since the sending part is commented out

Re: [patch] vi enable -pedantic

I don't think we should enable -pedantic anywhere in the tree. Different versions of gcc are going to have different ideas of what pedantic is. I'm not sold on the value of all these patches to nvi when it is possibly hindering people who may be looking to add utf-8 support (via nvi2 or

Re: multicast, ETOOMANYREFS and intro(2)

"Todd C. Miller" writes: > On Fri, 05 Feb 2016 17:17:30 +0100, Martin Pieuchot wrote: > >> > > We could also return ENOBUFS in this case instead. That would >> > > correspond to the errors described in ip(4) (sadly setsockopt(2) is not >> > > really reflecting the

Re: [patch] vi enable -pedantic

Jonathan Gray wrote: > I don't think we should enable -pedantic anywhere in the tree. > Different versions of gcc are going to have different ideas of what > pedantic is. This was my reaction too. I like the approach of keeping few to no warnings in default builds. It's easy to "env

Re: rtadvd unicast

> rtadvd contains code to send unicast replies, RFC4861 mentions this > possibility (section 6.2.6) but I'm having a hard time thinking how it > could be useful. > > Since the sending part is commented out since it was introduced, I doubt > that anyone will miss it. This removes pointless memory

Re: pkg_add.1

On Mon, Feb 08, 2016 at 03:05:00PM -0800, patrick keshishian wrote: > On Mon, Feb 08, 2016 at 07:28:24PM +0100, Marc Espie wrote: > > On Sun, Feb 07, 2016 at 09:42:32AM -0600, joshua stein wrote: > > > We don't recommend FTP mirrors anymore, installing a package via a > > > pipe doesn't seem to

Re: [patch] vi enable -pedantic

And of course you find out way to late that format=flowed was still on... Here's a new diff. Any OKs for this? On 02/01/16 23:34, Martijn van Duren wrote: > Hello tech@, > > This patch enables -pedantic and does the appropriate cleanup that comes > with it. It's mostly a CHAR_T->char

rtadvd: remove more dead code

- a few *cnt members of struct rainfo aren't used for anything - the SIOCGIFPREFIX_IN6 ioctl has been deprecated since June 2002 - prefix_match() and in6a_site_allrouters are remnants from the Renumbering code (now in the Attic) ok? Index: config.c