Re: Grammatical changes to httpd.conf(5)

On Tue, Mar 08, 2016 at 12:01:45AM +, Sevan Janiyan wrote: > > > On 07/03/2016 19:14, Jason McIntyre wrote: > > all of your changes appear to be for the sake of preference, rather than > > that what's there is incorrect. it would be better then to state why you > > think your change is

Re: Patches for improving npppd with rdomain support

Hi, On Tue, 1 Mar 2016 17:32:22 +0100 Claer wrote: > I asked a friend, Mathieu Papineau, to help me with an issue I have with > npppd. Thank you for the diffs. I already commited the fix of the path. > For a project here, I thought building multitenancy firewall with

Re: npppd_local.h - Forgotten include guard

commited. Thanks, On Sat, 05 Mar 2016 09:34:07 + "Tiago Silva" wrote: > Hi to all, > > The 1.13 revision of /src/usr.sbin/npppd/npppd/npppd_local.h forgot to remove > the bottom __cplusplus include guard. > > --- /src/usr.sbin/npppd/npppd/npppd_local.h Thu Jul 23

Re: Grammatical changes to httpd.conf(5)

On 07/03/2016 19:14, Jason McIntyre wrote: > all of your changes appear to be for the sake of preference, rather than > that what's there is incorrect. it would be better then to state why you > think your change is neccessary. i don;t feel any of these changes are > improvements. > > language

Re: improve xterm(1) resilience against control code attacks

Hi Christian, Christian Weisgerber wrote on Mon, Mar 07, 2016 at 03:51:41PM +: > On 2016-03-07, Ingo Schwarze wrote: >> Consequently, in the interest of safe and sane defaults, i propose >> switching our xterm(1) to enable UTF-8 mode by default. > Seconded. >> The best

fortune: eliminate do_malloc() and do_free()

do_malloc() and do_free() are wrappers for malloc(3) and free(3) with null checks. do_free() and free() are both used (see third hunk), so it's confusing. do_malloc() is used only three times, once asprintf(3) seems more appropriate, and for just two calls the benefit of a custom wrapper is

Re: [file] file -i doesn't detect epub correctly

Thanks to all, `xdg-mime query filetype $epub' works fine now. j.

Re: i386 trap & sti

On Mon, Mar 07, 2016 at 12:28:09PM +0100, Martin Pieuchot wrote: > Here's the second diff calling sti unconditionally in alltraps. > > ok? > ok > Index: i386/locore.s > === > RCS file: /cvs/src/sys/arch/i386/i386/locore.s,v >

Re: Move db_show_reg

On Mon, Mar 07, 2016 at 01:41:20PM +0100, Martin Pieuchot wrote: > Make this function local to db_command.c and get rid of db_print.c while > here. > > It'll take longer than expected to tweak it to display any trapframe. > > ok? reads ok to me > > Index: ddb/db_command.c >

Grammatical changes to httpd.conf(5)

Hi, Attached diff makes some grammatical adjustments to httpd.conf(5) Sevan Index: src/usr.sbin/httpd/httpd.conf.5 === RCS file: /cvs/src/usr.sbin/httpd/httpd.conf.5,v retrieving revision 1.68 diff -u -p -u -r1.68 httpd.conf.5 ---

Re: Grammatical changes to httpd.conf(5)

On Mon, Mar 07, 2016 at 06:53:50PM +, Sevan Janiyan wrote: > Hi, > Attached diff makes some grammatical adjustments to httpd.conf(5) > > > > Sevan hi. all of your changes appear to be for the sake of preference, rather than that what's there is incorrect. it would be better then to state

inline driver-specific definitions in rtwn(4) and urtwn(4)

Now what is left in if_rtwnreg.h and if_urtwnreg.h is mostly specific to each driver and we can inline these driver-specific definitions in their respective .c files. After this diff is in, we can start merging some actual code. Index: ic/r92creg.h

sched_bsd.c: update comment about p_pctcpu

It's also used in top, systat, and tty status (^T). Index: sched_bsd.c === RCS file: /cvs/src/sys/kern/sched_bsd.c,v retrieving revision 1.42 diff -u -p -r1.42 sched_bsd.c --- sched_bsd.c 8 Nov 2015 20:45:57 - 1.42 +++

merge rtwn(4) and urtwn(4) tx/rx descriptors

Merge definitions for TX and RX descriptors to the common header file. The structs have different sizes but all the bit masks can be shared. Again, tested with: MAC/BB RTL8188CUS, RF 6052 1T1R MAC/BB RTL8188EU, RF 6052 1T1R MAC/BB RTL8192CU, RF 6052 2T2R MAC/BB RTL8188CE, RF 6052 1T1R Index:

sched_bsd.c: update comment

Some time ago p_swptime was removed: - p->p_swtime++; if (p->p_stat == SSLEEP || p->p_stat == SSTOP) p->p_slptime++; But the comment still mentions it. What type p_swtime had and how someone concluded it overflows in 45 days I do not know.

Re: MI: foo() -> foo(void)

On Mon, 07 Mar 2016 16:02:09 +0100, Christian Weisgerber wrote: > Sync no-argument function declaration and definition by adding (void). OK millert@ - todd

Re: Typo in smtpd.conf(5)

committed thanks ! On Mon, Mar 07, 2016 at 01:50:38AM +, Sevan Janiyan wrote: > Hi, > Attached diff corrects a typo to correspond with the commit message. > s/ca/certificate > > http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.sbin/smtpd/smtpd.conf.5?rev=1.142=text/x-cvsweb-markup > > >

Re: improve xterm(1) resilience against control code attacks

On 2016-03-07, Ingo Schwarze wrote: > Consequently, in the interest of safe and sane defaults, i propose > switching our xterm(1) to enable UTF-8 mode by default. Seconded. > The best place to switch is in the setup function VTInitialize_locale() > that decides whether to

MI: foo() -> foo(void)

Sync no-argument function declaration and definition by adding (void). I hope this doesn't conflict with any network patches. I skipped these: dev/microcode/ utility programs, not even KNF lib/libz/ foreign code, K Index: ddb/db_dwarf.c

fdt: don't return root node as root's parent

Hi, I think if we call fdt_parent_node() and give it the root node, it should return NULL, as there can't be a parent above it. It should not start searching for the node somewhere in the tree. Patrick diff --git sys/dev/ofw/fdt.c sys/dev/ofw/fdt.c index c86df3e..aa14507 100644 ---

Re: socppc/fdt: fix fdt_find_node for the case we don't find a node

On Mon, Mar 07, 2016 at 01:25:01PM +0100, Martin Pieuchot wrote: > On 06/03/16(Sun) 18:42, Patrick Wildt wrote: > > On Sun, Mar 06, 2016 at 04:23:08PM +0100, Martin Pieuchot wrote: > > > On 28/02/16(Sun) 17:49, Patrick Wildt wrote: > > > > Hi, > > > > > > > > If we're calling fdt_find_node() and

Move db_show_reg

Make this function local to db_command.c and get rid of db_print.c while here. It'll take longer than expected to tweak it to display any trapframe. ok? Index: ddb/db_command.c === RCS file: /cvs/src/sys/ddb/db_command.c,v

ddb m88k

I'd like to stop using DDB_REGS. Diff below does that for m88k. It also gets rid of db_setf_regs() by putting the address of the ``ddb_regs'' directly in the array, like other archs do. Compiled tested only. Ok? Index: m88k/db_interface.c

Re: socppc/fdt: fix fdt_find_node for the case we don't find a node

On 06/03/16(Sun) 18:42, Patrick Wildt wrote: > On Sun, Mar 06, 2016 at 04:23:08PM +0100, Martin Pieuchot wrote: > > On 28/02/16(Sun) 17:49, Patrick Wildt wrote: > > > Hi, > > > > > > If we're calling fdt_find_node() and do not actually find the node we're > > > looking for, we call strncmp with a

Re: ptrace.2: document PT_GET_THREAD_FIRST and PT_GET_THREAD_NEXT

Hi Philip, Philip Guenther wrote on Sat, Mar 05, 2016 at 09:35:58PM -0800: > Side note: best practice is to run "mandoc -Tlint -Wwarning" > on manpages after making changes. True. In case you are still training your finger memory, just mandoc -Tlint is enough, it already implies -Wall ==

sparc64: foo() -> foo(void)

Sync no-argument function declaration and definition by adding (void). Index: dev/consinit.c === RCS file: /cvs/src/sys/arch/sparc64/dev/consinit.c,v retrieving revision 1.14 diff -u -p -r1.14 consinit.c --- dev/consinit.c 13

ffs_read() tweak

bread_cluster() can be called unconditionally. The sequential check is a leftover of the read-ahead mechanism that FFS no longer used since the introduction of the Dynamic Buffer cache. ok? Index: ufs/ffs/ffs_vnops.c === RCS file:

i386 trap & sti

Here's the second diff calling sti unconditionally in alltraps. ok? Index: i386/locore.s === RCS file: /cvs/src/sys/arch/i386/i386/locore.s,v retrieving revision 1.165 diff -u -p -r1.165 locore.s --- i386/locore.s 3 Mar 2016

Re: NULL checks of static arrays

On 06/03/16(Sun) 19:20, Michael McConville wrote: > We check static arrays against NULL pretty often in the kernel. I > suspect most of these are due to recent kernel API changes. Should they > be removed, or do people want to keep them around in case the APIs > change again? Clang 3.7 warns about

Re: KASSERT() @ pf_test() is back

On Mon, Mar 07, 2016 at 10:54:26AM +0100, Mattieu Baptiste wrote: > On Mon, Mar 7, 2016 at 10:03 AM, Alexandr Nedvedicky > wrote: > > Hello Mattieu, > > > > Mark Patruck reported panic on KASSERT() in pf_test() yesterday . I've > > crafted > > patch below. Can you

Re: KASSERT() @ pf_test() is back

On Mon, Mar 7, 2016 at 10:03 AM, Alexandr Nedvedicky wrote: > Hello Mattieu, > > Mark Patruck reported panic on KASSERT() in pf_test() yesterday . I've crafted > patch below. Can you try it out? > > I think we need to apply pf_pkt_addr_changed() on broadcast

Re: KASSERT() @ pf_test() is back

Hello Mattieu, Mark Patruck reported panic on KASSERT() in pf_test() yesterday . I've crafted patch below. Can you try it out? I think we need to apply pf_pkt_addr_changed() on broadcast packets seen by bridge as well. thanks a lot and sorry for inconveniences regards sasha