Re: nfsrv_mknod(): missing vput() in error path

Makes sense to me martin On Sun, Jul 3, 2016 at 1:16 PM, Martin Natano wrote: > When perfoming a mknod operation over NFS it can happen that another > client creates a file with the same name between the namei() and > VOP_MKNOD() calls in domknod(). This leads to an error

Re: nfsrv_mknod(): missing vput() in error path

FWIW, this is the diff I used to simulate the race condition (only for testing): Index: kern/vfs_syscalls.c === RCS file: /cvs/src/sys/kern/vfs_syscalls.c,v retrieving revision 1.260 diff -u -p -r1.260 vfs_syscalls.c ---

nfsrv_mknod(): missing vput() in error path

When perfoming a mknod operation over NFS it can happen that another client creates a file with the same name between the namei() and VOP_MKNOD() calls in domknod(). This leads to an error path in nfsrv_mknod() being triggered. In that error path there is a vput(nd.ni_np) missing, resulting in the

Re: rcs: support -I

"Todd C. Miller" writes: > The -I flag is documented but not implemented. This fixes that and > also honors the -I flag from ci/co when prompting as per GNU rcs. Looks correct & works fine here, ok jca@ -- jca | PGP: 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA

Re: convert rtadvd to libevent

j...@wxcvbn.org (Jeremie Courreges-Anglas) writes: > Custom timers go away, ra_timer_update's signature is simplified. The > diff also includes the ctime changes proposed in a standalone diff. > The rescheduling of the next RA in rs_input() is probably the least > trivial part. > > Comments /

iwm: set tx aggregation limit to 1

I'm not sure if this change has any real effect, but as long as we don't support 11n TX aggregation it's probably better to set the firmware's aggregation limit to 1 frame (which means 'no aggregation'). Index: if_iwm.c === RCS file:

iwm: fix inverted logic

This code in iwm is supposed to match what Linux does. The Linux code looks like this: if (ieee80211_is_data(fc) && len > mvm->rts_threshold && !is_multicast_ether_addr(ieee80211_get_DA(hdr))) tx_flags |= TX_CMD_FLG_PROT_REQUIRE; Our driver had the 'is data'

show current tx rate for associated nodes

For hostap interfaces, ifconfig scan currently shows the maximum supported Rx Rate or RX MCS of associated stations. E.g. for an iwn(4) device associated to an athn(4) AP in 11g mode, the AP will show 'HT-MCS7' in ifconfig scan: # ifconfig athn0 scan | grep 34:13:e8:d0:60:a9 lladdr

rcs: support -I

The -I flag is documented but not implemented. This fixes that and also honors the -I flag from ci/co when prompting as per GNU rcs. - todd Index: usr.bin/rcs/ci.c === RCS file: /cvs/src/usr.bin/rcs/ci.c,v retrieving revision

Re: malloc.conf: better docs and impl for J/J

On Sat, Jul 02, 2016 at 01:17:10PM -0400, Ted Unangst wrote: > Otto Moerbeek wrote: > > Hi, > > > > J/j is actually a three valued var. So document that and make it > > possible to set all three values. Default is still 1. > > I initially left the default as is deliberately. I would like for