const in crypto code

Hi, Add "const" to weak_keys array which is read only (read via bcmp()). >From what I see all other arrays in src/sys/crypto are already "static const". - Michael Index: set_key.c === RCS file: /cvs/src/sys/crypto/set_key.c,v

Re: [patch] turn igmpstat into a set of percpu counters

> On 22 Dec 2016, at 20:51, Dimitris Papastamos wrote: > > On Sun, Dec 11, 2016 at 07:24:40PM +, Dimitris Papastamos wrote: >> Hi, >> >> I converted the igmp stats to use percpu counters. This work is >> basically the same as what dlg@ did for other parts of the stack. >> I

Re: qsort.c: remove useless variable

On Tue, Jan 03, 2017 at 04:40:47PM -0700, Todd C. Miller wrote: > On Tue, 03 Jan 2017 21:51:12 +0100, Alexander Bluhm wrote: > > > I think it would be nicer to keep the char * a variable and remove > > the (char *) casts instead. > > How about this? The qsort.o does not change. OK bluhm@ > >

Re: qsort.c: remove useless variable

On Tue, 03 Jan 2017 21:51:12 +0100, Alexander Bluhm wrote: > I think it would be nicer to keep the char * a variable and remove > the (char *) casts instead. How about this? - todd Index: lib/libc/stdlib/qsort.c === RCS file:

Re: find(1): pledge mayexecve codepath

Theo Buehler wrote: > tedu's -delete diff reminded me of a patch I've had in one of my trees > for quite a while: find(1) was tamed a few days before execve(2) was > added to kern_tame.c and I think it was simply forgotten that everything > was already prepared for this. Now it's slightly more

Re: find(1): pledge mayexecve codepath

On Tue, 03 Jan 2017 23:52:46 +0100, Theo Buehler wrote: > tedu's -delete diff reminded me of a patch I've had in one of my trees > for quite a while: find(1) was tamed a few days before execve(2) was > added to kern_tame.c and I think it was simply forgotten that everything > was already prepared

find(1): pledge mayexecve codepath

tedu's -delete diff reminded me of a patch I've had in one of my trees for quite a while: find(1) was tamed a few days before execve(2) was added to kern_tame.c and I think it was simply forgotten that everything was already prepared for this. Now it's slightly more complicated than before

Re: find -delete

Mark Kettenis wrote: > I really think we should not encourage unportable code like that by > giving an example in our manual page. That's fair. > I'm even tempted to say that you should leave the "-exec rm {} \;" > example alone. The + here only works because rm(1) accepts multiple > file

Re: find -delete

>> From: "Ted Unangst" >> Date: Tue, 03 Jan 2017 16:39:48 -0500 >> >> I copied this straight from freebsd. Not fixed, but feel free to correct as >> desired. >> >> This adds a third example showing -delete, mentioning that it's not standard, >> but also hinting that it may

Re: find -delete

> From: "Ted Unangst" > Date: Tue, 03 Jan 2017 16:39:48 -0500 > > I copied this straight from freebsd. Not fixed, but feel free to correct as > desired. > > This adds a third example showing -delete, mentioning that it's not standard, > but also hinting that it may work

Re: find -delete

Jason McIntyre wrote: > no opinion on the addition, but if there is a better way to write the > examples that are there, i think you should take the time to do so. i'd > also slightly prefer we show the more traditional way to do it, though i > appreciate that might not make a ton of sense for

Re: Recursive NET_LOCK()

> Date: Tue, 3 Jan 2017 17:13:27 +0100 > From: Martin Pieuchot > > It seems that most of the problems exposed by the introduction of the > NET_LOCK() are related to the non-recursive nature of the rwlock. Some > known issues involve pflow(4), cloning interfaces an NFS. > >

ld.so diff that needs testing on landisk

The diff below (partly by guenther@) removes ld.so's dependency on the __got_{start,end} symbols by looking at PT_GNU_RELRO instead. On some platforms (hppa and perhaps a few others) this leads to even less writable pages. However, we're not sure if this will work correctly on landisk. So if

Re: qsort.c: remove useless variable

On Tue, Jan 03, 2017 at 12:57:59PM -0700, Todd C. Miller wrote: > When qsort.c was de-registered, the register version of 'aa' was > not removed. Since qsort() already contains casts of a to char * > there's no need for a separate variable here. I think it would be nicer to keep the char * a

Re: vndcompress et al import?

Timo Buhrmester wrote: > > delete [vnd] entirely > Out of curiosity (I'm mostly a NetBSD user), without vnd what would be > the OpenBSD-way of providing a disk-ish interface to a file? Well, the biggest use of vnd in base was just replaced with the makefs. (from netbsd, actually.) vnd isn't going

Re: compiler-rt: upgrade to 3.9.1 / fix gcc personality compile error

> Date: Tue, 3 Jan 2017 17:49:19 +0100 > From: Patrick Wildt > > Hi, > > the GCC personality C file does not compile with clang 3.8 on ARM. They > have fixed the issue in compiler-rt and released 3.9.1. Apparently that > is the only thing they changed in the builtins. Thus

Re: vndcompress et al import?

> delete [vnd] entirely Out of curiosity (I'm mostly a NetBSD user), without vnd what would be the OpenBSD-way of providing a disk-ish interface to a file?

qsort.c: remove useless variable

When qsort.c was de-registered, the register version of 'aa' was not removed. Since qsort() already contains casts of a to char * there's no need for a separate variable here. - todd Index: lib/libc/stdlib/qsort.c === RCS file:

Re: vndcompress et al import?

> Franco Fichtner wrote: > > Hi, > > > > Is anyone aware or interested in porting vndcompress et al > > from NetBSD to OpenBSD? > > > > Is there any technical reason against inclusion? > > well, vnd is kind of on life support. my efforts to delete it entirely have > mostly stalled, but new

Re: vndcompress et al import?

Franco Fichtner wrote: > Hi, > > Is anyone aware or interested in porting vndcompress et al > from NetBSD to OpenBSD? > > Is there any technical reason against inclusion? well, vnd is kind of on life support. my efforts to delete it entirely have mostly stalled, but new features are probably

Re: Recursive NET_LOCK()

On 03/01/17(Tue) 14:08, Ted Unangst wrote: > Martin Pieuchot wrote: > > It seems that most of the problems exposed by the introduction of the > > NET_LOCK() are related to the non-recursive nature of the rwlock. Some > > known issues involve pflow(4), cloning interfaces an NFS. > > > > Diff

Re: libcrypto: fix assembly for clang

Patrick Wildt wrote: > > Maybe they want to support older binutils that do not support the unified > syntax? > What's our policy there? OpenBSD is just about the oldest binutils around. I wouldn't worry about anything older than what we have in base.

Re: ed(1) doesn't support adress ranges which begin with comma or semicolon

Theo Buehler wrote: > On Sat, Dec 24, 2016 at 10:45:16PM +0100, Theo Buehler wrote: > > On Sat, Dec 24, 2016 at 05:44:07PM +0100, Jérôme FRGACIC wrote: > > > Hi @tech, > > > > > > I remark that ed(1) do not support adress ranges which begin with > > > comma or semicolon, for example ",10p" which

Re: Recursive NET_LOCK()

Martin Pieuchot wrote: > It seems that most of the problems exposed by the introduction of the > NET_LOCK() are related to the non-recursive nature of the rwlock. Some > known issues involve pflow(4), cloning interfaces an NFS. > > Diff below makes use of a recursive-rwlock instead. I just

libcrypto: fix assembly for clang

Hi, clang complains about the ARM assembly, since it expects the conditional branch instructions to state the condition (in this case pl/ne) after the "b" for branch. We also need to state that we're using the unified syntax, so that binutils 2.17 likes it as well. OpenSSL fixed that issue in

xargs(1): remove unused variable

The repllen variable is not used anywhere. Index: strnsubst.c === RCS file: /cvs/src/usr.bin/xargs/strnsubst.c,v retrieving revision 1.5 diff -u -r1.5 strnsubst.c --- strnsubst.c 27 Oct 2009 23:59:50 - 1.5 +++ strnsubst.c 3

Re: Recursive NET_LOCK()

On Tue, Jan 03, 2017 at 05:13:27PM +0100, Martin Pieuchot wrote: > It seems that most of the problems exposed by the introduction of the > NET_LOCK() are related to the non-recursive nature of the rwlock. Some > known issues involve pflow(4), cloning interfaces an NFS. > > Diff below makes use

compiler-rt: upgrade to 3.9.1 / fix gcc personality compile error

Hi, the GCC personality C file does not compile with clang 3.8 on ARM. They have fixed the issue in compiler-rt and released 3.9.1. Apparently that is the only thing they changed in the builtins. Thus this diff is in essence an update to the compiler-rt release 3.9.1. ok? Patrick diff --git

Re: Unable to boot since latest installer HTTPS changes

Hey, On 01/03/17 17:29, Theo de Raadt wrote: I am on AMD64. I cannot provide a dmesg of that machine because i am unable to boot it at all. Sure you can -- install 6.0 to do show it. stupid me, i did not think about that. Here i attached a fresh dmesg for you. Really sorry about that

Re: Unable to boot since latest installer HTTPS changes

> Hey tech@ > i wanted to upgrade to the latest snapshot (as i always do, every week) > but since you added the HTTPS support to the installer i am unable to > boot my system or the install.fs from a flash drive. > > I get to the MBR and then into the PBR but after probing all discs the >

Unable to boot since latest installer HTTPS changes

Hey tech@ i wanted to upgrade to the latest snapshot (as i always do, every week) but since you added the HTTPS support to the installer i am unable to boot my system or the install.fs from a flash drive. I get to the MBR and then into the PBR but after probing all discs the system restarts

Re: find -delete

OK millert@ for the code. I'll defer to jmc@ on the man page bits. - todd

Recursive NET_LOCK()

It seems that most of the problems exposed by the introduction of the NET_LOCK() are related to the non-recursive nature of the rwlock. Some known issues involve pflow(4), cloning interfaces an NFS. Diff below makes use of a recursive-rwlock instead. I just finished a build on NFS with it, so

Re: [PATCH] iked: Bugfixes for IKE rekeying

Am 09.11.2016 um 20:36 schrieb Vincent Gross: > On Wed, 9 Nov 2016 13:16:46 + > Thomas Klute wrote: > >> Hi tech@, >> >> this patch contains fixes for two bugs that break IKE rekeying >> initiated by iked. Please review, and apply or let me know what has to >> be

Re: if attach/detach netlocks

On 3 January 2017 at 12:06, Reyk Floeter wrote: > On Tue, Jan 03, 2017 at 11:42:21AM +0100, Martin Pieuchot wrote: >> On 02/01/17(Mon) 21:51, Mike Belopuhov wrote: >> > I got to test the diff and I had to make another adjustment: >> > vxlan_if_change is setup as a detach hook,

splsoftnet() in mroute

Diff below gets rid of the various splsoftnet() in multicast forwarding code. I've put asserts to ease review. While here remove #ifdef PIM leftovers. ok? Index: netinet/ip_mroute.c === RCS file: /cvs/src/sys/netinet/ip_mroute.c,v

Re: if attach/detach netlocks

On Tue, Jan 03, 2017 at 11:42:21AM +0100, Martin Pieuchot wrote: > On 02/01/17(Mon) 21:51, Mike Belopuhov wrote: > > On Fri, Dec 30, 2016 at 18:57 +0100, Mike Belopuhov wrote: > > > On Thu, Dec 29, 2016 at 09:30 +0100, Martin Pieuchot wrote: > > > > On 29/12/16(Thu) 01:15, Alexander Bluhm wrote: >

Re: if attach/detach netlocks

On 02/01/17(Mon) 21:51, Mike Belopuhov wrote: > On Fri, Dec 30, 2016 at 18:57 +0100, Mike Belopuhov wrote: > > On Thu, Dec 29, 2016 at 09:30 +0100, Martin Pieuchot wrote: > > > On 29/12/16(Thu) 01:15, Alexander Bluhm wrote: > > > > On Fri, Dec 23, 2016 at 12:09:32AM +0100, Martin Pieuchot wrote: >

Re: find -delete

On Tue, Jan 03, 2017 at 12:15:02AM -0500, Ted Unangst wrote: > This option is not posix (not like that's stopped find accumulating a dozen > extensions), but it is in gnu and freebsd (for 20 years). it's also somewhat > popular among sysadmins and blogs, etc. and perhaps most importantly, it >

Re: libressl symbols

After discussion from jsing and beck, this is wrong. I've fixed my issue in the net/py-cryptography port instead. On 2017 Jan 02 (Mon) at 17:06:46 +0100 (+0100), Reyk Floeter wrote: :Hi, : :the function prototypes have been moved from he header to the .c file - you will have to revert this

uaudio: preliminary patch for yamaha ur12 device support

Hi, Sending this patch to tech@ in case people have usb audio devices to test it. When connecting yamaha ur12 usb audio interface I was getting USBD_INVAL because of the aclen check. netbsd previously removed the check for aclen here: