[patch] Modify checking read ELF header file condition in ldd.c

2017-10-03 Thread Nan Xiao
Hi tech@, I think check the actual read ELF header file size is better than just "<0", thanks! Best Reagrds Nan Xiao Index: ldd.c === RCS file: /cvs/src/libexec/ld.so/ldd/ldd.c,v retrieving revision 1.21 diff -u -p -r1.21 ldd.c ---

Re: efiboot: Restore GOP mode on SetMode() failure

2017-10-03 Thread Andrew Daugherity
From: Klemens Nanni Date: 2017-09-16 13:58:21 Message-ID: <20170916135821.4245umgvha23b...@x230.example.com> >Updated diff introducing efi_gop_setmode() as helper to reduce duplicate >code and enhance readability. > >This code continues to work on three different UEFI implementations

[patch bgpd] Remove unused argument

2017-10-03 Thread Denis Fondras
Hi, The "struct peer" input of merge_config() is never used. Here is a patch to remove it. Denis Index: config.c === RCS file: /cvs/src/usr.sbin/bgpd/config.c,v retrieving revision 1.67 diff -u -p -r1.67 config.c --- config.c29

_kernel_lock_held() and panic()

2017-10-03 Thread Martin Pieuchot
WITNESS is fun. However it can lead you to DDB while trying to grab the KERNEL_LOCK(). In such case 'bo reboot' won't work because you'll certainly hit a KERNEL_ASSERT_LOCKED(). Here's an example: ddb{0}> c syncing disks... done panic: kernel diagnostic assertion "_kernel_lock_held()"

Re: Please test: kqueue & rwlock

2017-10-03 Thread Martin Pieuchot
On 12/09/17(Tue) 11:09, Martin Pieuchot wrote: > My previous attempt to grab the NET_LOCK(), thus potentially sleeping, > inside kqueue_scan() resulting in NULL dereferences: > https://marc.info/?l=openbsd-bugs=149935139022501=2 > > The problem is that the loop isn't ready to be consulted