Re: [patch] Add error check for fchmod in ldconfig.c

2018-06-07 Thread Scott Cheloha
On Thu, Jun 07, 2018 at 03:31:16PM +0800, Nan Xiao wrote: > Hi tech@, > > Maybe a error check of fchmod is necessary. [...] In that spot I think the only way fchmod can fail is with EIO. But, for sake of discussion, suppose it fails with EIO and then all the subsequent writes succeed and the

mg(1): add missing cscope function keybind

2018-06-07 Thread hajime
It seems to me that keymap.c need to change 'rescan' to 'csfuncalled' in 'static PF cCsc[] = { ... }'. The reason why I have an impression is that doesn't match between cscope.c, keymap.c and mg.1. As you can see as below, cscope.c's comment contains 'C-c s l' keybind. $ cd /src/usr.bin/mg $

Re: bgpd: stop with the announce confusion

2018-06-07 Thread Job Snijders
On Thu, Jun 07, 2018 at 12:14:07PM +0200, Claudio Jeker wrote: > > It would be helpful during upgrades if it's possible to write some > > configurations that work the same on both the old and new versions. > > That way the configuration can be changed to a version which will > > still work before

Re: bgpd: stop with the announce confusion

2018-06-07 Thread Claudio Jeker
On Thu, Jun 07, 2018 at 12:14:07PM +0200, Claudio Jeker wrote: > On Thu, Jun 07, 2018 at 10:20:17AM +0100, Stuart Henderson wrote: > > On 2018/06/07 10:26, Claudio Jeker wrote: > > > On Wed, Jun 06, 2018 at 11:04:56PM +0200, Claudio Jeker wrote: > > > > So the announce keyword in bgpd is massivly

Re: bgpd: stop with the announce confusion

2018-06-07 Thread Job Snijders
On Wed, Jun 06, 2018 at 11:04:56PM +0200, Claudio Jeker wrote: > The following diff does a few things. > a) it removes the `announce (all|none|self|default-route)` version > b) `announce none` is now `export none` > c) `announce default-route` is now `export default-route` > d) the examples file

Re: bgpd: stop with the announce confusion

2018-06-07 Thread Claudio Jeker
On Thu, Jun 07, 2018 at 10:20:17AM +0100, Stuart Henderson wrote: > On 2018/06/07 10:26, Claudio Jeker wrote: > > On Wed, Jun 06, 2018 at 11:04:56PM +0200, Claudio Jeker wrote: > > > So the announce keyword in bgpd is massivly overloaded. > > > It is one of the most common things new bgpd users

Re: bgpd: stop with the announce confusion

2018-06-07 Thread Stuart Henderson
On 2018/06/07 10:26, Claudio Jeker wrote: > On Wed, Jun 06, 2018 at 11:04:56PM +0200, Claudio Jeker wrote: > > So the announce keyword in bgpd is massivly overloaded. > > It is one of the most common things new bgpd users are unsure about. > > These are all possible announce options: > > > >

Re: bgpd: stop with the announce confusion

2018-06-07 Thread Claudio Jeker
On Wed, Jun 06, 2018 at 11:04:56PM +0200, Claudio Jeker wrote: > So the announce keyword in bgpd is massivly overloaded. > It is one of the most common things new bgpd users are unsure about. > These are all possible announce options: > > announce (IPv4|IPv6) (none|unicast|vpn) > announce

Re: Should whois(1) and IPv6 default to ANICHOST?

2018-06-07 Thread Mikolaj Kucharski
Hi, Any comments? On Sun, May 20, 2018 at 07:48:34PM +0100, Mikolaj Kucharski wrote: > Hi, > > This is very naive patch for whois(1) which makes it work > by default for IPv6 addresses. I went with very minimal > approach here. If string contains colon, it's asumed to > be IPv6 address.

[patch] Use snprintf to implement concat in etc.c

2018-06-07 Thread Nan Xiao
HI tech@, I think maybe one snprintf is more efficient and concise. Sorry if I am wrong, thanks! Index: etc.c === RCS file: /cvs/src/libexec/ld.so/ldconfig/etc.c,v retrieving revision 1.7 diff -u -p -r1.7 etc.c --- etc.c 12

[patch] Add error check for fchmod in ldconfig.c

2018-06-07 Thread Nan Xiao
Hi tech@, Maybe a error check of fchmod is necessary. Sorry if I am wrong, thanks! Index: ldconfig.c === RCS file: /cvs/src/libexec/ld.so/ldconfig/ldconfig.c,v retrieving revision 1.37 diff -u -p -r1.37 ldconfig.c --- ldconfig.c 26