Re: ping.c minor bug discrepancy between reported size of icmp packet

Hi, On 9/06/2018, at 7:52 AM, Tom Smyth wrote: > Hello I see a small discrepancy between the measurement > of sent and received packets as displayed by ping command > > on the wire the sent and received packets are the same size > I had a brief go > > foo# ping 5.134.88.1 > PING 5.134.88.1

Re: ping.c minor bug discrepancy between reported size of icmp packet

Hello Paul, All, Thanks for your clarification, I appreciate your help on this please find my reponses in line On 9 June 2018 at 09:40, Paul de Weerd wrote: > Hi Tom, > > This is documented in ping(8): > > -s packetsize > Specify the number of data bytes to be sent. The

Re: ping.c minor bug discrepancy between reported size of icmp packet

On Fri, Jun 08, 2018 at 08:52:17PM +0100, Tom Smyth wrote: > Hello I see a small discrepancy between the measurement > of sent and received packets as displayed by ping command > > on the wire the sent and received packets are the same size > I had a brief go > > foo# ping 5.134.88.1 > PING

Re: [patch] Use snprintf to implement concat in etc.c

Hi Philip, Thanks for your comments! On 6/9/2018 12:35 PM, Philip Guenther wrote: > On Thu, Jun 7, 2018 at 12:34 AM Nan Xiao > wrote: > > I think maybe one snprintf is more efficient and concise. Sorry if I am > wrong, thanks! > > > Seems unlikely.  More

Re: ping.c minor bug discrepancy between reported size of icmp packet

Hi Tom, This is documented in ping(8): -s packetsize Specify the number of data bytes to be sent. The default is 56, which translates into 64 ICMP data bytes when combined with the 8 bytes of ICMP header data. The maximum packet size is