Re: Do you have an AMD Ryzen or Epyc CPU?

2018-06-19 Thread Leo Unglaub
Hi, I applied your code on my AMD Ryzen 7 1700X. Below is the dmesg. I hope this helps, if you have any other AMD Ryzen related stuff that needs testing please let me know. Greetings Leo OpenBSD 6.3-current (GENERIC.MP) #2: Wed Jun 20 05:42:54 CEST 2018

iked support for IKEv2 Message Fragmentation (RFC 7383)

2018-06-19 Thread Tim Stewart
Hello tech@, My IKEv2 sessions are occasionally down due to transit networks dropping UDP fragments for one reason or another[1]. It happens frequently enough that I am considering implementing support for RFC 7383 in iked. Before I dig in, I feel that I should ask if anyone has already started

Re: Do you have an AMD Ryzen or Epyc CPU?

2018-06-19 Thread Durial EB
On Tue, Jun 19, 2018 at 4:32 PM Mark Kettenis wrote: > Looking for people that can run a kernel with the patch below and mail > me the resulting dmesg. > > Thanks, > > Mark > > > Index: arch/amd64/amd64/identcpu.c > === > RCS file:

Re: mandoc potential memory leak fix

2018-06-19 Thread Ingo Schwarze
Hi, Florian Obser wrote on Mon, Jun 18, 2018 at 06:54:49PM +0200: > On Mon, Jun 18, 2018 at 04:37:32PM +0200, Jan Schreiber wrote: >> this patch closes potential memory leaks in the mandoc memory >> wrapper functions and follows the examples in the manpages. > These are not leaks since mandoc

Do you have an AMD Ryzen or Epyc CPU?

2018-06-19 Thread Mark Kettenis
Looking for people that can run a kernel with the patch below and mail me the resulting dmesg. Thanks, Mark Index: arch/amd64/amd64/identcpu.c === RCS file: /cvs/src/sys/arch/amd64/amd64/identcpu.c,v retrieving revision 1.96 diff

Re: ospfd: deal with /etc/netstart, changes of netmask and dest_addr

2018-06-19 Thread Remi Locherer
On Tue, Jun 19, 2018 at 03:59:24PM +0100, Stuart Henderson wrote: > On 2018/06/18 08:53, Remi Locherer wrote: > > Index: ospfd.h > > === > > RCS file: /cvs/src/usr.sbin/ospfd/ospfd.h,v > > retrieving revision 1.100 > > diff -u -p

Re: On the matter of OpenBSD breaking embargos (KRACK)

2018-06-19 Thread Kevin Chadwick
On Tue, 19 Jun 2018 09:30:05 -0600 > > > > > ps. Disable Intel Hyper-Threading where not needed, until we all > > > know more. > > > > Is it safer to use bsd.sp for the time being? > > No, a better solution is coming. And in snapshots already. Thankyou for enabling us to patch ASAP.

Re: [patch] Add omitting period for ktrace(2) manual

2018-06-19 Thread Jason McIntyre
On Tue, Jun 19, 2018 at 04:22:26PM +0800, Nan Xiao wrote: > Hi tech@, > > To be consistent with other trace points, this patch adds omitting > period for KTRFAC_STRUCT, thanks! > fixed, thanks. jmc > Index: ktrace.2 > === > RCS

Re: Unlock sendit-based syscalls

2018-06-19 Thread Visa Hankala
On Tue, Jun 19, 2018 at 03:58:51PM +0200, Mark Kettenis wrote: > > Date: Tue, 19 Jun 2018 15:38:01 +0200 > > From: Martin Pieuchot > > > > On 19/06/18(Tue) 14:55, Mark Kettenis wrote: > > > > To avoid races with another thread that might be clearing our pointer > > > > in `fd_ofiles', we need

Re: On the matter of OpenBSD breaking embargos (KRACK)

2018-06-19 Thread Theo de Raadt
Kevin Chadwick wrote: > On Fri, 15 Jun 2018 17:28:14 -0600 > > > > ps. Disable Intel Hyper-Threading where not needed, until we all know > > more. > > Is it safer to use bsd.sp for the time being? No, a better solution is coming. And in snapshots already.

Re: On the matter of OpenBSD breaking embargos (KRACK)

2018-06-19 Thread Kevin Chadwick
On Fri, 15 Jun 2018 17:28:14 -0600 > ps. Disable Intel Hyper-Threading where not needed, until we all know > more. Is it safer to use bsd.sp for the time being?

Re: ospfd: deal with /etc/netstart, changes of netmask and dest_addr

2018-06-19 Thread Stuart Henderson
On 2018/06/18 08:53, Remi Locherer wrote: > Index: ospfd.h > === > RCS file: /cvs/src/usr.sbin/ospfd/ospfd.h,v > retrieving revision 1.100 > diff -u -p -r1.100 ospfd.h > --- ospfd.h 11 Feb 2018 02:27:33 - 1.100 > +++

Re: Prevent races w/ f_data

2018-06-19 Thread Mark Kettenis
> Date: Tue, 19 Jun 2018 15:45:48 +0200 > From: Martin Pieuchot > > On 19/06/18(Tue) 15:08, Mark Kettenis wrote: > > > Date: Tue, 19 Jun 2018 12:51:35 +0200 > > > From: Martin Pieuchot > > > > > > There's one place in our kernel where `f_data' is overwritten while the > > > descriptor sits in

Re: Unlock sendit-based syscalls

2018-06-19 Thread Mark Kettenis
> Date: Tue, 19 Jun 2018 15:38:01 +0200 > From: Martin Pieuchot > > On 19/06/18(Tue) 14:55, Mark Kettenis wrote: > > > To avoid races with another thread that might be clearing our pointer > > > in `fd_ofiles', we need more than atomic operations. For that we need > > > to serialize the

Re: Prevent races w/ f_data

2018-06-19 Thread Martin Pieuchot
On 19/06/18(Tue) 15:08, Mark Kettenis wrote: > > Date: Tue, 19 Jun 2018 12:51:35 +0200 > > From: Martin Pieuchot > > > > There's one place in our kernel where `f_data' is overwritten while the > > descriptor sits in multiple shared data structures. It is in diskmap. > > > > We want to avoid

Re: Unlock sendit-based syscalls

2018-06-19 Thread Martin Pieuchot
On 19/06/18(Tue) 14:55, Mark Kettenis wrote: > > To avoid races with another thread that might be clearing our pointer > > in `fd_ofiles', we need more than atomic operations. For that we need > > to serialize the threads. The most simple way to do so is with a mutex > > on a different data

Re: Prevent races w/ f_data

2018-06-19 Thread Mark Kettenis
> Date: Tue, 19 Jun 2018 12:51:35 +0200 > From: Martin Pieuchot > > There's one place in our kernel where `f_data' is overwritten while the > descriptor sits in multiple shared data structures. It is in diskmap. > > We want to avoid this situation to be able to treat f_data as immutable. > >

Re: Unlock sendit-based syscalls

2018-06-19 Thread Mark Kettenis
> Date: Tue, 19 Jun 2018 10:54:21 +0200 > From: Martin Pieuchot > > On 18/06/18(Mon) 18:18, Mark Kettenis wrote: > > > Date: Mon, 18 Jun 2018 11:24:00 +0200 > > > From: Martin Pieuchot > > > > > > Diff below is the last of the serie to remove the KERNEL_LOCK() from > > > sendto(2) and

Prevent races w/ f_data

2018-06-19 Thread Martin Pieuchot
There's one place in our kernel where `f_data' is overwritten while the descriptor sits in multiple shared data structures. It is in diskmap. We want to avoid this situation to be able to treat f_data as immutable. So the diff below remove `fp' from the shared data structures before it gets

Re: Unlock sendit-based syscalls

2018-06-19 Thread Martin Pieuchot
On 18/06/18(Mon) 18:18, Mark Kettenis wrote: > > Date: Mon, 18 Jun 2018 11:24:00 +0200 > > From: Martin Pieuchot > > > > Diff below is the last of the serie to remove the KERNEL_LOCK() from > > sendto(2) and sendmsg(2) for sockets protected by the NET_LOCK(). > > > > As explained previously [0]

[patch] Add omitting period for ktrace(2) manual

2018-06-19 Thread Nan Xiao
Hi tech@, To be consistent with other trace points, this patch adds omitting period for KTRFAC_STRUCT, thanks! Index: ktrace.2 === RCS file: /cvs/src/lib/libc/sys/ktrace.2,v retrieving revision 1.35 diff -u -p -r1.35 ktrace.2 ---