move the vlan_softc^Wifvlan definition from if_vlan_var.h to if_vlan.c

2019-04-25 Thread David Gwynne
nothing else in the kernel needs to look inside struct ifvlan. so this diff moves it. the next step will be renaming ifvlan to vlan_softc so it is like all the other drivers in the tree, and referring to it as "sc" instead of "ifv" as a variable. but this is a first step. ok? Index: if_vlan.c

[patch] cwm: filter duplicate hostnames in ssh menu

2019-04-25 Thread Bruno Flückiger
Hi, The ssh menu of cwm(1) doesn't filter duplicated hostnames when reading them from ~/.ssh/known_hosts. This patch makes sure each hostname is only displayed once to the menu. Cheers, Bruno Index: app/cwm/kbfunc.c === RCS file:

Re: Avoid system(3) in ikectl

2019-04-25 Thread Matthew Martin
On Thu, Apr 25, 2019 at 08:59:56PM -0600, Theo de Raadt wrote: > > + argv = alloca((n + 1) * sizeof(*argv)); > > Our source tree is exceedingly sparing in the use of alloca(). > This will not do. Was staying as close as possible to exec.c, but avoiding alloca is preferable; replaced with

Re: Avoid system(3) in ikectl

2019-04-25 Thread Theo de Raadt
> + argv = alloca((n + 1) * sizeof(*argv)); Our source tree is exceedingly sparing in the use of alloca(). This will not do.

Re: Avoid system(3) in ikectl

2019-04-25 Thread Matthew Martin
ping after unlock diff --git usr.sbin/ikectl/ikeca.c usr.sbin/ikectl/ikeca.c index bac76ab9c2f..09df5066820 100644 --- usr.sbin/ikectl/ikeca.c +++ usr.sbin/ikectl/ikeca.c @@ -18,11 +18,13 @@ #include #include +#include #include #include #include #include #include +#include

Re: uslcom: new product id

2019-04-25 Thread Remi Locherer
On Wed, Apr 24, 2019 at 10:19:13PM +0100, Jason McIntyre wrote: > On Wed, Apr 24, 2019 at 11:16:18PM +0200, Remi Locherer wrote: > > On Wed, Apr 24, 2019 at 08:54:08AM +0100, Jason McIntyre wrote: > > > On Wed, Apr 24, 2019 at 08:11:42AM +0100, Stuart Henderson wrote: > > > > On 2019/04/23 23:53,

Re: tmpfile and pledge

2019-04-25 Thread Todd C . Miller
On Thu, 25 Apr 2019 14:59:37 +0200, Martijn van Duren wrote: > The fchmod line was added by deraadt@ in r1.5 back in 1998, based on > std conformance mentioned by cas...@holland.sun.com. The texts that > I've consulted didn't mention anything about permission sets on the > file and unlinking the

Re: tmpfile and pledge

2019-04-25 Thread Todd C . Miller
That diff accidentally removed the unlink() but I'm not convinced it is a good idead either way as it introduces a race been open and unlink where another user could open the file, depending on the caller's umask. - todd

Re: update pixman to 0.38.4

2019-04-25 Thread Jeremie Courreges-Anglas
On Mon, Apr 15 2019, Matthieu Herrb wrote: > Hi, > > the diff below updates pixman to 0.38.4. > > Since upstream is too lazy to provide a ChangeLog, here are the main > changes from 0.36, picked up from their git log: > > - Implement floating point gradient computation, > - Use maximum precision

Re: tmpfile and pledge

2019-04-25 Thread Todd C . Miller
On Thu, 25 Apr 2019 09:34:47 -0600, Todd C. Miller wrote: > I think a better approach is to add an internal version of mkstemp(3) > that takes a permission flag. We can then pass in DEFFILEMODE for > the permission bits like stdio and avoid the umask and fchmod > entirely. Something like this

Re: xenocara: unlink libFS from the build

2019-04-25 Thread Jeremie Courreges-Anglas
On Mon, Apr 22 2019, Matthieu Herrb wrote: > On Thu, Mar 14, 2019 at 09:31:59PM +0100, Matthieu Herrb wrote: >> Hi, >> >> all tools dealing with X font server have been already removed, and >> don't seem to be missed since no one asked to re-add them in ports. >> >> Now, libFS, the font server

Re: tmpfile and pledge

2019-04-25 Thread Todd C . Miller
I think a better approach is to add an internal version of mkstemp(3) that takes a permission flag. We can then pass in DEFFILEMODE for the permission bits like stdio and avoid the umask and fchmod entirely. - todd

Re: tmpfile and pledge

2019-04-25 Thread Ted Unangst
Martijn van Duren wrote: > Is there a sound reason to keep this code here that I'm overlooking > or can we please remove it? I'll add that the umask calls make this function unsafe in a threaded program, which I think is unexpected.

tmpfile and pledge

2019-04-25 Thread Martijn van Duren
When playing with tmpfile(3) and pledge(2) I found that tmppath is not enough for tmpfile to succeed, since it needs fchmod support. This is logical considering the current implementation, but counter-intuitive with the tmppath pledge. The fchmod line was added by deraadt@ in r1.5 back in 1998,

Re: Talking about time (ntpd -s)

2019-04-25 Thread sven falempin
On Wed, Apr 24, 2019 at 2:39 PM Theo de Raadt wrote: > sven falempin wrote: > > > Dear Tech reader, > > > > NTPD -S is useful, when a device is in storage for a while the clock is > in > > disarray. > > But this assume the network exists, the fixed 15 seconds timeout makes > > sense, > >

Re: pledge(2)

2019-04-25 Thread Consus
On 10:46 Thu 25 Apr, NN wrote: > but why the dumped core file has named like (restricts_the_pr.core) and not > restricts_the_process.core? Process name can be up to 16 bytes, I guess that's it.

pledge(2)

2019-04-25 Thread NN
Hi all, look at my code restricts_the_process.c:     #include     #include     int     main() {         if(pledge("",NULL) == -1)            err(1,"pledge");         printf("Pledged\n");         return 0;     } I try to compile and run:     $ gcc -o restricts_the_process