Re: ospfctl json support

2020-08-21 Thread Richard Chivers
Hi, Any chance someone could take a look at this, we have written a prometheus exporter for bgp and ospf, which we would like to share, but it relies on having this json support in place. I have re-attached the original diff. Thanks Richard On Mon, Jun 1, 2020 at 7:52 AM Richard Chivers

PATCH: Add support for 64-bit MMIO to VMM

2020-08-21 Thread Jordan Hargrave
This patch is part of the PCI Passthrough VMM changes. This adds support for registering 64-bit MMIO regions and properly handles calculating BAR size for variable-lenth MMIO/IO regions. Verification via pcidump -v --- usr.sbin/vmd/pci.c | 69 +- 1

Re: *_clone_create: leave default ifq_maxlen handling to ifq_init()

2020-08-21 Thread Vitaliy Makkoveev
On Fri, Aug 21, 2020 at 11:05:56PM +0200, Klemens Nanni wrote: > Creating a cloned interface requires attaching it in the end, that's how > it works. > > All clonable interfaces start with a fresh softc structure that all > zeros after allocation due to malloc(9)'s M_ZERO flag. > > After driver

*_clone_create: leave default ifq_maxlen handling to ifq_init()

2020-08-21 Thread Klemens Nanni
Creating a cloned interface requires attaching it in the end, that's how it works. All clonable interfaces start with a fresh softc structure that all zeros after allocation due to malloc(9)'s M_ZERO flag. After driver dependent setup, all drivers call if_attach() to present the new interface to

Re: Enable EVFILT_EXCEPT

2020-08-21 Thread Visa Hankala
On Fri, Aug 21, 2020 at 09:32:13AM +0200, Martin Pieuchot wrote: > The kqueue-based poll(2) backend is still a WIP due to regressions in > the kqueue layer. In the meantime should we expose EVFILT_EXCEPT to > userland? The diff below should be enough to allow userland apps to > use the new code

Re: ldapd(8): fix, simplify UUID timestamp code

2020-08-21 Thread Jonathan Matthew
On Wed, Aug 19, 2020 at 09:28:41PM -0500, Scott Cheloha wrote: > Hi, > > I was auditing the tree for odd-looking time structure usage and I > came across the UUID code in ldapd(8), uuid.c. > > time_cmp() is backwards. Or the caller is misusing it. One or the > other. It returns -1 if tv1

diff: simplify ospf6d code

2020-08-21 Thread Jan Klemkow
Hi, The following diff simplifies a switch case statement with no functional change. In case of IMSG_CTL_SHOW_DATABASE duplicated code is removed. This part of the code is now the same as in ospfd. In case of IMSG_CTL_SHOW_DB_INTRA the code was also duplicated and due to a missing continue the

Re: diff: simplify ospf6d code

2020-08-21 Thread Claudio Jeker
On Fri, Aug 21, 2020 at 10:17:16AM +0200, Theo Buehler wrote: > On Fri, Aug 21, 2020 at 10:08:50AM +0200, Jan Klemkow wrote: > > Hi, > > > > The following diff simplifies a switch case statement with no functional > > change. > > > > In case of IMSG_CTL_SHOW_DATABASE duplicated code is removed.

Re: diff: simplify ospf6d code

2020-08-21 Thread Theo Buehler
On Fri, Aug 21, 2020 at 10:08:50AM +0200, Jan Klemkow wrote: > Hi, > > The following diff simplifies a switch case statement with no functional > change. > > In case of IMSG_CTL_SHOW_DATABASE duplicated code is removed. This part > of the code is now the same as in ospfd. This part looks fine.

Re: diff: simplify ospf6d code

2020-08-21 Thread Claudio Jeker
On Fri, Aug 21, 2020 at 10:08:50AM +0200, Jan Klemkow wrote: > Hi, > > The following diff simplifies a switch case statement with no functional > change. > > In case of IMSG_CTL_SHOW_DATABASE duplicated code is removed. This part > of the code is now the same as in ospfd. > > In case of

Re: Enable EVFILT_EXCEPT

2020-08-21 Thread Vitaliy Makkoveev
ok mvs@ > On 21 Aug 2020, at 10:32, Martin Pieuchot wrote: > > The kqueue-based poll(2) backend is still a WIP due to regressions in > the kqueue layer. In the meantime should we expose EVFILT_EXCEPT to > userland? The diff below should be enough to allow userland apps to > use the new code

Enable EVFILT_EXCEPT

2020-08-21 Thread Martin Pieuchot
The kqueue-based poll(2) backend is still a WIP due to regressions in the kqueue layer. In the meantime should we expose EVFILT_EXCEPT to userland? The diff below should be enough to allow userland apps to use the new code paths. ok? Index: sys/event.h