Re: net/pfvar.h: MAXPATHLEN -> PATH_MAX

Hello, On Tue, Oct 13, 2020 at 10:31:28PM +0200, Christian Weisgerber wrote: > In revision 1.407 of , deraadt@ replaced MAXPATHLEN > with PATH_MAX so userland wouldn't have to pull in . > > In 1.466, sashan@ accidentally slipped one MAXPATHLEN back in, > because its use is ubiquitous on the

Re: Non-const basename: bin/chio

On Tue, 13 Oct 2020 21:37:11 +0200, Christian Weisgerber wrote: > As far as I understand, the basename() here is specifically intended > to skip a leading "/dev/". So how about doing this expressly? That works for me. > Do we want to use _PATH_DEV or "/dev/"? There's a "/dev/rst%d" a > few

Re: Non-const basename: sbin/pfctl

Hello, On Tue, Oct 13, 2020 at 10:52:58PM +0200, Christian Weisgerber wrote: > Accommodate a basename(3) that takes a non-const parameter and may > in fact modify the string buffer. > > The length of anchor has already been checked in main(). > > ok? looks OK to me. sashan > > Index:

Non-const basename: sbin/pfctl

Accommodate a basename(3) that takes a non-const parameter and may in fact modify the string buffer. The length of anchor has already been checked in main(). ok? Index: sbin/pfctl/pfctl.c === RCS file: /cvs/src/sbin/pfctl/pfctl.c,v

net/pfvar.h: MAXPATHLEN -> PATH_MAX

In revision 1.407 of , deraadt@ replaced MAXPATHLEN with PATH_MAX so userland wouldn't have to pull in . In 1.466, sashan@ accidentally slipped one MAXPATHLEN back in, because its use is ubiquitous on the kernel side of pf. Switch this over to PATH_MAX again. pfctl(8) doesn't actually use this,

Non-const basename: bin/chio

As far as I understand, the basename() here is specifically intended to skip a leading "/dev/". So how about doing this expressly? Do we want to use _PATH_DEV or "/dev/"? There's a "/dev/rst%d" a few lines outside of the diff context... Index: bin/chio/parse.y

Re: [PATCH] Add IOMMU support for Intel VT-d and AMD-Vi

> Date: Thu, 8 Oct 2020 00:34:28 -0500 > From: Jordan Hargrave > > Ok updated the new changes. I think this is good enough for further cleanup in the tree now. Builds all thr amd64 kernels, doesn't break i386 and arm64 GENERIC.MP. However, I think acpidmar(4) shouldn't be enabled yet until

Re: Unbound 1.12.0

On 2020-10-13 07:25, Stuart Henderson wrote: On 2020/10/11 15:37, Renaud Allard wrote: On 10/10/2020 22:05, Stuart Henderson wrote: Here's an update to the recently released version of Unbound. Much of the additional code is for DoH and is unused here as it requires the nghttp2 library.

Non-const basename: usr.sbin/hotplugd

Accommodate a basename(3) that takes a non-const parameter and may in fact modify the string buffer. Between access(file, ...) and execl(file, ...), no check for truncation should be necessary. ok? Index: usr.sbin/hotplugd/hotplugd.c

Re: Unbound 1.12.0

On 2020/10/11 15:37, Renaud Allard wrote: > > > On 10/10/2020 22:05, Stuart Henderson wrote: > > Here's an update to the recently released version of Unbound. Much of > > the additional code is for DoH and is unused here as it requires the > > nghttp2 library. > > > > nghttp2 seems to be MIT

Diff to allow selection of source IP address

Is anyone interested in this ? This diff allows to select the default source IP address (for TCP/UDP connections) on multi-homed & "multi-addressed" machines. Looking for feedbacks on what I broke. Do not test with ping(8) as it uses another source address selection codepath. `curl ifconfig.co`

Re: WANTLIB problems and possible solution: the libset design

On Sun, Oct 11, 2020 at 06:03:55PM +0200, Landry Breuil wrote: > On Sun, Oct 11, 2020 at 05:03:31PM +0200, Marc Espie wrote: > > On Sun, Oct 11, 2020 at 04:53:18PM +0200, Christian Weisgerber wrote: > > > Marc Espie: > > > > > > > The new design: > > > > > > > > The idea behind "libset" is to be

Re: WANTLIB problems and possible solution: the libset design

On Sun, Oct 11, 2020 at 06:03:55PM +0200, Landry Breuil wrote: > On Sun, Oct 11, 2020 at 05:03:31PM +0200, Marc Espie wrote: > > On Sun, Oct 11, 2020 at 04:53:18PM +0200, Christian Weisgerber wrote: > > > Marc Espie: > > > > > > > The new design: > > > > > > > > The idea behind "libset" is to be

Re: Non-const basename: libkvm

On Tue, 13 Oct 2020 11:05:42 +0200, Christian Weisgerber wrote: > Accommodate a basename(3) that takes a non-const parameter and may > in fact modify the string buffer. > > Note that strlen(uf) >= PATH_MAX is already checked by the caller > in _kvm_open(). OK. - todd

Non-const basename: libkvm

Accommodate a basename(3) that takes a non-const parameter and may in fact modify the string buffer. Note that strlen(uf) >= PATH_MAX is already checked by the caller in _kvm_open(). ok? Index: lib/libkvm/kvm.c === RCS file: