Re: timeout.9: document kclock timeouts + a bunch of other changes

2021-06-23 Thread Jason McIntyre
On Wed, Jun 23, 2021 at 06:57:00PM -0500, Scott Cheloha wrote: > Hi, > > I want to document kclock timeouts so others can use them. > morning. reads fine, except one issue: > > Index: share/man/man9/timeout.9 > === > RCS file:

Re: if_etherbridge.c vs. parallel forwarding

2021-06-23 Thread David Gwynne
On Sat, Jun 19, 2021 at 12:32:04AM +0200, Alexandr Nedvedicky wrote: > Hello, > > skip reading if you are not interested in L2 switching combined > with bluhm's diff [1], which enables parallel forwarding. > > Hrvoje gave it a try and soon discovered some panics. Diff below > fixes a panic

timeout.9: document kclock timeouts + a bunch of other changes

2021-06-23 Thread Scott Cheloha
Hi, I want to document kclock timeouts so others can use them. I think timeout.9 itself could use some cleanup, both to reflect the current state of the API and to improve the documentation in general. This patch includes two small API changes: 1. Combine timeout_set_kclock() and

Re: Bad comparison between double and uint64_t

2021-06-23 Thread Masato Asou
Hi Ali, In this case, ULLONG_MAX is implicitly cast to double, isn't it? Do you have any problems if you don't cast to double? -- ASOU Masato From: Ali Farzanrad Date: Wed, 23 Jun 2021 20:24:27 + > Oh, my bad, sorry. > I assumed that val is always integer. > I guess it is better to

Re: Bad comparison between double and uint64_t

2021-06-23 Thread Ali Farzanrad
Oh, my bad, sorry. I assumed that val is always integer. I guess it is better to ignore val == ULLONG_MAX: === RCS file: /cvs/src/sbin/disklabel/editor.c,v retrieving revision 1.368 diff -u -p -r1.368 editor.c --- editor.c

Bad comparison between double and uint64_t

2021-06-23 Thread Ali Farzanrad
Hi tech@, disklabel shows a warning at build time which might be important. Following diff will surpass the warning. === RCS file: /cvs/src/sbin/disklabel/editor.c,v retrieving revision 1.368 diff -u -p -r1.368 editor.c --- editor.c

Re: amd64: softintr_dispatch: remove kernel lock

2021-06-23 Thread Visa Hankala
On Wed, Jun 23, 2021 at 05:39:05PM +0200, Mark Kettenis wrote: > > Date: Wed, 23 Jun 2021 15:32:03 + > > From: Visa Hankala > > > > On Wed, Jun 23, 2021 at 05:15:05PM +0200, Mark Kettenis wrote: > > > > Date: Wed, 23 Jun 2021 14:56:45 + > > > > From: Visa Hankala > > > > > > > > On

Re: amd64: softintr_dispatch: remove kernel lock

2021-06-23 Thread Mark Kettenis
> Date: Wed, 23 Jun 2021 15:32:03 + > From: Visa Hankala > > On Wed, Jun 23, 2021 at 05:15:05PM +0200, Mark Kettenis wrote: > > > Date: Wed, 23 Jun 2021 14:56:45 + > > > From: Visa Hankala > > > > > > On Tue, Jun 22, 2021 at 09:46:22AM -0500, Scott Cheloha wrote: > > > > On Mon, Jun

Re: amd64: softintr_dispatch: remove kernel lock

2021-06-23 Thread Visa Hankala
On Wed, Jun 23, 2021 at 05:15:05PM +0200, Mark Kettenis wrote: > > Date: Wed, 23 Jun 2021 14:56:45 + > > From: Visa Hankala > > > > On Tue, Jun 22, 2021 at 09:46:22AM -0500, Scott Cheloha wrote: > > > On Mon, Jun 21, 2021 at 02:04:30PM +, Visa Hankala wrote: > > > > On Thu, May 27, 2021

Re: amd64: softintr_dispatch: remove kernel lock

2021-06-23 Thread Mark Kettenis
> Date: Wed, 23 Jun 2021 14:56:45 + > From: Visa Hankala > > On Tue, Jun 22, 2021 at 09:46:22AM -0500, Scott Cheloha wrote: > > On Mon, Jun 21, 2021 at 02:04:30PM +, Visa Hankala wrote: > > > On Thu, May 27, 2021 at 07:40:26PM -0500, Scott Cheloha wrote: > > > > On Sun, May 23, 2021 at

Re: amd64: softintr_dispatch: remove kernel lock

2021-06-23 Thread Visa Hankala
On Tue, Jun 22, 2021 at 09:46:22AM -0500, Scott Cheloha wrote: > On Mon, Jun 21, 2021 at 02:04:30PM +, Visa Hankala wrote: > > On Thu, May 27, 2021 at 07:40:26PM -0500, Scott Cheloha wrote: > > > On Sun, May 23, 2021 at 09:05:24AM +, Visa Hankala wrote: > > > > When a CPU starts processing

Re: new kqueue-based select(2) implementation

2021-06-23 Thread Theo de Raadt
Alexander Bluhm wrote: > On Wed, Jun 23, 2021 at 11:40:18AM +0200, Martin Pieuchot wrote: > > Our previous attempt [0] to replace the current select(2) implementation > > has been reverted due to non-acceptable latency increase on sockets [1]. > > I have measured the performance difference. >

Re: new kqueue-based select(2) implementation

2021-06-23 Thread Alexander Bluhm
On Wed, Jun 23, 2021 at 11:40:18AM +0200, Martin Pieuchot wrote: > Our previous attempt [0] to replace the current select(2) implementation > has been reverted due to non-acceptable latency increase on sockets [1]. I have measured the performance difference.

Re: uao references & uao_swap_off() cleanup

2021-06-23 Thread Jonathan Matthew
On Wed, Jun 23, 2021 at 09:37:10AM +0200, Martin Pieuchot wrote: > On 16/06/21(Wed) 11:26, Martin Pieuchot wrote: > > Diff below does two things: > > > > - Use atomic operations for incrementing/decrementing references of > > anonymous objects. This allows us to manipulate them without holding

base-gcc: fix -Wno-error=uninitialized

2021-06-23 Thread Jeremie Courreges-Anglas
In base-gcc -Wno-error=uninitialized is currently ineffective, in that cc1 still errors out with the following flags combination: billy /tmp$ cat t.c #include int f(void) { int r; return r; } billy /tmp$ gcc -v -c -O2 -Wall -Werror -Wno-error=uninitialized

Re: sparc64: enable dt(4) in GENERIC

2021-06-23 Thread Mark Kettenis
> Date: Wed, 23 Jun 2021 11:43:47 +0200 > From: Martin Pieuchot > > Similar to what has been done on x86 & arm64, ok? ok kettenis@ > Index: conf/GENERIC > === > RCS file: /cvs/src/sys/arch/sparc64/conf/GENERIC,v > retrieving

sparc64: enable dt(4) in GENERIC

2021-06-23 Thread Martin Pieuchot
Similar to what has been done on x86 & arm64, ok? Index: conf/GENERIC === RCS file: /cvs/src/sys/arch/sparc64/conf/GENERIC,v retrieving revision 1.316 diff -u -p -r1.316 GENERIC --- conf/GENERIC4 Feb 2021 16:25:39 -

new kqueue-based select(2) implementation

2021-06-23 Thread Martin Pieuchot
Our previous attempt [0] to replace the current select(2) implementation has been reverted due to non-acceptable latency increase on sockets [1]. This performance regression has been analysed and partially addressed thanks to bluhm@ and visa@. The cost of allocating/freeing 'knote' descriptors

Re: snmpd(8) Better traphandler flow

2021-06-23 Thread Stuart Henderson
On 2021/06/20 22:31, Martijn van Duren wrote: > On Fri, 2021-06-11 at 16:13 +0200, Martijn van Duren wrote: > > any takers? > > > > On Fri, 2021-06-04 at 22:11 +0200, Martijn van Duren wrote: > > > ping > > > > > > On Fri, 2021-05-28 at 08:19 +0200, Martijn van Duren wrote: > > > > As the

Re: uao references & uao_swap_off() cleanup

2021-06-23 Thread Martin Pieuchot
On 16/06/21(Wed) 11:26, Martin Pieuchot wrote: > Diff below does two things: > > - Use atomic operations for incrementing/decrementing references of > anonymous objects. This allows us to manipulate them without holding > the KERNEL_LOCK(). > > - Rewrite the loop from uao_swap_off() to only