msk(4) txeof should use completion indexes from status descriptors

2022-01-04 Thread David Gwynne
this is what i want to commit to fix "msk(4) not working with trunk(4) (Marvell Yukon 88E8042)" as reported on bugs@. the register that msk_txeof currently uses to figure out where it should read up to appears to be more a counter than an actual index. the linux driver doesnt use it though, it

Re: mpsafe dwxe(4)

2022-01-04 Thread Mike Larkin
On Mon, Jan 03, 2022 at 09:24:15PM +1000, Jonathan Matthew wrote: > This is almost identical to the changes I made to dwge(4) recently, since > these drivers are very closely related. Unfortunately the only machine I > have with dwxe(4) in it is armv7, so I can't test this properly, but it > does

Re: rpki-client pass real filename from parser back to parent

2022-01-04 Thread Theo Buehler
On Tue, Jan 04, 2022 at 07:20:47PM +0100, Claudio Jeker wrote: > On Tue, Jan 04, 2022 at 04:57:23PM +0100, Theo Buehler wrote: > > On Tue, Jan 04, 2022 at 04:15:56PM +0100, Claudio Jeker wrote: > > > This is another diff on the way to having a validated repo. > > > Pass the filename of the entity

Re: rpki-client pass real filename from parser back to parent

2022-01-04 Thread Claudio Jeker
On Tue, Jan 04, 2022 at 04:57:23PM +0100, Theo Buehler wrote: > On Tue, Jan 04, 2022 at 04:15:56PM +0100, Claudio Jeker wrote: > > This is another diff on the way to having a validated repo. > > Pass the filename of the entity which was parsed back to the parent. > > With this we can move the

Re: rpki-client pass real filename from parser back to parent

2022-01-04 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2022.01.04 16:15:56 +0100: > This is another diff on the way to having a validated repo. > Pass the filename of the entity which was parsed back to the parent. > With this we can move the filepath_add() call from entity_write_req() > to entity_process().

Re: unbreak rpki-client -n mode

2022-01-04 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2022.01.04 16:05:57 +0100: > Currently running rpki-client -n with an up to date repo results in the > loss of around 25% of ROAs. The reason is that most of apnic fails since > they decided it is a glorious idea to put two rsync repos into one rrdp >

Re: unbreak rpki-client -n mode

2022-01-04 Thread Theo Buehler
On Tue, Jan 04, 2022 at 04:05:57PM +0100, Claudio Jeker wrote: > Currently running rpki-client -n with an up to date repo results in the > loss of around 25% of ROAs. The reason is that most of apnic fails since > they decided it is a glorious idea to put two rsync repos into one rrdp > repo. >

Re: rpki-client pass real filename from parser back to parent

2022-01-04 Thread Theo Buehler
On Tue, Jan 04, 2022 at 04:15:56PM +0100, Claudio Jeker wrote: > This is another diff on the way to having a validated repo. > Pass the filename of the entity which was parsed back to the parent. > With this we can move the filepath_add() call from entity_write_req() > to entity_process(). As a

rpki-client pass real filename from parser back to parent

2022-01-04 Thread Claudio Jeker
This is another diff on the way to having a validated repo. Pass the filename of the entity which was parsed back to the parent. With this we can move the filepath_add() call from entity_write_req() to entity_process(). As a side-effect the "Already visited" check is moved after parsing so a file

unbreak rpki-client -n mode

2022-01-04 Thread Claudio Jeker
Currently running rpki-client -n with an up to date repo results in the loss of around 25% of ROAs. The reason is that most of apnic fails since they decided it is a glorious idea to put two rsync repos into one rrdp repo. When changing the repo state for the noop case from REPO_DONE to

Re: Driver for PolarFire SoC clock controller

2022-01-04 Thread Visa Hankala
On Mon, Jan 03, 2022 at 08:44:22PM +0100, Mark Kettenis wrote: > > Date: Mon, 3 Jan 2022 16:31:29 + > > From: Visa Hankala > > > > This adds an initial driver for the PolarFire SoC MSS clock controller. > > > > The driver also provides a reset function for the SoC. The soft reset > >

Re: fix some -Wunused-but-set-variable warnings in vmd

2022-01-04 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2022.01.04 14:12:02 +0100: > On Tue, Jan 04, 2022 at 10:58:41AM +0100, Claudio Jeker wrote: > > This are obvious and easy to fix unused but set variables. > > There are more in vioscsi.c but those are actually used if compiled with > > DEBUG set. > > The

Re: fix some -Wunused-but-set-variable warnings in vmd

2022-01-04 Thread Dave Voutila
Claudio Jeker writes: > On Tue, Jan 04, 2022 at 10:58:41AM +0100, Claudio Jeker wrote: >> This are obvious and easy to fix unused but set variables. >> There are more in vioscsi.c but those are actually used if compiled with >> DEBUG set. > > The changes in loadfile_elf.c, vioqcow2.c and vmd.c

Re: rpki-client: simplify verify callback

2022-01-04 Thread Claudio Jeker
On Tue, Jan 04, 2022 at 02:48:17PM +0100, Theo Buehler wrote: > As discussed in the previous thread, we can simplify the verify callback > by getting rid of the extremely noisy warnx at the end. Fail directly on > encountering an unknown critical extension and succeed otherwise. OK claudio@ (and

Re: fix some -Wunused-but-set-variable warnings in vmd

2022-01-04 Thread Claudio Jeker
On Tue, Jan 04, 2022 at 08:42:29AM -0500, Dave Voutila wrote: > > Claudio Jeker writes: > > > This are obvious and easy to fix unused but set variables. > > There are more in vioscsi.c but those are actually used if compiled with > > DEBUG set. > > ok dv@, but maybe just nuke that fd variable

rpki-client: simplify verify callback

2022-01-04 Thread Theo Buehler
As discussed in the previous thread, we can simplify the verify callback by getting rid of the extremely noisy warnx at the end. Fail directly on encountering an unknown critical extension and succeed otherwise. Index: parser.c ===

Re: [PATCH] [src] etc/etc.*/login.conf, share/man/man5/login.conf.5, libexec/login_radius/login_radius.8

2022-01-04 Thread Jason McIntyre
On Tue, Dec 28, 2021 at 06:46:03PM +, Raf Czlonka wrote: > Hello, > > Most changes touch the same files hence a single email and diff: > > - login_ldap(8) is missing from login.conf(5) > - capitalise 'radius' where talking about the protocol, and use an > indefinite article where relevant

Re: fix some -Wunused-but-set-variable warnings in vmd

2022-01-04 Thread Dave Voutila
Claudio Jeker writes: > This are obvious and easy to fix unused but set variables. > There are more in vioscsi.c but those are actually used if compiled with > DEBUG set. ok dv@, but maybe just nuke that fd variable in vioqcow2 instead? Index: vioqcow2.c

remove ieee80211_find_node_for_beacon()

2022-01-04 Thread Stefan Sperling
The function ieee80211_find_node_for_beacon() was added by reyk on 2005. At the time, net80211 nodes were stored in a hash table keyed on hashes the node's source MAC addresses. The purpose of ieee80211_find_node_for_beacon() was to avoid storing duplicate nodes with the same source MAC address in

Re: fix some -Wunused-but-set-variable warnings in vmd

2022-01-04 Thread Claudio Jeker
On Tue, Jan 04, 2022 at 10:58:41AM +0100, Claudio Jeker wrote: > This are obvious and easy to fix unused but set variables. > There are more in vioscsi.c but those are actually used if compiled with > DEBUG set. The changes in loadfile_elf.c, vioqcow2.c and vmd.c are trivial and can be committed

Re: rpki-client: check ipAddrBlock and autonomousSysNum for criticality

2022-01-04 Thread Claudio Jeker
On Wed, Dec 29, 2021 at 01:12:25PM +0100, Claudio Jeker wrote: > On Wed, Dec 29, 2021 at 01:06:30AM +0100, Theo Buehler wrote: > > On Tue, Dec 28, 2021 at 05:08:46PM +0100, Claudio Jeker wrote: > > > On Mon, Dec 27, 2021 at 12:23:32PM +0100, Theo Buehler wrote: > > > > On Sat, Dec 25, 2021 at

fix some -Wunused-but-set-variable warnings in vmd

2022-01-04 Thread Claudio Jeker
This are obvious and easy to fix unused but set variables. There are more in vioscsi.c but those are actually used if compiled with DEBUG set. -- :wq Claudio Index: loadfile_elf.c === RCS file:

Re: [PATCH] [src] etc/etc.*/login.conf, share/man/man5/login.conf.5, libexec/login_radius/login_radius.8

2022-01-04 Thread Stuart Henderson
On 2021/12/28 18:46, Raf Czlonka wrote: > I was also thinking of normalising 'snk' as it is described as: > > "Digital Pathways SecureNet Key authentication" > > in login.conf(5), but: > > "SNK-004 authentication" > > in all of its manual pages - login_snk(8), snkadm(8), and