Re: [External] : Re: pf igmp icmp6 multicast router alert

2022-04-27 Thread Alexandr Nedvedicky
Hello, On Thu, Apr 28, 2022 at 12:00:09AM +0200, Alexander Bluhm wrote: > On Fri, Apr 22, 2022 at 07:40:17PM +0200, Alexandr Nedvedicky wrote: > > > + case IPPROTO_ICMPV6: > > > + if (!pf_pull_hdr(pd->m, pd->off, , sizeof(icmp6), > > > + NULL, reason,

Re: pf igmp icmp6 multicast router alert

2022-04-27 Thread Alexander Bluhm
On Wed, Apr 27, 2022 at 11:47:45PM +0200, Alexander Bluhm wrote: > New diff: > - make off and end relative to opts array > - check length of IPv4 options > - fix call to pf_walk_option > - add case IP6OPT_PADN > - add case MLDV2_LISTENER_REPORT - pf_pull_hdr() before pf_walk_option6() was missing

Re: [External] : Re: pf igmp icmp6 multicast router alert

2022-04-27 Thread Alexander Bluhm
On Fri, Apr 22, 2022 at 07:40:17PM +0200, Alexandr Nedvedicky wrote: > > + case IPPROTO_ICMPV6: > > + if (!pf_pull_hdr(pd->m, pd->off, , sizeof(icmp6), > > + NULL, reason, AF_INET6)) { > > + DPFPRINTF(LOG_NOTICE, "IPv6

Re: pf igmp icmp6 multicast router alert

2022-04-27 Thread Alexander Bluhm
On Fri, Apr 22, 2022 at 09:03:45PM +0200, Otto Moerbeek wrote: > On Fri, Apr 22, 2022 at 05:59:18PM +0200, Alexander Bluhm wrote: > > > On Thu, Apr 21, 2022 at 09:10:02PM +0200, Alexander Bluhm wrote: > > > The option I have ever seen in the wild is router alert. So it may > > > be better to

Remove obsolete key format line from example known_hosts in sshd(8)

2022-04-27 Thread Megan Batty
I was working on an external parser for known_hosts files and found this line in the sshd(8) man page that didn't match the format description above and wasn't sure how to deal with it. After briefly discussing with Bob Beck, I realized that it's the obsolete rsa1 format key that appears to be

Re: sndio: add sio_flush() function

2022-04-27 Thread Caspar Schutijser
Hi, On Thu, Mar 24, 2022 at 07:11:42AM +0100, Alexandre Ratchov wrote: > Most audio/video players do a stop/start cycle whenever the play > position is changed, track is changed, etc. Currently, stopping drains > the play buffer, which by default is very large (to workaround very > long kernel

Re: Use vgonel() in vop_generic_revoke

2022-04-27 Thread Sebastien Marie
On Wed, Apr 27, 2022 at 12:27:13PM +0200, Claudio Jeker wrote: > This is just a mini cleanup. Switch from vgone() to vgonel() like it is > done a bit later already. vgone() is just a wrapper around vgonel() using > curproc (which is cached in vop_generic_revoke()). > > -- > :wq Claudio ok

simplify spec_close()

2022-04-27 Thread Claudio Jeker
spec_close() does a fair bit of extra work around the xlock flag. Now spec_close() is called via VOP_CLOSE and either the vnode has VXLOCK set (because it is called via vclean()) or it does not. In either case VXLOCK can not change during call (at least that was my conclusion looking at the code).

Use vgonel() in vop_generic_revoke

2022-04-27 Thread Claudio Jeker
This is just a mini cleanup. Switch from vgone() to vgonel() like it is done a bit later already. vgone() is just a wrapper around vgonel() using curproc (which is cached in vop_generic_revoke()). -- :wq Claudio Index: vfs_default.c

cleanup multicast rttimer queues

2022-04-27 Thread Claudio Jeker
There is no need to have a rttimer queue per rdomain. The rttimer itself is rdomain aware and so this just make everything more complicated for no gain. This diff just drops back to a single queue and initializes the queues in ip_init() and the IPv6 counterpart. I have no mrouter setup to test

Re: btrace hist printing large numbers

2022-04-27 Thread Mark Kettenis
> From: "Ted Unangst" > Date: Wed, 27 Apr 2022 04:07:24 -0400 > > btrace needs a little more help printing very large numbers. If you > have something like 2^61 in your histogram, it gets printed as 1K > because that's what's left over after dividing by G and M. Add some > more units, and it

btrace hist printing large numbers

2022-04-27 Thread Ted Unangst
btrace needs a little more help printing very large numbers. If you have something like 2^61 in your histogram, it gets printed as 1K because that's what's left over after dividing by G and M. Add some more units, and it prints as 1E. (It seems like there might be another bug, because I'm not