Can libc funcs be optimizable for no return value?

2022-06-06 Thread Luke Small
I noticed that when I ran strlcpy in cc with both directly from libc and copied from source: “with and without needing a return value”, the libc strlcpy didn’t change the runtime, but the one from source did; dramatically (like 50% runtime difference over a several run loop with 15-20 or so

potential memory leak in if_vinput()

2022-06-06 Thread Alexandr Nedvedicky
Hello, I've spotted this glitch while hunting down use after-free in 'veb' packet path. I believe the issue is rather hypothetical, there is no evidence the deemed memory leak ever occurred. Anyway I believe the if_vinput() should always consume packet by either passing it further when

Re: Fix clearing of sleep timeouts

2022-06-06 Thread Visa Hankala
On Mon, Jun 06, 2022 at 06:47:32AM +1000, David Gwynne wrote: > On Sun, Jun 05, 2022 at 03:57:39PM +, Visa Hankala wrote: > > On Sun, Jun 05, 2022 at 12:27:32PM +0200, Martin Pieuchot wrote: > > > On 05/06/22(Sun) 05:20, Visa Hankala wrote: > > > > Encountered the following panic: > > > > > >

Re: relayd panic

2022-06-06 Thread David Gwynne
> On 6 Jun 2022, at 18:08, Claudio Jeker wrote: > > On Mon, Jun 06, 2022 at 12:03:06AM +0200, Alexandr Nedvedicky wrote: >> Hello, >> >> I'll commit one-liner diff on Tuesday morning (Jun 6th) Prague time without >> explicit OK, unless there will be no objection. > > The diff is OK

Re: Fix clearing of sleep timeouts

2022-06-06 Thread Martin Pieuchot
On 06/06/22(Mon) 06:47, David Gwynne wrote: > On Sun, Jun 05, 2022 at 03:57:39PM +, Visa Hankala wrote: > > On Sun, Jun 05, 2022 at 12:27:32PM +0200, Martin Pieuchot wrote: > > > On 05/06/22(Sun) 05:20, Visa Hankala wrote: > > > > Encountered the following panic: > > > > > > > > panic: kernel

Re: ix(4): Add support for TCP Large Receive Offloading

2022-06-06 Thread Hrvoje Popovski
On 4.6.2022. 21:23, Hrvoje Popovski wrote: > On 1.6.2022. 11:21, Jan Klemkow wrote: >> I moved the switch to ifconfig(8) in the diff below. >> >> # ifconfig ix0 tso >> # ifconfig ix0 -tso >> >> I named it tso (TCP segment offloading), so I can reuse this switch >> also for the sending part. TSO

Re: relayd panic

2022-06-06 Thread Claudio Jeker
On Mon, Jun 06, 2022 at 12:03:06AM +0200, Alexandr Nedvedicky wrote: > Hello, > > I'll commit one-liner diff on Tuesday morning (Jun 6th) Prague time without > explicit OK, unless there will be no objection. The diff is OK claudio@. > regards > sashan > > > On Sun, Jun 05, 2022 at 09:44:45AM