Remove unnecessary NOWITNESS kludge

2023-07-04 Thread Visa Hankala
Initialize stack-based mutexed using mtx_init(). This removes the need of the NOWITNESS kludge and lets the lock checker do its job with these mutexes. At the moment, static initialization of locks inside functions does not work correctly with WITNESS. A lock initializer sets up a struct that

Re: pf.os database /p0f

2023-07-04 Thread Lee, Jonathan D
Hello, the empty section yes would need to be pre-populated. Thanks for adding visibility to this as I noticed OpenBSD has p0f as well as FreeBSD the FreeBSD PfSense is being used as an example. Yes this database is starting to show it’s age. > On Jul 4, 2023, at 1:22 AM, Stuart Henderson

Re: Diff for evaluation (WACOM tablet driver)

2023-07-04 Thread Thomas Frohwein
On Mon, Jul 03, 2023 at 11:22:45AM +0200, Marc Espie wrote: > I hope Vladimir will find the time to complete this answer. > > As far as Vlad's work goes, he did a presentation last week-end: > https://www.lre.epita.fr/news_content/SS_summer_week_pres/Vladimir_Driver_OpenBSD.pptx > > (sorry for

Re: pf.os database /p0f

2023-07-04 Thread Theo de Raadt
Lee, Jonathan D wrote: > Hello, the empty section yes, I agree would still need to be populated. > Thanks for adding some fresh visibility to this problem as I noticed OpenBSD > has p0f as well as FreeBSD the FreeBSD is being used as an example with > PfSense. > > The p0f database is

Re: pf(4) should mention DIOCXEND

2023-07-04 Thread Jason McIntyre
On Tue, Jul 04, 2023 at 04:35:23PM +0200, Alexandr Nedvedicky wrote: > Hello, > > diff below updates pf(4) manpage to reflect changes [1] which > were committed earlier today. > > does update to pf(4) read OK? > > thanks and > regards > sashan > > [1]

Re: pf.os database /p0f

2023-07-04 Thread Lee, Jonathan D
Hello, the empty section yes, I agree would still need to be populated. Thanks for adding some fresh visibility to this problem as I noticed OpenBSD has p0f as well as FreeBSD the FreeBSD is being used as an example with PfSense. The p0f database is starting to show its age. I am just

Re: validate vm.conf local prefixes in parser

2023-07-04 Thread Claudio Jeker
On Tue, Jul 04, 2023 at 11:39:19AM -0400, Dave Voutila wrote: > vmd's doing something close to shotgun parsing of the "local prefix" and > "local inet6 prefix" settings in vm.conf(5). The parser intermixes ipv4 > and ipv6 parsing even when we know which one is valid in the parsing > context. This

validate vm.conf local prefixes in parser

2023-07-04 Thread Dave Voutila
vmd's doing something close to shotgun parsing of the "local prefix" and "local inet6 prefix" settings in vm.conf(5). The parser intermixes ipv4 and ipv6 parsing even when we know which one is valid in the parsing context. This makes me sad. Even worse, we're not validating the inputs at time of

pf(4) should mention DIOCXEND

2023-07-04 Thread Alexandr Nedvedicky
Hello, diff below updates pf(4) manpage to reflect changes [1] which were committed earlier today. does update to pf(4) read OK? thanks and regards sashan [1] https://marc.info/?l=openbsd-cvs=168848058603797=2 https://marc.info/?l=openbsd-cvs=168847042626997=2

Re: cksum remove redundant code

2023-07-04 Thread Jonathan Matthew
ok jmatthew@ On Tue, Jul 04, 2023 at 12:20:32PM +0300, Alexander Bluhm wrote: > anyone? > > On Fri, May 26, 2023 at 06:44:25PM +0200, Alexander Bluhm wrote: > > Hi, > > > > in_ifcap_cksum() checks ifp == NULL > > in_hdr_cksum_out() sets ip_sum = 0 > > in_proto_cksum_out() and

Re: sec(4): route based ipsec vpns

2023-07-04 Thread Vitaliy Makkoveev
On Tue, Jul 04, 2023 at 03:26:30PM +1000, David Gwynne wrote: > tl;dr: this adds sec(4) p2p ip interfaces. Traffic in and out of these > interfaces is protected by IPsec security associations (SAs), but > there's no flows (security policy database (SPD) entries) associated > with these SAs. The

Re: cksum remove redundant code

2023-07-04 Thread Alexander Bluhm
anyone? On Fri, May 26, 2023 at 06:44:25PM +0200, Alexander Bluhm wrote: > Hi, > > in_ifcap_cksum() checks ifp == NULL > in_hdr_cksum_out() sets ip_sum = 0 > in_proto_cksum_out() and in6_proto_cksum_out() always write > th_sum if M_TCP_CSUM_OUT is set and proto is IPPROTO_TCP. > > ok? > >

tcp timer wrap around, use 64 bit

2023-07-04 Thread Alexander Bluhm
Hi, After changing tcp now tick to milliseconds, it will wrap around after 49 days of uptime. That may be a problem in some places of our stack. Better use a 64 bit counter. As timestamp option is 32 bit in TCP protocol, we have to use the lower 32 bit there. There are casts to 32 bits that

Re: pf.os database /p0f

2023-07-04 Thread Stuart Henderson
On 2023/07/04 09:48, Solène Rapenne wrote: > On Tue, 2023-07-04 at 03:39 +, Lee, Jonathan D wrote: > > [cid:cd2efd41-42cb-4d83-9173-521bbb8f4539@namprd04.prod.outlook.com] > > > > Hello fellow software developers, > > > > I have noticed that p0f database files are not being updated. Many > >

Re: Add ethernet type check in ifsetlro()

2023-07-04 Thread Alexander Bluhm
On Mon, Jul 03, 2023 at 11:12:17PM +0200, Jan Klemkow wrote: > bluhm pointed out that the ether_brport_isset() check it just allowed on > ethernet devices. Thus, I put an additional ethernet check in the > condition. This also fixes EBUSY errors of "ifconfig lo0 tcplro" calls > in my setup. > >

Re: pf.os database /p0f

2023-07-04 Thread Solène Rapenne
On Tue, 2023-07-04 at 03:39 +, Lee, Jonathan D wrote: > [cid:cd2efd41-42cb-4d83-9173-521bbb8f4539@namprd04.prod.outlook.com] > > Hello fellow software developers, > > I have noticed that p0f database files are not being updated. Many > new operating systems fingerprints are missing within