Re: m2: add suspend keyboard shortcut

2023-07-08 Thread Tobias Heider
On Sat, Jul 08, 2023 at 07:33:01PM +0200, Tobias Heider wrote: > On Sat, Jul 08, 2023 at 04:06:33PM +, Miod Vallat wrote: > > > Now that we have request_sleep() we can add a new internal KS_Cmd_Sleep > > > keycode, map it into the macbook keyboard, catch in wskbd and go to sleep. > > > > > >

Re: OpenBSD::MkTemp vs Devel::Cover

2023-07-08 Thread Andrew Hewus Fresh
On Sat, Jul 08, 2023 at 11:18:00AM +0200, Marc Espie wrote: > Hey, Philip, you wrote this a long time ago. > > Now, I'm trying to get some coverage out of Devel::Cover on pkg_add, > and somehow, it gets in the way. > > # perl -MDevel::Cover=+select,OpenBSD/.* /usr/sbin/pkg_add random_run >

make mstat smaller

2023-07-08 Thread YASUOKA Masahiko
Hi, The diff makes the mbstat be the same size which is actually used. Also revert the previous that the mbstat is located on the stack. ok? Index: sys/kern/kern_sysctl.c === RCS file: /cvs/src/sys/kern/kern_sysctl.c,v retrieving

Re: sec(4): route based ipsec vpns

2023-07-08 Thread GODA Kazuya
Hi, I tested it between OpenBSD and a router that is based on NetBSD. It seems to work well (I only tested using static routing). I found a minor issue that outgoing traffic doesn't appear in tcpdump. It's because it's missing bpf_mtap so this patch can fix it. diff --git a/sys/net/if_sec.c

Re: Diff for evaluation (WACOM tablet driver)

2023-07-08 Thread Vladimir Meshcheriakov
Please allow me to explain why I have written a custom parser pour the Wacom devices, instead of just using the already existent one. The function of interest to us is hidms_setup, it is here that I have a special condition with as has been mentioned uses a quirk. We need it because of the

Re: m2: add suspend keyboard shortcut

2023-07-08 Thread Tobias Heider
On Sat, Jul 08, 2023 at 04:06:33PM +, Miod Vallat wrote: > > Now that we have request_sleep() we can add a new internal KS_Cmd_Sleep > > keycode, map it into the macbook keyboard, catch in wskbd and go to sleep. > > > > ok? > > > --- sys/dev/usb/ukbdmap.c > > +++ sys/dev/usb/ukbdmap.c > > @@

Re: m2: add suspend keyboard shortcut

2023-07-08 Thread Miod Vallat
> Now that we have request_sleep() we can add a new internal KS_Cmd_Sleep > keycode, map it into the macbook keyboard, catch in wskbd and go to sleep. > > ok? > --- sys/dev/usb/ukbdmap.c > +++ sys/dev/usb/ukbdmap.c > @@ -176,6 +176,7 @@ static const keysym_t ukbd_keydesc_us[] = { > KC(127),

Re: m2: add suspend keyboard shortcut

2023-07-08 Thread Theo de Raadt
Tobias Heider wrote: > +#ifdef SUSPEND > + if (ksym == KS_Cmd_Sleep) > + return request_sleep(SLEEP_SUSPEND); > +#endif Oh wait, it is consumed. Is that a problem

Re: m2: add suspend keyboard shortcut

2023-07-08 Thread Theo de Raadt
Tobias Heider wrote: > +#ifdef SUSPEND > + if (ksym == KS_Cmd_Sleep) > + return request_sleep(SLEEP_SUSPEND); > +#endif This key is not absorbed when it performs this action. Is that OK?

Re: m2: add suspend keyboard shortcut

2023-07-08 Thread Mark Kettenis
> Date: Sat, 8 Jul 2023 16:54:25 +0200 > From: Tobias Heider > > Now that we have request_sleep() we can add a new internal KS_Cmd_Sleep > keycode, map it into the macbook keyboard, catch in wskbd and go to sleep. > > ok? Looks good to me, but I'd like to hear what miod@ has to say about this.

m2: add suspend keyboard shortcut

2023-07-08 Thread Tobias Heider
Now that we have request_sleep() we can add a new internal KS_Cmd_Sleep keycode, map it into the macbook keyboard, catch in wskbd and go to sleep. ok? diff 4cfcaa1dc85fba5c0672ef2787341ee6cc639979 16365606ee1145b5ae95e7bb74a7d9a411d0004a commit - 4cfcaa1dc85fba5c0672ef2787341ee6cc639979 commit

tcp lro by default, call for testing

2023-07-08 Thread Alexander Bluhm
Hi, I am not aware of any more limitations when enabling LRO for TCP in the network drivers. The feature allows to receive agregated packets larger than the MTU. Receiving TCP streams becomes much faster. As the network hardware is not aware whether a packet is received locally or forwarded,

Re: [PATCH V3] Driver for Elantech I2C touchpad

2023-07-08 Thread Vladimir 'phcoder' Serbinenko
> > > +.Sh AUTHORS > > +The > > +.Nm > > +driver was written by > > +.An vladimir serbineko Aq Mt phco...@gmail.com . > > This should be serbinenko not serbineko? > Yes. Serbinenko is the correct spelling. Sorry for typo.

Re: request_sleep: new machine independent sleep api

2023-07-08 Thread Peter Hessler
On 2023 Jul 08 (Sat) at 13:09:00 +0300 (+0300), Tobias Heider wrote: : : :On July 8, 2023 11:36:21 AM GMT+03:00, Mark Kettenis wrote: :>> Date: Sat, 8 Jul 2023 10:10:51 +0200 :>> From: Tobias Heider :>> :>> This diff adds request_sleep(), a MI way of sending the machine to sleep in a :>> safe

Re: request_sleep: new machine independent sleep api

2023-07-08 Thread Tobias Heider
On July 8, 2023 11:36:21 AM GMT+03:00, Mark Kettenis wrote: >> Date: Sat, 8 Jul 2023 10:10:51 +0200 >> From: Tobias Heider >> >> This diff adds request_sleep(), a MI way of sending the machine to sleep in a >> safe thread. Support is limited to amd64, i386 and arm64 at the moment, >>

Re: Icky test patches for Devel::Cover and pkg_add

2023-07-08 Thread Marc Espie
Somehow, it's worse than I thought. Turns out something in Devel::Cover is interfering with normal behavior. I get very low coverage numbers, because basically pkg_add can't even get to the end of installing a package. I'm wondering if anyone actually manages to use Devel::Cover for non trivial

Icky test patches for Devel::Cover and pkg_add

2023-07-08 Thread Marc Espie
Contrary to the NYT profiler, which works like a charm Devel::Cover is a tricky beast. Right now, I've isolated two issues: - OpenBSD::MkTemp (subject to a separate mail) - identity changes on the fly. Even with looseperms, Devel::Cover doesn't cope too well with multiple processes and multiple

OpenBSD::MkTemp vs Devel::Cover

2023-07-08 Thread Marc Espie
Hey, Philip, you wrote this a long time ago. Now, I'm trying to get some coverage out of Devel::Cover on pkg_add, and somehow, it gets in the way. # perl -MDevel::Cover=+select,OpenBSD/.* /usr/sbin/pkg_add random_run Selecting packages matching: OpenBSD/.* Ignoring packages matching:

Re: request_sleep: new machine independent sleep api

2023-07-08 Thread Mark Kettenis
> Date: Sat, 8 Jul 2023 10:10:51 +0200 > From: Tobias Heider > > This diff adds request_sleep(), a MI way of sending the machine to sleep in a > safe thread. Support is limited to amd64, i386 and arm64 at the moment, macppc > is currently an empty stub since it doesn't implement a sleep task

request_sleep: new machine independent sleep api

2023-07-08 Thread Tobias Heider
This diff adds request_sleep(), a MI way of sending the machine to sleep in a safe thread. Support is limited to amd64, i386 and arm64 at the moment, macppc is currently an empty stub since it doesn't implement a sleep task (yet). Once this works, my next plan is adding a Ks_Cmd_Sleep keybinding

Re: acpi: move acpiioctl to x86

2023-07-08 Thread Mark Kettenis
> Date: Fri, 7 Jul 2023 11:56:42 +0200 > From: Tobias Heider > > On Wed, Jul 05, 2023 at 04:53:33PM +0200, Tobias Heider wrote: > > I am planning to restructure the APM/sleep APIs to make it easier to suspend > > from more places like as a suspend keyboard shortcut. > > > > The acpiioctl

Re: ix(4) shouldn't crash on memory allocation failure

2023-07-08 Thread Hrvoje Popovski
On 7.7.2023. 11:24, Jonathan Matthew wrote: > One of the problems described here: > https://www.mail-archive.com/tech@openbsd.org/msg71790.html > amounts to ix(4) not checking that it allocated a dma map before trying to > free it. > > ok? > > Hi, with this diff box won't panic if I have em

Re: acpi: move acpiioctl to x86

2023-07-08 Thread YASUOKA Masahiko
On Fri, 7 Jul 2023 11:56:42 +0200 Tobias Heider wrote: > On Wed, Jul 05, 2023 at 04:53:33PM +0200, Tobias Heider wrote: >> I am planning to restructure the APM/sleep APIs to make it easier to suspend >> from more places like as a suspend keyboard shortcut. >> >> The acpiioctl handler is x86