Re: dlfcn(3) spacing tweak

2022-12-04 Thread Brad Smith
On Mon, Dec 05, 2022 at 06:42:00AM +, Jason McIntyre wrote: > On Sun, Dec 04, 2022 at 08:29:26PM -0500, Brad Smith wrote: > > After the RTLD_NOLOAD addition to the page the spacing looks kind of > > odd. Make the spacing look like RTLD_NOW / RTLD_LAZY above that. > > &g

dlfcn(3) spacing tweak

2022-12-04 Thread Brad Smith
After the RTLD_NOLOAD addition to the page the spacing looks kind of odd. Make the spacing look like RTLD_NOW / RTLD_LAZY above that. Index: dlfcn.3 === RCS file: /home/cvs/src/share/man/man3/dlfcn.3,v retrieving revision 1.32 diff

Re: Fix C++ namespace polution in stdio.h header

2022-12-04 Thread Brad Smith
ping. On 10/15/2021 7:41 PM, Brad Smith wrote: The following diff fixes namespace polution with C++ in the stdio.h header. I was looking into a build issue when trying to build another program dependent on a new port I posted (spdlog). Peeking at one of it's headers I noticed a workaround

[llvm-objdump] Left justify display of OpenBSD headers

2022-11-19 Thread Brad Smith
This makes the header printing look the same as the GNU objdump. Index: llvm/tools/llvm-objdump/ELFDump.cpp === RCS file: /home/cvs/src/gnu/llvm/llvm/tools/llvm-objdump/ELFDump.cpp,v retrieving revision 1.2 diff -u -p -u -p -r1.2

Recognize PT_OPENBSD_MUTABLE with LLVM's readobj / objdump

2022-11-13 Thread Brad Smith
Recognize PT_OPENBSD_MUTABLE with LLVM's readobj / objdump. Index: llvm/llvm/tools/llvm-objdump/ELFDump.cpp === RCS file: /home/cvs/src/gnu/llvm/llvm/tools/llvm-objdump/ELFDump.cpp,v retrieving revision 1.1.1.3 diff -u -p -u -p

Fix C++ namespace polution in stdio.h header

2021-10-15 Thread Brad Smith
The following diff fixes namespace polution with C++ in the stdio.h header. I was looking into a build issue when trying to build another program dependent on a new port I posted (spdlog). Peeking at one of it's headers I noticed a workaround for OpenBSD that doesn't work anyway. Fixing the

Re: uaq(4): aquantia usb ethernet driver

2021-09-01 Thread Brad Smith
On 8/31/2021 8:46 PM, Jonathan Matthew wrote: Here's a driver for the Aquantia USB ethernet devices I just added to usbdevs. These are somewhat interesting because they theoretically go up to 5GbE and support jumbo frames (not implemented yet). While working on this I noticed that it doesn't

Re: macppc: add ld.script for kernel, ofwboot

2021-06-05 Thread Brad Smith
On Mon, May 10, 2021 at 09:49:24PM +0200, Mark Kettenis wrote: > > Date: Mon, 10 May 2021 14:22:33 -0400 > > From: George Koehler > > > > On Fri, 7 May 2021 10:31:55 +0200 (CEST) > > Mark Kettenis wrote: > > > > > Makes sense to me. It seems ldd always seems to require a little bit > > > more

Re: Thread Local Storage in clang

2021-05-28 Thread Brad Smith
On 5/28/2021 10:55 AM, Chris Cappuccio wrote: I tried to compile librdkafka on OpenBSD 6.5 (clang 7.0.1) and clang compiled the __thread parts with some built-in mechanism. I upgraded the system to OpenBSD 6.9 and TLS is no longer supported by the in-tree clang. Was this intended to be turned

Re: patch: add support for RTLD_NODELETE

2021-05-10 Thread Brad Smith
To: Brad Smith Subject: Re: dlopen & RTLD_NOLOAD / RTLD_NODELETE User-Agent: Alpine 2.21 (BSO 202 2017-01-01) On Sat, 19 Sep 2020, Brad Smith wrote: > On 8/31/2020 12:24 AM, Philip Guenther wrote: > > On Sun, 30 Aug 2020, Brad Smith wrote: > > > Is there any chance that Op

Recognize bge(4) BCM57766 revs

2021-04-01 Thread Brad Smith
Recognize bge(4) BCM5776 revs of chips.. unknown BCM57766 (0x57766000) unknown BCM57766 (0x57766001) Index: if_bge.c === RCS file: /home/cvs/src/sys/dev/pci/if_bge.c,v retrieving revision 1.393 diff -u -p -u -p -r1.393 if_bge.c ---

Clang floating-point alignment on powerpc

2020-08-11 Thread Brad Smith
It looks like after this went in which is included with 10 that this local diff can be removed.. https://reviews.llvm.org/D71954 [PowerPC] Change default for unaligned FP access for older subtargets This is a fix for https://bugs.llvm.org/show_bug.cgi?id=40554 Some CPU's trap to the kernel on

netstart diff for aggr(4) handling

2019-10-17 Thread Brad Smith
Shouldn't aggr(4) be handled in the same manner as trunk(4)? Index: netstart === RCS file: /home/cvs/src/etc/netstart,v retrieving revision 1.200 diff -u -p -u -p -r1.200 netstart --- netstart29 Aug 2018 11:30:48 -

66.html diff - Use MACHINE_ARCH consistently

2019-10-17 Thread Brad Smith
Fix the release notes to use MACHINE_ARCH consistently instead of some random MACHINE mixed in. Index: 66.html === RCS file: /home/cvs/www/66.html,v retrieving revision 1.49 diff -u -p -u -p -r1.49 66.html --- 66.html 6 Oct

alc(4): formatting fixes

2019-05-20 Thread Brad Smith
Various formatting fixes for alc(4). Index: if_alc.c === RCS file: /home/cvs/src/sys/dev/pci/if_alc.c,v retrieving revision 1.48 diff -u -p -u -p -r1.48 if_alc.c --- if_alc.c6 May 2019 07:44:00 - 1.48 +++ if_alc.c

jme(4): jme_start() use JME_MAXTXSEGS when checking available TX descs

2019-04-14 Thread Brad Smith
jme_start() should be checking if JME_MAXTXSEGS TX descs are available instead of just the 1 reserved descriptor (JME_TXD_RSVD). Index: if_jme.c === RCS file: /home/cvs/src/sys/dev/pci/if_jme.c,v retrieving revision 1.51 diff -u -p

Re: ftp(1) rewrite

2015-06-01 Thread Brad Smith
On 06/01/15 18:29, Stuart Henderson wrote: On 2015/06/02 00:09, Dmitrij D. Czarkoff wrote: Ted Unangst said: Stuart Henderson wrote: Sorry, it's not good enough to replace ftp(1) for system use without ftp. Like it or not, ports fetches need FTP and can't really rely on installing something

Re: iwm(4): fix multicast receive

2015-02-19 Thread Brad Smith
On 02/19/15 12:01, Stefan Sperling wrote: This fixes IPv6 autoconf over iwm for me. iwm users please test. Does the trick for me. -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.

Re: LibreSSL Windows port status update

2014-11-30 Thread Brad Smith
On 12/01/14 01:10, Dongsheng Song wrote: Cool ! I can see you do lot's of update on select-poll conversions. The code become more and more complex since you want it works more general. Can we use simply WSAPoll[1] instead ? -- #ifdef _WIN32 #define poll WSAPoll #endif -- [1]

Unbound 1.5.0

2014-11-18 Thread Brad Smith
So Unbound 1.5.0 has been released.. http://comstyle.com/unbound/unbound.tar.gz Just looking for some testing of what I have preped for import. I have provided a tarball instead of a diff because of some dir additions. Any other testers? -- This message has been scanned for viruses and

Re: Missing include in sys/ipc.h

2014-11-13 Thread Brad Smith
On 09/20/14 15:34, Philip Guenther wrote: On Sat, Sep 20, 2014 at 11:28 AM, Mark Kettenis mark.kette...@xs4all.nl wrote: Date: Sat, 20 Sep 2014 18:15:31 + From: Miod Vallat m...@online.fr shmctl(2)/shmget(2)/shmat(2) all document #include sys/types.h #include sys/ipc.h #include sys/shm.h

Re: em(4) fix for Intel I218 chip

2014-10-13 Thread Brad Smith
On 12/10/14 3:53 PM, Claudio Jeker wrote: This seems to be enough to help em(4) in modern laptops like the X240 to no longer generate watchdog timeouts on high throughput. This should only affect I218 but tests on different em(4) devices would not hurt. Chunk #3 is within the ICH8/IGP3

Re: em(4) fix for Intel I218 chip

2014-10-13 Thread Brad Smith
On 13/10/14 5:09 PM, Claudio Jeker wrote: On Mon, Oct 13, 2014 at 01:50:45PM -0400, Brad wrote: On 12/10/14 3:53 PM, Claudio Jeker wrote: This seems to be enough to help em(4) in modern laptops like the X240 to no longer generate watchdog timeouts on high throughput. This should only affect

Re: pppoe(4), add example for ipv6

2014-10-07 Thread Brad Smith
On 07/10/14 10:03 PM, Stuart Henderson wrote: Since it's non-obvious how to setup pppoe for v6 now that link-local addresses are no longer configured by default, I think we should have something in the manual. Any comments/objections/suggestions for a better way to do this? This doesn't make

Re: call for testing: MSI for msk(4)

2014-09-23 Thread Brad Smith
On 31/12/13 12:06 AM, Brad Smith wrote: On 16/05/13 5:55 PM, Jérémie Courrèges-Anglas wrote: Hi, I've been using msk(4) with MSI on my laptop since a few days, with no apparent problem. mskc0 at pci2 dev 0 function 0 Marvell Yukon 88E8040 rev 0x13, Yukon-2 FE+ rev. A0 (0x0): msi msk0 at mskc0

re(4): Don't allow reception of jumbo frames with chips that cannot support it

2014-09-13 Thread Brad Smith
At the moment our re(4) driver will allow the reception of Jumbo frames with chips that don't have support in the driver. Although I haven't been able to reproduce this in theory it could be possible to cause the kernel to crash with such hardware under the right conditions. OK? Index: re.c

dc(4): Remove redundant dc_stop / dc_reset calls

2014-09-09 Thread Brad Smith
Remove redundant dc_stop() / dc_reset() calls from dc_intr() and dc_watchdog() which dc_init() already takes care of. OK? Index: ic/dc.c === RCS file: /home/cvs/src/sys/dev/ic/dc.c,v retrieving revision 1.134 diff -u -p -u -p

Re: sparc64: fledgling QEMU support

2014-09-09 Thread Brad Smith
On 09/09/14 2:20 PM, Mark Cave-Ayland wrote: Hi all, Following up from my posts at the beginning of the summer, I'm pleased to announce that as of today, qemu-system-sparc64 built from QEMU git master will successfully install OpenBSD from an .iso and boot back into it in serial mode with its

Re: re(4) feature flags additions and changes

2014-09-05 Thread Brad Smith
On 05/09/14 2:24 AM, Jonathan Gray wrote: On Tue, Sep 02, 2014 at 07:20:30AM -0400, Brad Smith wrote: On Tue, Sep 02, 2014 at 06:28:48AM -0400, Brad Smith wrote: Add some feature flags and store in the softc the various max Jumbo frame sizes for the different generations of chips

Re: re(4) feature flags additions and changes

2014-09-05 Thread Brad Smith
On Tue, Sep 02, 2014 at 07:20:30AM -0400, Brad Smith wrote: On Tue, Sep 02, 2014 at 06:28:48AM -0400, Brad Smith wrote: Add some feature flags and store in the softc the various max Jumbo frame sizes for the different generations of chips. No behavioral change. Tested with.. re0

re(4) feature flags additions and changes

2014-09-02 Thread Brad Smith
Add some feature flags and store in the softc the various max Jumbo frame sizes for the different generations of chips. No behavioral change. Tested with.. re0 at pci2 dev 0 function 0 Realtek 8168 rev 0x03: RTL8168D/8111D (0x2800) re0 at pci2 dev 0 function 0 Realtek 8168 rev 0x0c:

Re: re(4) feature flags additions and changes

2014-09-02 Thread Brad Smith
On Tue, Sep 02, 2014 at 06:28:48AM -0400, Brad Smith wrote: Add some feature flags and store in the softc the various max Jumbo frame sizes for the different generations of chips. No behavioral change. Tested with.. re0 at pci2 dev 0 function 0 Realtek 8168 rev 0x03: RTL8168D/8111D

Re: re(4) feature flags additions and changes

2014-09-02 Thread Brad Smith
On Tue, Sep 02, 2014 at 09:03:34PM +1000, Jonathan Gray wrote: On Tue, Sep 02, 2014 at 06:28:48AM -0400, Brad Smith wrote: Add some feature flags and store in the softc the various max Jumbo frame sizes for the different generations of chips. No behavioral change. Tested

Re: bge(4) Jumbo support for newer chipsets

2014-09-01 Thread Brad Smith
On Wed, Aug 27, 2014 at 02:25:27AM -0400, Brad Smith wrote: Looking for some testing of the following diff to add Jumbo support for the BCM5714 / BCM5780 and BCM5717 / BCM5719 / BCM5720 / BCM57765 / BCM57766 chipsets. Here is an updated diff with bge_rxrinfo() being fixed. Index: if_bge.c

bge(4) Jumbo support for newer chipsets

2014-08-27 Thread Brad Smith
Looking for some testing of the following diff to add Jumbo support for the BCM5714 / BCM5780 and BCM5717 / BCM5719 / BCM5720 / BCM57765 / BCM57766 chipsets. Index: if_bge.c === RCS file: /home/cvs/src/sys/dev/pci/if_bge.c,v

Re: let vlan(4) mtu be limited by the parents hardmtu instead of current mtu

2014-08-26 Thread Brad Smith
On 20/08/14 8:03 PM, David Gwynne wrote: sthen@ says this is likely a bit optimistic. while most of our drivers unconditionally configure their max mru, there's some stupid ones that still interpret the configured mtu as a what the mru should be. dlg oce(4) and ix(4) need to be fixed. --

Re: sk(4): jumbo mbufs and rxring accounting

2014-08-19 Thread Brad Smith
On 18/08/14 6:24 PM, David Gwynne wrote: On Sun, Jul 13, 2014 at 02:01:15PM +1000, David Gwynne wrote: i think i'll try to find the sk at work and wire it up. its just annoying cos im pretty sure its sr optics with sc connectors. thanks for testing. how's this one? Only running regular

Re: sk(4): jumbo mbufs and rxring accounting

2014-08-19 Thread Brad Smith
On 19/08/14 2:43 PM, Stuart Henderson wrote: From what I remember from last attempt to convert sk(4) to MCLGETI, there were problems which only showed up under load (possibly also involved NFS, I don't remember for sure) - I probably used netrate with something like netblast 11.22.33.44 12345 1

Re: sk(4): jumbo mbufs and rxring accounting

2014-08-19 Thread Brad Smith
On 19/08/14 2:19 PM, Brad Smith wrote: On 18/08/14 6:24 PM, David Gwynne wrote: On Sun, Jul 13, 2014 at 02:01:15PM +1000, David Gwynne wrote: i think i'll try to find the sk at work and wire it up. its just annoying cos im pretty sure its sr optics with sc connectors. thanks for testing

Re: sk(4): jumbo mbufs and rxring accounting

2014-08-18 Thread Brad Smith
On 18/08/14 6:24 PM, David Gwynne wrote: On Sun, Jul 13, 2014 at 02:01:15PM +1000, David Gwynne wrote: i think i'll try to find the sk at work and wire it up. its just annoying cos im pretty sure its sr optics with sc connectors. thanks for testing. how's this one? I'll look into testing

Re: jumbo support for bnx(4)

2014-08-14 Thread Brad Smith
On 13/08/14 6:42 AM, David Gwynne wrote: ive had this for 2 years or so. updated to current again. its been tested on the following: bnx0 at pci4 dev 0 function 0 Broadcom BCM5708 rev 0x12: apic 8 int 16 bnx1 at pci13 dev 0 function 0 Broadcom BCM5708 rev 0x12: apic 8 int 16 bnx0: address

Re: jumbo support for bnx(4)

2014-08-14 Thread Brad Smith
On 14/08/14 5:09 PM, Brad Smith wrote: On 13/08/14 6:42 AM, David Gwynne wrote: ive had this for 2 years or so. updated to current again. its been tested on the following: bnx0 at pci4 dev 0 function 0 Broadcom BCM5708 rev 0x12: apic 8 int 16 bnx1 at pci13 dev 0 function 0 Broadcom BCM5708

Re: network autoconfig

2014-07-13 Thread Brad Smith
On 13/07/14 2:16 PM, frantisek holop wrote: hmm, on Sun, Jul 13, 2014 at 05:37:51PM +0200, Denis Fondras said that from the user's PoV, there shouldn't be more needed than ifconfig if inet autoconf ifconfig if inet6 autoconf aka inet/inet6 autoconf in hostname.if. I'm curious to see

Re: network autoconfig

2014-07-13 Thread Brad Smith
On 13/07/14 4:22 PM, frantisek holop wrote: hmm, on Sun, Jul 13, 2014 at 02:21:06PM -0400, Brad Smith said that On 13/07/14 2:16 PM, frantisek holop wrote: hmm, on Sun, Jul 13, 2014 at 05:37:51PM +0200, Denis Fondras said that from the user's PoV, there shouldn't be more needed than

Re: sk(4): jumbo mbufs and rxring accounting

2014-07-12 Thread Brad Smith
On 12/07/14 4:32 AM, David Gwynne wrote: how about this? Now it attaches without error but tcpdump shows no traffic coming in at all and there is regular traffic on the segment from spanning tree, CARP, RA, etc. $ vmstat -iz interrupt total rate schizo0:pci_a

Re: sk(4): jumbo mbufs and rxring accounting

2014-07-10 Thread Brad Smith
On 10/07/14 1:33 AM, David Gwynne wrote: this is an update of if_sk.c r1.151, which tried to introduce mclgeti. it updates it to use the if_rxring accounting. does anyone have one they can test this on? it also saves about 2k on amd64. Doesn't work at all. skc0 at pci0 dev 5 function 0

Re: AI_ADDRCONFIG

2014-04-23 Thread Brad Smith
On Wed, Apr 23, 2014 at 08:09:06AM -0400, Simon Perreault wrote: (I sent this diff to ??ric Faurot on the 12th, but received no reply.) Tech, While everyone's having fun removing code from OpenSSL, I decided to add some to libasr. I implemented AI_ADDRCONFIG, a getaddrinfo() flag defined

Re: em(4): Don't count RX overruns and missed packets as input errros

2014-02-11 Thread Brad Smith
On Fri, Feb 07, 2014 at 06:15:44AM -0500, Brad Smith wrote: On Tue, Jan 28, 2014 at 02:08:09AM -0500, Brad Smith wrote: On Tue, Jan 28, 2014 at 01:21:46PM +1000, David Gwynne wrote: On 26 Jan 2014, at 11:31 am, Brad Smith b...@comstyle.com wrote: On 31/12/13 5:50 AM, Mike

Re: em(4): Don't count RX overruns and missed packets as input errros

2014-02-11 Thread Brad Smith
On Tue, Feb 11, 2014 at 07:43:51PM +0100, Mark Kettenis wrote: Date: Tue, 11 Feb 2014 13:30:47 -0500 From: Brad Smith b...@comstyle.com Index: arch/socppc/dev/if_tsec.c === RCS file: /home/cvs/src/sys/arch/socppc/dev

Re: em(4): Don't count RX overruns and missed packets as input errros

2014-02-07 Thread Brad Smith
On Tue, Jan 28, 2014 at 02:08:09AM -0500, Brad Smith wrote: On Tue, Jan 28, 2014 at 01:21:46PM +1000, David Gwynne wrote: On 26 Jan 2014, at 11:31 am, Brad Smith b...@comstyle.com wrote: On 31/12/13 5:50 AM, Mike Belopuhov wrote: On 31 December 2013 09:46, Brad Smith b

Re: problem with gethostbyaddr() on OBSD 5.4?

2014-01-31 Thread Brad Smith
On 31/01/14 7:17 PM, IMAP List Administration wrote: Hello Folks, I run a Postfix MTA on OpenBSD. Recently I migrated the server from OBSD v5.3 to v5.4. Soon afterwards I noticed postfix was falsely rejecting mails based on a FCrDNS (forward-confirmed reverse DNS) test. FCrDNS means the DNS

Re: bge(4): IPv6 checksum offload

2014-01-27 Thread Brad Smith
On 27/01/14 3:30 PM, Christian Weisgerber wrote: Some bge(4) chips support IPv6 TCP checksum transmit offload. Unfortunately, I have no idea which. My best guess is that this is symmetrical with the receive offload capability: if (BGE_IS_5755_PLUS(sc)) mode |=

Re: em(4): Don't count RX overruns and missed packets as input errros

2014-01-27 Thread Brad Smith
On Tue, Jan 28, 2014 at 01:21:46PM +1000, David Gwynne wrote: On 26 Jan 2014, at 11:31 am, Brad Smith b...@comstyle.com wrote: On 31/12/13 5:50 AM, Mike Belopuhov wrote: On 31 December 2013 09:46, Brad Smith b...@comstyle.com wrote: On 31/12/13 3:14 AM, Mark Kettenis wrote: Date

Re: em(4): Don't count RX overruns and missed packets as input errros

2014-01-25 Thread Brad Smith
On 31/12/13 5:50 AM, Mike Belopuhov wrote: On 31 December 2013 09:46, Brad Smith b...@comstyle.com wrote: On 31/12/13 3:14 AM, Mark Kettenis wrote: Date: Tue, 31 Dec 2013 01:28:04 -0500 From: Brad Smith b...@comstyle.com Don't count RX overruns and missed packets as inputs errors. They're

Re: rc default PF ruleset too restrictive for DHCPv6

2014-01-19 Thread Brad Smith
On Sun, Jan 19, 2014 at 04:10:21AM +0100, Claudio Jeker wrote: On Sat, Jan 18, 2014 at 09:57:26PM -0500, Brad wrote: On Thu, Jan 09, 2014 at 03:55:44PM -0500, Brad Smith wrote: The default PF ruleset as setup by rc is too restrictive. Have the default ruleset allow for DHCPv6. Anyone

Re: rc default PF ruleset too restrictive for DHCPv6

2014-01-18 Thread Brad Smith
On Thu, Jan 09, 2014 at 03:55:44PM -0500, Brad Smith wrote: The default PF ruleset as setup by rc is too restrictive. Have the default ruleset allow for DHCPv6. Anyone? Index: rc === RCS file: /home/cvs/src/etc/rc,v retrieving

Re: rc default PF ruleset too restrictive for DHCPv6

2014-01-18 Thread Brad Smith
On Sun, Jan 19, 2014 at 04:10:21AM +0100, Claudio Jeker wrote: On Sat, Jan 18, 2014 at 09:57:26PM -0500, Brad wrote: On Thu, Jan 09, 2014 at 03:55:44PM -0500, Brad Smith wrote: The default PF ruleset as setup by rc is too restrictive. Have the default ruleset allow for DHCPv6. Anyone

Re: top(1) interactive commands after SIGWINCH

2014-01-13 Thread Brad Smith
On 13/01/14 12:04 PM, Stuart Henderson wrote: If anyone is interested in looking at a signal problem in top, here's a small but annoying bug.. - run top in an xterm - resize the window - try to use an interactive command that takes an argument, e.g. s or g (doesn't happen with commands like S

Re: Patch: pcidevs for new intel host bridge and radeon gpu

2014-01-10 Thread Brad Smith
On 10/01/14 4:05 PM, mark rowland wrote: The entry for intel product 0x0a04 was not in the right spot, new diff: --- /usr/src/sys/dev/pci/pcidevsWed Jan 8 23:52:05 2014 +++ pcidevs Fri Jan 10 21:54:24 2014 @@ -1293,7 +1293,7 @@ product ATI RADEON_X700_PCIE_S0x5e6d Radeon

Re: em(4): Don't count RX overruns and missed packets as input errros

2013-12-31 Thread Brad Smith
On 31/12/13 3:14 AM, Mark Kettenis wrote: Date: Tue, 31 Dec 2013 01:28:04 -0500 From: Brad Smith b...@comstyle.com Don't count RX overruns and missed packets as inputs errors. They're expected to increment when using MCLGETI. OK? These may be expected, but they're still packets that were

Re: re(4): tedu some unused code

2013-12-31 Thread Brad Smith
On Tue, Dec 31, 2013 at 09:55:54AM -0800, Chris Cappuccio wrote: Brad Smith [b...@comstyle.com] wrote: tedu some unused code. it has never been enabled and will not be; to deal with a hardware defect for rare boards. unmaintained, untested, etc. want to get rid of it. Comments? OK

Re: em(4): Don't count RX overruns and missed packets as input errros

2013-12-31 Thread Brad Smith
On 31/12/13 5:50 AM, Mike Belopuhov wrote: On 31 December 2013 09:46, Brad Smith b...@comstyle.com wrote: On 31/12/13 3:14 AM, Mark Kettenis wrote: Date: Tue, 31 Dec 2013 01:28:04 -0500 From: Brad Smith b...@comstyle.com Don't count RX overruns and missed packets as inputs errors. They're

Re: call for testing: MSI for msk(4)

2013-12-30 Thread Brad Smith
On 16/05/13 5:55 PM, Jérémie Courrèges-Anglas wrote: Hi, I've been using msk(4) with MSI on my laptop since a few days, with no apparent problem. mskc0 at pci2 dev 0 function 0 Marvell Yukon 88E8040 rev 0x13, Yukon-2 FE+ rev. A0 (0x0): msi msk0 at mskc0 port A: address 00:24:54:xx:xx:xx

re(4): tedu some unused code

2013-12-30 Thread Brad Smith
tedu some unused code. it has never been enabled and will not be; to deal with a hardware defect for rare boards. unmaintained, untested, etc. want to get rid of it. Comments? OK? Index: re.c === RCS file:

em(4): Don't count RX overruns and missed packets as input errros

2013-12-30 Thread Brad Smith
Don't count RX overruns and missed packets as inputs errors. They're expected to increment when using MCLGETI. OK? Index: if_em.c === RCS file: /cvs/src/sys/dev/pci/if_em.c,v retrieving revision 1.275 diff -u -p -u -p -r1.275

rgephy(4): Always use RL_GMEDIASTAT for reading link/media status for re(4) PHY

2013-12-28 Thread Brad Smith
This moves rgephy(4) back to using RL_GMEDIASTAT to read the link/media status for re(4) attached Realtek PHY as was done before rev 1.25. rev 1.25 was to add support for external rgephy(4) attached to other MAC such as nfe(4), but the PHY Specific Status register doesn't seem to work properly

Re: LLVM warning in sys/uvm/uvm_map.c

2013-12-06 Thread Brad Smith
On Tue, Dec 03, 2013 at 06:48:11PM -0500, Brad Smith wrote: An unused function in the UVM code. #if 0 it out for now. uvm_map.c:171:14: error: unused function 'uvm_mapentry_freecmp' [-Werror,-Wunused-function] uvm_map.c:353:1: error: unused function 'uvm_mapentry_freecmp' [-Werror

Re: LLVM warning in sys/compat/linux/linux_misc.c

2013-12-06 Thread Brad Smith
On 28/11/13 10:05 PM, Brad Smith wrote: Remove unsigned comparison 0. ../../../../compat/linux/linux_misc.c:1531:24: error: comparison of unsigned expression 0 is always false [-Werror,-Wtautological-compare] Comments? OK? ping. Index: linux_misc.c

Re: cdce / cdce / urndis ioctl handling clean up

2013-12-06 Thread Brad Smith
On 02/12/13 6:28 PM, Brad Smith wrote: Some clean up to the cdce / cdcef and urndis ioctl handlers to bring things in line with the other Ethernet drivers. no functional change. OK? ping. Index: if_cdce.c === RCS file: /home

Re: LLVM warning in sys/uvm/uvm_map.c

2013-12-06 Thread Brad Smith
On 06/12/13 11:39 PM, Ted Unangst wrote: On Fri, Dec 06, 2013 at 20:47, Brad Smith wrote: On Tue, Dec 03, 2013 at 06:48:11PM -0500, Brad Smith wrote: An unused function in the UVM code. #if 0 it out for now. uvm_map.c:171:14: error: unused function 'uvm_mapentry_freecmp' [-Werror,-Wunused

Re: LLVM warning in dev/ic/uhci.c

2013-12-05 Thread Brad Smith
On Wed, Dec 04, 2013 at 05:04:13PM +0100, Mark Kettenis wrote: Date: Wed, 4 Dec 2013 12:53:20 +0100 From: Joerg Sonnenberger jo...@britannica.bec.de On Wed, Dec 04, 2013 at 12:24:50PM +0100, Mark Kettenis wrote: Sorry, but I disagree with LLVM here. It shouldn't complain about

Re: LLVM warning in dev/pci/if_wpi.c

2013-12-05 Thread Brad Smith
On Tue, Dec 03, 2013 at 08:31:13PM -0500, Brad Smith wrote: An unused function in wpi(4). #if 0 out the function for now. if_wpi.c:510:1: error: unused function 'wpi_mem_write' [-Werror,-Wunused-function] OK? Index: if_wpi.c

LLVM warning in dev/ic/aic79xx.c

2013-12-03 Thread Brad Smith
This is unused within the aic79xx code. aic79xx.c:93:20: error: unused variable 'num_chip_names' [-Werror,-Wunused-const-variable] OK? Index: aic79xx.c === RCS file: /home/cvs/src/sys/dev/ic/aic79xx.c,v retrieving revision 1.51

LLVM warning in dev/ic/atw.c

2013-12-03 Thread Brad Smith
The bit of code that calls this function is #if 0'd out so leave the function there but #if 0 it out as well. atw.c:3021:1: error: unused function 'atw_hw_decrypted' [-Werror,-Wunused-function] OK? Index: atw.c === RCS file:

LLVM warning in dev/ic/uhci.c

2013-12-03 Thread Brad Smith
Put UREAD4 under #ifdef UHCI_DEBUG as it is only used by a function for debugging which is also under UHCI_DEBUG. uhci.c:256:1: error: unused function 'UREAD4' [-Werror,-Wunused-function] OK? Index: uhci.c === RCS file:

LLVM warning in dev/ic/ohci.c

2013-12-03 Thread Brad Smith
Some unused functions in ohci(4). #if 0 them out to appease the warnings but keep the code around in case it will be used at some point in the future. ohci.c:193:1: error: unused function 'OREAD1' [-Werror,-Wunused-function] ohci.c:200:1: error: unused function 'OREAD2'

LLVM warning in amd64/amd64/amd64errata.c and i386 version too

2013-12-03 Thread Brad Smith
The relvent code using amd64_errata_set4 is #if 0'd out so do the same to the variable. amd64errata.c:103:22: error: unused variable 'amd64_errata_set4' [-Werror,-Wunused-const-variable] OK? Index: amd64/amd64/amd64errata.c ===

LLVM warning in sys/uvm/uvm_map.c

2013-12-03 Thread Brad Smith
An unused function in the UVM code. #if 0 it out for now. uvm_map.c:171:14: error: unused function 'uvm_mapentry_freecmp' [-Werror,-Wunused-function] uvm_map.c:353:1: error: unused function 'uvm_mapentry_freecmp' [-Werror,-Wunused-function] OK? Index: uvm_map.c

LLVM warning in net/net80211/ieee80211_output.c

2013-12-03 Thread Brad Smith
ieee80211_edca_table is unused within the code so just #if 0 it out for but but keeping it around for future reference in case it ever becomes useful. ieee80211_output.c:311:5: error: unused variable 'ieee80211_edca_table' [-Werror,-Wunused-const-variable] OK? Index: ieee80211_output.c

LLVM warning in dev/pci/drm/i915/i915_drv.c

2013-12-03 Thread Brad Smith
The ValleyView PCI ids are #ifdef notyet in the table which references these structs so stick these under #ifdef notyet too until the ids are enabled. i915_drv.c:288:39: error: unused variable 'intel_valleyview_m_info' [-Werror,-Wunused-const-variable] i915_drv.c:297:39: error: unused variable

LLVM warning in dev/pci/if_wpi.c

2013-12-03 Thread Brad Smith
An unused function in wpi(4). #if 0 out the function for now. if_wpi.c:510:1: error: unused function 'wpi_mem_write' [-Werror,-Wunused-function] OK? Index: if_wpi.c === RCS file: /home/cvs/src/sys/dev/pci/if_wpi.c,v retrieving

Re: txp(4) 3Com 3XP Typhoon/Sidewinder diff needs testing

2013-12-02 Thread Brad Smith
On 02/12/13 7:36 AM, Mike Belopuhov wrote: On 2 December 2013 03:07, Brad Smith b...@comstyle.com wrote: Here is a diff for the txp(4) 3Com 3XP Typhoon/Sidewinder driver to clean up and update the receive filter / ioctl handling code to be in line with the other drivers. Anyone with hw

jme(4) fixes for jme_encap(), fixes crashing under load

2013-12-01 Thread Brad Smith
Here is a diff to fix a few issues with jme_encap(). I noticed some issues with jme_encap() as it was ported from DragonFly. I had fixed similar issues with age(4) and alc(4), also originating from DragonFly. Maybe age/alc took inspiration from jme when being ported from DragonFly? - Remove the

pcn(4) receive filter / ioctl handling fixes/updating

2013-12-01 Thread Brad Smith
Here is a diff to clean up and and fix up the receive filter and ioctl handling code to be in line with the other drivers. Also fixes being not able to bring the interface out of all multicast mode once the range or promisc mode has been removed/disabled. Tested with QEMU and VMware's pcn(4)

tl(4) ThunderLAN diff needs testing

2013-12-01 Thread Brad Smith
Here is a diff for the tl(4) ThunderLAN driver to clean up and update the receive filter / ioctl handling code to be in line with the other drivers. I also want to try reinstating the hash filter and get that working properly. Anyone with hw and able to test? OK? Index: if_tl.c

sf(4) Starfire diff needs testing

2013-12-01 Thread Brad Smith
Here is a diff for the sf(4) Starfire driver to clean up and update the receive filter / ioctl handling code to be in line with the other drivers. Anyone with hw and able to test? OK? Index: aic6915.c === RCS file:

nge(4) DP83820 / DP83821 diff needs testing

2013-12-01 Thread Brad Smith
Here is a diff for the sf(4) Starfire driver to clean up and update the receive filter / ioctl handling code to be in line with the other drivers. Anyone with hw and able to test? OK? Index: if_nge.c === RCS file:

mtd(4) Myson MTD800/MTD803/MTD891 diff needs testing

2013-12-01 Thread Brad Smith
Here is a diff for the mtd(4) Myson MTD800/MTD803/MTD891 driver to clean up and update the receive filter / ioctl handling code to be in line with the other drivers. Anyone with hw and able to test? OK? Index: mtd8xx.c === RCS

Re: nge(4) DP83820 / DP83821 diff needs testing

2013-12-01 Thread Brad Smith
On 01/12/13 8:45 PM, Brad Smith wrote: Here is a diff for the sf(4) Starfire driver to clean up and update the receive filter / ioctl handling code to be in line with the other drivers. Oops. Should have said.. Here is a diff for the nge(4) DP83820 / DP83821 driver to clean up and update

bce(4) Broadcom BCM4401 diff needs testing

2013-12-01 Thread Brad Smith
Here is a diff for the bce(4) Broadcom BCM4401 driver to clean up and update the receive filter / ioctl handling code to be in line with the other drivers. Anyone with hw and able to test? OK? Index: if_bce.c === RCS file:

epic(4) SMC 83C170 diff needs testing

2013-12-01 Thread Brad Smith
Here is a diff for the epic(4) SMC 83C170 driver to clean up and update the receive filter / ioctl handling code to be in line with the other drivers. Anyone with hw and able to test? OK? Index: smc83c170.c === RCS file:

txp(4) 3Com 3XP Typhoon/Sidewinder diff needs testing

2013-12-01 Thread Brad Smith
Here is a diff for the txp(4) 3Com 3XP Typhoon/Sidewinder driver to clean up and update the receive filter / ioctl handling code to be in line with the other drivers. Anyone with hw and able to test? OK? Index: if_txp.c === RCS

cue(4) CATC USB-EL1201A diff needs testing

2013-12-01 Thread Brad Smith
Here is a diff for the cue(4) CATC USB-EL1201A driver to clean up and update the receive filter / ioctl handling code to be in line with the other drivers. Anyone with hw and able to test? OK? Index: if_cue.c === RCS file:

LLVM warning in sys/dev/isa/sb.c

2013-11-28 Thread Brad Smith
The sc_model field is currently set to an unsigned int type but the Sound Blaster code expects a signed type since it sets the model to SB_UNK which as can be seen from the diff below has a value of -1. ../../../../dev/isa/sb.c:307:8: error: comparison of 0 = unsigned expression is always true

LLVM warning in sys/compat/linux/linux_misc.c

2013-11-28 Thread Brad Smith
Remove unsigned comparison 0. ../../../../compat/linux/linux_misc.c:1531:24: error: comparison of unsigned expression 0 is always false [-Werror,-Wtautological-compare] Comments? OK? Index: linux_misc.c === RCS file:

Re: Genesys Logic GL620USB-A, USB PC-to-PC link cable (take 2)

2013-11-14 Thread Brad Smith
On 14/11/13 3:29 PM, SASANO Takayoshi wrote: Hello, Here is Genesys Logic's GL620USB-A driver, new version. I fixed crashing bug when peer is not connected, rewrite sc_dying to usbd_is_dying() (advices from mpi@), and deleted useless codes. This is still work in progress, man is not yet. And

re(4) MSI diff needs testing

2013-11-03 Thread Brad Smith
After rev 1.144 of re.c MSIs seem to work better with the 8168 variants of the Realtek PCIe GigE chipsets. So I am looking for any additional testing with the Realtek re(4) PCIe Ethernet chipsets. Index: if_re_pci.c === RCS file:

Fixing an LLVM warning in the i2o code

2013-11-03 Thread Brad Smith
LLVM errors out on the i2o code with the following warning.. ../../../../dev/i2o/iop.c:2399:42: error: comparison of unsigned expression 0 is always false [-Werror,-Wtautological-compare] pt-pt_nbufs 0 || pt-pt_replylen 0 || ~~~ ^ ~

Re: Promiscuous mode and multicast

2013-10-04 Thread Brad Smith
On Fri, Oct 04, 2013 at 03:18:45PM +0200, Martin Pieuchot wrote: tl;dr This diff stop (ab)using the actual SIOC{ADD,DEL}MULTI ioctls with a magic value for the whole range of multicast addresses used for IPv4/6 to turn the interface into promiscuous mode. Long story Ethernet

Re: memset.S for amd64

2013-09-19 Thread Brad Smith
On 19/09/13 7:47 AM, mxb wrote: This file is already in base. /usr/src/sys/lib/libkern/arch/amd64/memset.S That is in the kernel not libc. -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.

  1   2   3   >