trivial fix for pmemrange

2014-02-17 Thread Kieran Devlin
Index: uvm/uvm_pmemrange.c === RCS file: /cvs/src/sys/uvm/uvm_pmemrange.c,v retrieving revision 1.37 diff -p -u -r1.37 uvm_pmemrange.c --- uvm/uvm_pmemrange.c 6 Feb 2014 16:40:40 - 1.37 +++ uvm/uvm_pmemrange.c 13 Feb 2014

Re: trivial fix for pmemrange

2014-02-17 Thread Kieran Devlin
the original implementation use identical logic for both ‘high’ ‘low’, which will cause ‘high’ ‘low’ end up at same RB-tree node, instead of an expected interval. and finally, break ‘for’ loop logic luckily all these conditions never meet in practice. On Feb 17, 2014, at 5:14 PM, Mike Larkin

PATCH: fix bug in handling genmask

2014-01-21 Thread Kieran Devlin
hope this time i get the part ‘poke claudio@’ right a. fix a bug. b. get rid of some junk in ‘mask_rnhead’. c. forbid unprivileged user to insert ‘genmask' into ‘mask_rnhead' bug is in this line memcmp((caddr_t *)info.rti_info[RTAX_GENMASK] + 1, (caddr_t *)t-rn_key + 1, ((struct

Re: PATCH: fix bug in handling genmask

2013-12-28 Thread Kieran Devlin
, 2013 at 03:57:04AM +0800, Kieran Devlin wrote: re-send this patch, loop in claudio@ maybe someone could verify commit this patch a. fix a bug b. get rid of junk in ?mask_rnhead' c. forbid unprivileged user to insert mask into ?mask_rnhead' bug is in this line Bcmp((caddr_t *)genmask

PATCH: fix bug in handling genmask

2013-12-27 Thread Kieran Devlin
maybe someone could verify commit this patch a. fix a bug b. get rid of junk in ‘mask_rnhead' c. forbid unprivileged user to insert mask into ‘mask_rnhead' bug is in this line Bcmp((caddr_t *)genmask + 1, (caddr_t *)t-rn_key + 1, ((struct sockaddr *)t-rn_key)-sa_len) to make this

PATCH: fix bug in handling genmask

2013-12-27 Thread Kieran Devlin
re-send this patch, loop in claudio@ maybe someone could verify commit this patch a. fix a bug b. get rid of junk in ‘mask_rnhead' c. forbid unprivileged user to insert mask into ‘mask_rnhead' bug is in this line Bcmp((caddr_t *)genmask + 1, (caddr_t *)t-rn_key + 1, ((struct sockaddr

PATCH: Fix invalid size to 'memcmp' in 'rn_lexobetter'

2013-12-10 Thread Kieran Devlin
maybe someone could verify commit this patch this bug was introduced in r1.28 of ‘src/sys/net/radix.c’ i found it while going through source codes Index: sys/net/radix.c === RCS file: /cvs/src/sys/net/radix.c,v retrieving revision