Re: [External] : better use the tokeniser in the pfctl parser

2021-08-31 Thread Theo de Raadt
I am really against the idea of the parser inspecting a static buffer from the lex. Also we have a ton of these parsers, and discourage them from deviating. This tiny little "please use the right keyword" change feels so minor; we do not have a generic error-correction-proposing parser, 99% of

Re: [External] : better use the tokeniser in the pfctl parser

2021-08-31 Thread David Gwynne
On Tue, Aug 31, 2021 at 07:33:40AM +0200, Alexandr Nedvedicky wrote: > Hello, > > On Tue, Aug 31, 2021 at 02:40:57PM +1000, David Gwynne wrote: > > handling the "no" option with a token, and "yes" via a string made my > > eye twitch. > > > > ok? or is the helpful yyerror a nice feature? > > >

Re: [External] : better use the tokeniser in the pfctl parser

2021-08-30 Thread Alexandr Nedvedicky
Hello, On Tue, Aug 31, 2021 at 02:40:57PM +1000, David Gwynne wrote: > handling the "no" option with a token, and "yes" via a string made my > eye twitch. > > ok? or is the helpful yyerror a nice feature? > I actually think it's a nice feature. below is output for current pfctl we have