Re: [patch] Add error handling in usr.bin/time/time.c

Hi, Nan Xiao wrote on Fri, Apr 20, 2018 at 10:11:55PM +0800: > Ingo Schwarze wrote: >> No. Read the manual page and /sys/kern/kern_time.c : >> >> With a valid clock id and a valid address, this function >> cannot fail, so you are just adding dead code. Worse, >> you are making future auditors

Re: [patch] Add error handling in usr.bin/time/time.c

Hi Ingo, > No. Read the manual page and /sys/kern/kern_time.c : > > With a valid clock id and a valid address, this function > cannot fail, so you are just adding dead code. Worse, > you are making future auditors wonder what the heck is > going on here. Sorry, I can't find the above words

Re: [patch] Add error handling in usr.bin/time/time.c

Hi, Nan Xiao wrote on Fri, Apr 20, 2018 at 05:28:01PM +0800: > FYI, thanks! No. Read the manual page and /sys/kern/kern_time.c : With a valid clock id and a valid address, this function cannot fail, so you are just adding dead code. Worse, you are making future auditors wonder what the heck

[patch] Add error handling in usr.bin/time/time.c

Hi tech@, FYI, thanks! Index: time.c === RCS file: /cvs/src/usr.bin/time/time.c,v retrieving revision 1.25 diff -u -p -r1.25 time.c --- time.c 21 Aug 2017 13:38:02 - 1.25 +++ time.c 20 Apr 2018 09:21:59 - @@