Re: [patch] Fix resource leak in netcat

2018-10-02 Thread Theo Buehler
On Tue, Oct 02, 2018 at 02:38:03AM +0200, Alexander Bluhm wrote: > On Sun, Sep 30, 2018 at 11:55:58AM +0800, Nan Xiao wrote: > > The following patch fixed the resource leak when netcat works as a TLS > > server. Sorry if I am wrong, thanks! > > There is another tls leak on the client side after >

Re: [patch] Fix resource leak in netcat

2018-10-02 Thread Nan Xiao
Hi bluhm, Thanks very much for your reply! Yes, your patch covers all the corner cases, thanks! On 10/2/2018 8:38 AM, Alexander Bluhm wrote: > On Sun, Sep 30, 2018 at 11:55:58AM +0800, Nan Xiao wrote: >> The following patch fixed the resource leak when netcat works as a TLS >> server. Sorry if

Re: [patch] Fix resource leak in netcat

2018-10-01 Thread Alexander Bluhm
On Sun, Sep 30, 2018 at 11:55:58AM +0800, Nan Xiao wrote: > The following patch fixed the resource leak when netcat works as a TLS > server. Sorry if I am wrong, thanks! There is another tls leak on the client side after if (s == -1)

Re: [patch] Fix resource leak in netcat

2018-10-01 Thread Nan Xiao
Ping tech@, Any developer can comment on this patch? I think it is indeed a bug. Thanks! On 9/30/2018 11:55 AM, Nan Xiao wrote: > Hi tech@, > > The following patch fixed the resource leak when netcat works as a TLS > server. Sorry if I am wrong, thanks! > > > Index: netcat.c >

[patch] Fix resource leak in netcat

2018-09-29 Thread Nan Xiao
Hi tech@, The following patch fixed the resource leak when netcat works as a TLS server. Sorry if I am wrong, thanks! Index: netcat.c === RCS file: /cvs/src/usr.bin/nc/netcat.c,v retrieving revision 1.194 diff -u -p -r1.194