Re: [patch] kern/exec_script: avoid invalid free() in a case of error

2015-12-30 Thread Ted Unangst
Michael McConville wrote: > Michael McConville wrote: > > Michael McConville wrote: > > > > On Sun, Dec 13, 2015 at 9:45 PM, Maxim Pugachev > > > > wrote: > > > > > Hi, > > > > > > > > > > In exec_script_makecmds function, when EXEC_HASFD flag was set, but > > > > >

Re: [patch] kern/exec_script: avoid invalid free() in a case of error

2015-12-29 Thread Michael McConville
Michael McConville wrote: > Michael McConville wrote: > > > On Sun, Dec 13, 2015 at 9:45 PM, Maxim Pugachev > > > wrote: > > > > Hi, > > > > > > > > In exec_script_makecmds function, when EXEC_HASFD flag was set, but > > > > copystr/copyinstr returns an error, we need to

Re: [patch] kern/exec_script: avoid invalid free() in a case of error

2015-12-28 Thread Michael McConville
> On Sun, Dec 13, 2015 at 9:45 PM, Maxim Pugachev wrote: > > Hi, > > > > In exec_script_makecmds function, when EXEC_HASFD flag was set, but > > copystr/copyinstr returns an error, we need to set *tmpsap to NULL to > > terminate a loop (under "fail" label) correctly. I

Re: [patch] kern/exec_script: avoid invalid free() in a case of error

2015-12-28 Thread Michael McConville
Michael McConville wrote: > > On Sun, Dec 13, 2015 at 9:45 PM, Maxim Pugachev > > wrote: > > > Hi, > > > > > > In exec_script_makecmds function, when EXEC_HASFD flag was set, but > > > copystr/copyinstr returns an error, we need to set *tmpsap to NULL to > > > terminate a

[patch] kern/exec_script: avoid invalid free() in a case of error

2015-12-13 Thread Maxim Pugachev
Hi, In exec_script_makecmds function, when EXEC_HASFD flag was set, but copystr/copyinstr returns an error, we need to set *tmpsap to NULL to terminate a loop (under "fail" label) correctly. Index: sys/kern/exec_script.c === RCS