Re: [patch] signify's file name parsing broken

2020-01-26 Thread Christian Weisgerber
Marcus Müller: > > Files with ) are not used within openbsd > > I didn't know that! So, I couldn't un-tar an archive with )-containing > file names on openbsd (it just so happens that I came across this when > I was rolling tarballs)? That's a misunderstanding. Obviously OpenBSD has Unix file

Re: [patch] signify's file name parsing broken

2020-01-26 Thread Hiltjo Posthuma
On Tue, Jan 21, 2020 at 05:22:17PM -0500, Ted Unangst wrote: > Ted Unangst wrote: > > MarcusMüller wrote: > > > I've just stumbled across a malfunction in signify: It cannot handle > > > file names that contain a `)` character, when checking a list of hashes > > > generated by `sha256` command

Re: [patch] signify's file name parsing broken

2020-01-26 Thread Marcus Müller
On Tue, 2020-01-21 at 17:22 -0500, Ted Unangst wrote: > Ted Unangst wrote: > Not much simpler, but maybe this is easier to follow. Keeps the hair > in a > separate function. I appreciate the effort put into this issue very much! I agree, moving it into a separate function is beneficial; and the

Re: [patch] signify's file name parsing broken

2020-01-21 Thread Ted Unangst
Ted Unangst wrote: > MarcusMüller wrote: > > I've just stumbled across a malfunction in signify: It cannot handle > > file names that contain a `)` character, when checking a list of hashes > > generated by `sha256` command line utilities (`sha256sum --tags` on > > Linux). > > This fix is

Re: [patch] signify's file name parsing broken

2020-01-20 Thread Theo de Raadt
Ted Unangst wrote: > MarcusMüller wrote: > > I've just stumbled across a malfunction in signify: It cannot handle > > file names that contain a `)` character, when checking a list of hashes > > generated by `sha256` command line utilities (`sha256sum --tags` on > > Linux). > > This fix is

Re: [patch] signify's file name parsing broken

2020-01-20 Thread Ted Unangst
MarcusMüller wrote: > I've just stumbled across a malfunction in signify: It cannot handle > file names that contain a `)` character, when checking a list of hashes > generated by `sha256` command line utilities (`sha256sum --tags` on > Linux). This fix is unfortunately rather complicated for

[patch] signify's file name parsing broken

2020-01-11 Thread Marcus Müller
Dear OpenBSD community, I've just stumbled across a malfunction in signify: It cannot handle file names that contain a `)` character, when checking a list of hashes generated by `sha256` command line utilities (`sha256sum --tags` on Linux). To blame for this is this simple statement in