Hi,

Theo has been working on these patches over the past few days. I noticed an issue with dso_lib.c and fixed it accordingly.

# cvs diff -u -r1.10 dso_lib.c
Index: dso_lib.c
===================================================================
RCS file: /cvs/src/lib/libssl/src/crypto/dso/dso_lib.c,v
retrieving revision 1.10
diff -u -p -u -r1.10 dso_lib.c
--- dso_lib.c    19 Apr 2014 15:30:17 -0000    1.10
+++ dso_lib.c    21 Apr 2014 21:03:33 -0000
@@ -107,12 +107,11 @@ DSO_new_method(DSO_METHOD *meth)
          * to stealing the "best available" method. Will fallback
          * to DSO_METH_null() in the worst case. */
         default_DSO_meth = DSO_METHOD_openssl();
-    ret = (DSO *)malloc(sizeof(DSO));
+    ret = calloc(1, sizeof(DSO));
     if (ret == NULL) {
         DSOerr(DSO_F_DSO_NEW_METHOD, ERR_R_MALLOC_FAILURE);
         return (NULL);
     }
-    memset(ret, 0, sizeof(DSO));
     ret->meth_data = sk_void_new_null();
     if (ret->meth_data == NULL) {
         /* sk_new doesn't generate any errors so we do */
#

Reply via email to