Re: Avoid offline cpu in automatic frequency scheduling

2020-05-28 Thread Ted Unangst
On 2020-05-28, Solene Rapenne wrote: > > > In the current case, if you have offline cpu (because of hw.smt=0), > > > the total will still sum all the idle cpu and it's unlikely that > > > the total threshold is ever reached before the per cpu one. > > > > > > so, this diff skip offline cpus in

Re: Avoid offline cpu in automatic frequency scheduling

2020-05-28 Thread Solene Rapenne
On Thu, 28 May 2020 11:43:07 -0400 Bryan Steele : > On Thu, May 28, 2020 at 04:29:19PM +0200, Solene Rapenne wrote: > > the macro CPU_INFO_FOREACH loop over every CPU but the frequency > > algorithm will raise frequency if one cpu usage goes over a > > threshold but also if the sum of cpu usage

Re: Avoid offline cpu in automatic frequency scheduling

2020-05-28 Thread Bryan Steele
On Thu, May 28, 2020 at 04:29:19PM +0200, Solene Rapenne wrote: > the macro CPU_INFO_FOREACH loop over every CPU but the frequency > algorithm will raise frequency if one cpu usage goes over a threshold > but also if the sum of cpu usage goes over another threshold. > > In the current case, if

Re: Avoid offline cpu in automatic frequency scheduling

2020-05-28 Thread Solene Rapenne
On Thu, 28 May 2020 16:29:19 +0200 Solene Rapenne : > so, this diff skip offline cpus in the loop (robert@ gave me the big > clue to use cpu_is_online in the loop) apologies, it was claudio@ but robert@ helped too.

Avoid offline cpu in automatic frequency scheduling

2020-05-28 Thread Solene Rapenne
the macro CPU_INFO_FOREACH loop over every CPU but the frequency algorithm will raise frequency if one cpu usage goes over a threshold but also if the sum of cpu usage goes over another threshold. In the current case, if you have offline cpu (because of hw.smt=0), the total will still sum all the