Re: Patch to add -p (reading/parsing /etc/sysctl.conf) option to sysctl

2023-02-21 Thread Theo de Raadt
I do not see the value of this change. jhx wrote: > Thanks to all the suggestions/hints from Crystal Kolipe and Janne > Johansson I made a few changes to the patch. > > This also fixes reading commented lines. > > Thanks! > > --- sysctl.c.dist Tue Feb 21 12:17:57 2023 > +++ sysctl.c Tue

Re: Patch to add -p (reading/parsing /etc/sysctl.conf) option to sysctl

2023-02-21 Thread Fabian Keil
jhx wrote on 2023-02-21 at 12:46:28: > Thanks to all the suggestions/hints from Crystal Kolipe and Janne > Johansson I made a few changes to the patch. FYI, there is prior art. ElectroBSD's sysctl inherited an -f option from FreeBSD: | -f filename | Specify a file which

Re: Patch to add -p (reading/parsing /etc/sysctl.conf) option to sysctl

2023-02-21 Thread Stuart Henderson
A couple of comments, > - while ((ch = getopt(argc, argv, "Aanqw")) != -1) { > + while ((ch = getopt(argc, argv, "Aanpqw")) != -1) { The use of -p as the flag seems a bit odd, -f would be my instinctive choice - though it does match one of the three possibliities in Linux' sysctl(8).

Re: Patch to add -p (reading/parsing /etc/sysctl.conf) option to sysctl

2023-02-21 Thread Crystal Kolipe
On Tue, Feb 21, 2023 at 12:46:11PM +0100, Mike Fischer wrote: > > > Am 21.02.2023 um 12:00 schrieb Crystal Kolipe : > > > > On Tue, Feb 21, 2023 at 11:29:17AM +0100, jhx wrote: > >> this patch adds the "-p" option to sysctl which makes it possible to > >> read/parse/apply settings from

Re: Patch to add -p (reading/parsing /etc/sysctl.conf) option to sysctl

2023-02-21 Thread jhx
Thanks to all the suggestions/hints from Crystal Kolipe and Janne Johansson I made a few changes to the patch. This also fixes reading commented lines. Thanks! --- sysctl.c.dist Tue Feb 21 12:17:57 2023 +++ sysctl.cTue Feb 21 13:41:13 2023 @@ -138,6 +138,9 @@ /* Maximum size object

Re: Patch to add -p (reading/parsing /etc/sysctl.conf) option to sysctl

2023-02-21 Thread Mike Fischer
> Am 21.02.2023 um 12:00 schrieb Crystal Kolipe : > > On Tue, Feb 21, 2023 at 11:29:17AM +0100, jhx wrote: >> this patch adds the "-p" option to sysctl which makes it possible to >> read/parse/apply settings from /etc/sysctl.conf at any time the user wishes. > > This is an interesting idea,

Re: Patch to add -p (reading/parsing /etc/sysctl.conf) option to sysctl

2023-02-21 Thread Crystal Kolipe
On Tue, Feb 21, 2023 at 11:29:17AM +0100, jhx wrote: > this patch adds the "-p" option to sysctl which makes it possible to > read/parse/apply settings from /etc/sysctl.conf at any time the user wishes. This is an interesting idea, but you can effectively do the same thing from the shell with: #