Re: Read `ps_single' once

2021-03-09 Thread Martin Pieuchot
On 08/03/21(Mon) 12:37, Claudio Jeker wrote: > On Mon, Mar 08, 2021 at 12:11:54PM +0100, Martin Pieuchot wrote: > [...] > > This diff targets a specific problem which is to make sure `ps_single' > > dereferences are coherent if this value is being modified w/o KERNEL_LOCK(). > > It doesn't

Re: Read `ps_single' once

2021-03-08 Thread Claudio Jeker
On Mon, Mar 08, 2021 at 12:11:54PM +0100, Martin Pieuchot wrote: > On 08/03/21(Mon) 11:57, Claudio Jeker wrote: > > On Mon, Mar 08, 2021 at 11:06:44AM +0100, Martin Pieuchot wrote: > > > On 05/03/21(Fri) 11:30, Martin Pieuchot wrote: > > > > On 04/03/21(Thu) 11:45, Mark Kettenis wrote: > > > > > >

Re: Read `ps_single' once

2021-03-08 Thread Martin Pieuchot
On 08/03/21(Mon) 11:57, Claudio Jeker wrote: > On Mon, Mar 08, 2021 at 11:06:44AM +0100, Martin Pieuchot wrote: > > On 05/03/21(Fri) 11:30, Martin Pieuchot wrote: > > > On 04/03/21(Thu) 11:45, Mark Kettenis wrote: > > > > > Date: Thu, 4 Mar 2021 11:19:23 +0100 > > > > > From: Martin Pieuchot > >

Re: Read `ps_single' once

2021-03-08 Thread Claudio Jeker
On Mon, Mar 08, 2021 at 11:06:44AM +0100, Martin Pieuchot wrote: > On 05/03/21(Fri) 11:30, Martin Pieuchot wrote: > > On 04/03/21(Thu) 11:45, Mark Kettenis wrote: > > > > Date: Thu, 4 Mar 2021 11:19:23 +0100 > > > > From: Martin Pieuchot > > > > > > > > On 04/03/21(Thu) 11:01, Mark Kettenis

Re: Read `ps_single' once

2021-03-08 Thread Martin Pieuchot
On 05/03/21(Fri) 11:30, Martin Pieuchot wrote: > On 04/03/21(Thu) 11:45, Mark Kettenis wrote: > > > Date: Thu, 4 Mar 2021 11:19:23 +0100 > > > From: Martin Pieuchot > > > > > > On 04/03/21(Thu) 11:01, Mark Kettenis wrote: > > > > > Date: Thu, 4 Mar 2021 10:54:48 +0100 > > > > > From: Patrick

Re: Read `ps_single' once

2021-03-05 Thread Martin Pieuchot
On 04/03/21(Thu) 11:45, Mark Kettenis wrote: > > Date: Thu, 4 Mar 2021 11:19:23 +0100 > > From: Martin Pieuchot > > > > On 04/03/21(Thu) 11:01, Mark Kettenis wrote: > > > > Date: Thu, 4 Mar 2021 10:54:48 +0100 > > > > From: Patrick Wildt > > > > > > > > Am Thu, Mar 04, 2021 at 10:42:24AM +0100

Re: Read `ps_single' once

2021-03-04 Thread Mark Kettenis
> Date: Thu, 4 Mar 2021 11:19:23 +0100 > From: Martin Pieuchot > > On 04/03/21(Thu) 11:01, Mark Kettenis wrote: > > > Date: Thu, 4 Mar 2021 10:54:48 +0100 > > > From: Patrick Wildt > > > > > > Am Thu, Mar 04, 2021 at 10:42:24AM +0100 schrieb Mark Kettenis: > > > > > Date: Thu, 4 Mar 2021

Re: Read `ps_single' once

2021-03-04 Thread Martin Pieuchot
On 04/03/21(Thu) 11:01, Mark Kettenis wrote: > > Date: Thu, 4 Mar 2021 10:54:48 +0100 > > From: Patrick Wildt > > > > Am Thu, Mar 04, 2021 at 10:42:24AM +0100 schrieb Mark Kettenis: > > > > Date: Thu, 4 Mar 2021 10:34:24 +0100 > > > > From: Martin Pieuchot > > > > > > > > Running

Re: Read `ps_single' once

2021-03-04 Thread Mark Kettenis
> Date: Thu, 4 Mar 2021 10:54:48 +0100 > From: Patrick Wildt > > Am Thu, Mar 04, 2021 at 10:42:24AM +0100 schrieb Mark Kettenis: > > > Date: Thu, 4 Mar 2021 10:34:24 +0100 > > > From: Martin Pieuchot > > > > > > Running t/rw/msleep(9) w/o KERNEL_LOCK() implies that a thread can > > > change

Re: Read `ps_single' once

2021-03-04 Thread Patrick Wildt
Am Thu, Mar 04, 2021 at 10:42:24AM +0100 schrieb Mark Kettenis: > > Date: Thu, 4 Mar 2021 10:34:24 +0100 > > From: Martin Pieuchot > > > > Running t/rw/msleep(9) w/o KERNEL_LOCK() implies that a thread can > > change the value of `ps_single' while one of its siblings might be > > dereferencing

Re: Read `ps_single' once

2021-03-04 Thread Mark Kettenis
> Date: Thu, 4 Mar 2021 10:34:24 +0100 > From: Martin Pieuchot > > Running t/rw/msleep(9) w/o KERNEL_LOCK() implies that a thread can > change the value of `ps_single' while one of its siblings might be > dereferencing it. > > To prevent inconsistencies in the code executed by sibling thread,