Re: xidle: use strtonum(3), zap NOTREACHED

2018-11-11 Thread Klemens Nanni
On Sun, Nov 11, 2018 at 08:18:38AM -0600, Scott Cheloha wrote: > This should print a warning and then _exit(2), not exit(3). > I know you're "already here" but I might put that in a different > patch. Don't know if it "fits" with the other patch content. > > Choice is yours, though maybe someone

Re: xidle: use strtonum(3), zap NOTREACHED

2018-11-11 Thread Scott Cheloha
On Sun, Nov 11, 2018 at 12:24:51PM +0100, Klemens Nanni wrote: > On Sat, Nov 03, 2018 at 08:41:22PM +0100, Klemens Nanni wrote: > > Simpler and without ugly `goto fail'. `value.addr` is typed XPointer > > which is just a char pointer. > > > > Zap linter hints while here. > Bump. Comments

Re: xidle: use strtonum(3), zap NOTREACHED

2018-11-11 Thread Klemens Nanni
On Sat, Nov 03, 2018 at 08:41:22PM +0100, Klemens Nanni wrote: > Simpler and without ugly `goto fail'. `value.addr` is typed XPointer > which is just a char pointer. > > Zap linter hints while here. Bump. I have a few small/simple changes that I want to get in before eventually sending an