Re: Remove NULL checks before free()

2015-09-14 Thread Michael McConville
Ted Unangst wrote: > Michael McConville wrote: > > There will probably be more similar patches to come if this is > > acceptable. The legwork was done with the following Coccinelle script: > > I think it should be split up, but I'm happy to see diffs like this. Is this small enough? It's just

Re: Remove NULL checks before free()

2015-09-14 Thread Sebastien Marie
On Mon, Sep 14, 2015 at 09:18:35AM -0400, Michael McConville wrote: > Ted Unangst wrote: > > Michael McConville wrote: > > > There will probably be more similar patches to come if this is > > > acceptable. The legwork was done with the following Coccinelle script: > > > > I think it should be

Re: Remove NULL checks before free()

2015-09-11 Thread Ted Unangst
Michael McConville wrote: > There will probably be more similar patches to come if this is > acceptable. The legwork was done with the following Coccinelle script: > I think it should be split up, but I'm happy to see diffs like this.

Remove NULL checks before free()

2015-09-09 Thread Michael McConville
There will probably be more similar patches to come if this is acceptable. The legwork was done with the following Coccinelle script: @@ expression E; @@ - if(E) { - free(E); - } + free(E); Index: bin/systrace/filter.c ===

Re: Remove NULL checks before free()

2015-09-09 Thread Nicholas Marriott
Hi I personally don't see a particular need for this, it's something that can be tidied up as people make other changes in the area. Certainly you are trying to touch a lot of different places at once here which is usually not the best approach even for something minor. You'd probably be better