Re: Remove unused variable in usr.bin/openssl/apps.c

2018-08-16 Thread Theo Buehler
On Thu, Aug 16, 2018 at 05:56:47PM +0200, Ingo Schwarze wrote: [..] > this commit seems wrong to me. I agree. Thanks for paying attention, Ingo. This commit should be reverted. I think this is a bug that was introduced in r1.45 when free guards were removed, a few of them a bit too aggressively.

Re: Remove unused variable in usr.bin/openssl/apps.c

2018-08-16 Thread Ingo Schwarze
Hi, this commit seems wrong to me. The function verify_callback() in the file s_cb.c contains this code: switch (err) { /* ... */ case X509_V_ERR_NO_EXPLICIT_POLICY: policies_print(bio_err, ctx); break; } if (err ==

Re: Remove unused variable in usr.bin/openssl/apps.c

2018-08-16 Thread Rob Pierce
On Thu, Aug 16, 2018 at 06:14:06PM +0800, Nan Xiao wrote: > Hi tech@, > > The `free_out' variable seems redundant, so this patch removes it: > > Index: apps.c > === > RCS file: /cvs/src/usr.bin/openssl/apps.c,v > retrieving revision

Remove unused variable in usr.bin/openssl/apps.c

2018-08-16 Thread Nan Xiao
Hi tech@, The `free_out' variable seems redundant, so this patch removes it: Index: apps.c === RCS file: /cvs/src/usr.bin/openssl/apps.c,v retrieving revision 1.47 diff -u -p -r1.47 apps.c --- apps.c 7 Feb 2018 08:57:25 -