Re: Replace less(1)'s stdbool clone with the real McCoy

2016-01-30 Thread Todd C. Miller
On Fri, 29 Jan 2016 12:21:44 -0500, "Ted Unangst" wrote: > To throw in my vote, I happen to like bool/true/false, but if we don't > use them consistently, then sticking with int/1/0 is probably best. And > rototilling the whole src is a bad idea. I like bool as well and since less was already

Replace less(1)'s stdbool clone with the real McCoy

2016-01-29 Thread Michael McConville
Does this make sense? Note that screen_crashed can also be 2, so we leave it as an int. Assigning it to TRUE seems to have been a mistake. No binary change, surprisingly. Index: ch.c === RCS file: /cvs/src/usr.bin/less/ch.c,v

Re: Replace less(1)'s stdbool clone with the real McCoy

2016-01-29 Thread Ingo Schwarze
Hi Michael, Michael McConville wrote on Fri, Jan 29, 2016 at 11:33:50AM -0500: > Does this make sense? We usually don't use bool, it is pointless. I'd say leave the type as int, just delete the silly macros, and use 0 and 1 directly. Yours, Ingo

Re: Replace less(1)'s stdbool clone with the real McCoy

2016-01-29 Thread Ted Unangst
Ingo Schwarze wrote: > Hi Michael, > > Michael McConville wrote on Fri, Jan 29, 2016 at 11:33:50AM -0500: > > > Does this make sense? > > We usually don't use bool, it is pointless. > > I'd say leave the type as int, just delete the silly macros, > and use 0 and 1 directly. To throw in my