Re: Some df(1) cleanup

2016-02-05 Thread Ingo Schwarze
Hi, Theo Buehler wrote on Mon, Feb 01, 2016 at 06:23:33PM +0100: > On Mon, Feb 01, 2016 at 05:41:25PM +0100, Theo Buehler wrote: >> On Mon, Feb 01, 2016 at 05:17:03PM +0100, Michal Mazurek wrote: >>> mntbuf = calloc(argc, sizeof(struct statfs)); >>> if (mntbuf == NULL)

Re: Some df(1) cleanup

2016-02-01 Thread Theo Buehler
On Mon, Feb 01, 2016 at 05:41:25PM +0100, Theo Buehler wrote: > On Mon, Feb 01, 2016 at 05:17:03PM +0100, Michal Mazurek wrote: > > Meaningful error messages: > > > > mntbuf = calloc(argc, sizeof(struct statfs)); > > if (mntbuf == NULL) > > - err(1, NULL);

Re: Some df(1) cleanup

2016-02-01 Thread Theo Buehler
On Mon, Feb 01, 2016 at 05:17:03PM +0100, Michal Mazurek wrote: > Meaningful error messages: > > mntbuf = calloc(argc, sizeof(struct statfs)); > if (mntbuf == NULL) > - err(1, NULL); > + err(1, "calloc"); I disagree with the

Re: Some df(1) cleanup

2016-02-01 Thread Michael McConville
Theo Buehler wrote: > On Mon, Feb 01, 2016 at 05:17:03PM +0100, Michal Mazurek wrote: > > Meaningful error messages: > > > > mntbuf = calloc(argc, sizeof(struct statfs)); > > if (mntbuf == NULL) > > - err(1, NULL); > > + err(1, "calloc");