Re: a few style examples don't comply

2015-10-06 Thread Todd C. Miller
On Mon, 05 Oct 2015 23:36:11 +0200, Benny Lofgren wrote: > This reminds me of something I've always wondered, but never gotten > around to ask about... > > Why is the return value in return statements almost always enclosed in > parantheses in the codebase? > > It's not explained in style(9) as

Re: a few style examples don't comply

2015-10-05 Thread Ted Unangst
Benny Lofgren wrote: > On 2015-10-05 22:21, Rob Pierce wrote: > > On Mon, Oct 05, 2015 at 05:38:34PM +0059, Jason McIntyre wrote: > >> On Mon, Oct 05, 2015 at 11:50:49AM -0400, Rob Pierce wrote: > > Is it KNF compliant to have an exit() or return() at the same indentation as > > the closing functio

Re: a few style examples don't comply

2015-10-05 Thread Ted Unangst
Rob Pierce wrote: > On Mon, Oct 05, 2015 at 05:38:34PM +0059, Jason McIntyre wrote: > > On Mon, Oct 05, 2015 at 11:50:49AM -0400, Rob Pierce wrote: > > > There are some offending braces. I just added leading tabs in the right > > > places to correct indentation. > > > > > > Rob > > > > > > > why

Re: a few style examples don't comply

2015-10-05 Thread Benny Lofgren
On 2015-10-05 22:21, Rob Pierce wrote: > On Mon, Oct 05, 2015 at 05:38:34PM +0059, Jason McIntyre wrote: >> On Mon, Oct 05, 2015 at 11:50:49AM -0400, Rob Pierce wrote: > Is it KNF compliant to have an exit() or return() at the same indentation as > the closing function brace? For example: > >

Re: a few style examples don't comply

2015-10-05 Thread Jason McIntyre
On Mon, Oct 05, 2015 at 04:21:34PM -0400, Rob Pierce wrote: > On Mon, Oct 05, 2015 at 05:38:34PM +0059, Jason McIntyre wrote: > > On Mon, Oct 05, 2015 at 11:50:49AM -0400, Rob Pierce wrote: > > > There are some offending braces. I just added leading tabs in the right > > > places to correct indenta

Re: a few style examples don't comply

2015-10-05 Thread Rob Pierce
On Mon, Oct 05, 2015 at 05:38:34PM +0059, Jason McIntyre wrote: > On Mon, Oct 05, 2015 at 11:50:49AM -0400, Rob Pierce wrote: > > There are some offending braces. I just added leading tabs in the right > > places to correct indentation. > > > > Rob > > > > why are you indenting? the point of "-o

Re: a few style examples don't comply

2015-10-05 Thread Jason McIntyre
On Mon, Oct 05, 2015 at 11:50:49AM -0400, Rob Pierce wrote: > There are some offending braces. I just added leading tabs in the right > places to correct indentation. > > Rob > why are you indenting? the point of "-offset indent" in the list/display is to do just that. jmc > Index: style.9 > =

a few style examples don't comply

2015-10-05 Thread Rob Pierce
There are some offending braces. I just added leading tabs in the right places to correct indentation. Rob Index: style.9 === RCS file: /cvs/src/share/man/man9/style.9,v retrieving revision 1.62 diff -u -p -r1.62 style.9 --- style.9