Re: acpithinkpad: don't setup non-existent temp sensors

2023-04-08 Thread Klemens Nanni
On Sat, Apr 08, 2023 at 10:09:11AM -0500, joshua stein wrote: > The sensor nodes (TMP0, TMP1, etc.) are hard-coded into the DSDT, so > the EC failing to read the actual sensor should still allow it to be > found. Understood, thanks. > Yes, here is a new version without that chunk. Works for

Re: acpithinkpad: don't setup non-existent temp sensors

2023-04-08 Thread joshua stein
On Fri, 07 Apr 2023 at 19:00:43 +, Klemens Nanni wrote: > > + sc->sc_ntempsens = 0; > > + for (i = 0; i < THINKPAD_NSENSORS - THINKPAD_SENSOR_TMP0; i++) { > > + if (thinkpad_get_temp(sc, i, ) != 0) > > + break; > > doesn't this mean, that legit sensors which

Re: acpithinkpad: don't setup non-existent temp sensors

2023-04-07 Thread Klemens Nanni
05.04.2023 03:45, joshua stein пишет: > acpithinkpad sets up a hard-coded number of temperature sensors and > doesn't check the result of aml_evalinteger when polling, so for all > invalid sensors it ends up reporting the value of the previous > successful sensor check resulting in this (for a

Re: acpithinkpad: don't setup non-existent temp sensors

2023-04-05 Thread Klemens Nanni
On Tue, Apr 04, 2023 at 10:45:53PM -0500, joshua stein wrote: > acpithinkpad sets up a hard-coded number of temperature sensors and > doesn't check the result of aml_evalinteger when polling, so for all > invalid sensors it ends up reporting the value of the previous > successful sensor check

acpithinkpad: don't setup non-existent temp sensors

2023-04-04 Thread joshua stein
acpithinkpad sets up a hard-coded number of temperature sensors and doesn't check the result of aml_evalinteger when polling, so for all invalid sensors it ends up reporting the value of the previous successful sensor check resulting in this (for a machine with only a TMP0 sensor):