Re: bin/ed: fix clang warnings

2017-04-26 Thread Todd C. Miller
On Wed, 26 Apr 2017 22:56:57 +0200, Christian Weisgerber wrote: > The cases before and after follow the > > if (!interactive) { > if (garrulous) > ... > > pattern. *shrug* Yes, but in this case there is nothing to do if !garrulous which is

Re: bin/ed: fix clang warnings

2017-04-26 Thread Todd C. Miller
On Wed, 26 Apr 2017 22:10:49 +0200, Christian Weisgerber wrote: > This fixes the clang warnings in bin/ed. One extra pair of parentheses > and stop passing empty format strings to printf-family functions. One comment inline. Overall, I find the changes to be an improvement. I see that FreeBSD

bin/ed: fix clang warnings

2017-04-26 Thread Christian Weisgerber
This fixes the clang warnings in bin/ed. One extra pair of parentheses and stop passing empty format strings to printf-family functions. ok? Index: glbl.c === RCS file: /cvs/src/bin/ed/glbl.c,v retrieving revision 1.18 diff -u -p