Re: fix pppx(4) with net/ifq.c rev 1.38

2020-05-30 Thread David Gwynne
> On 30 May 2020, at 9:43 pm, Vitaliy Makkoveev > wrote: > > >> On 30 May 2020, at 09:40, David Gwynne wrote: >> >> On Mon, May 25, 2020 at 09:44:22AM +0200, Martin Pieuchot wrote: >>> On 23/05/20(Sat) 15:38, Vitaliy Makkoveev wrote: > On 23 May 2020, at 12:54, Martin Pieuchot wrote:

Re: fix pppx(4) with net/ifq.c rev 1.38

2020-05-30 Thread Vitaliy Makkoveev
> On 30 May 2020, at 09:40, David Gwynne wrote: > > On Mon, May 25, 2020 at 09:44:22AM +0200, Martin Pieuchot wrote: >> On 23/05/20(Sat) 15:38, Vitaliy Makkoveev wrote: On 23 May 2020, at 12:54, Martin Pieuchot wrote: On 22/05/20(Fri) 13:25, Vitaliy Makkoveev wrote: > On Fri,

Re: fix pppx(4) with net/ifq.c rev 1.38

2020-05-30 Thread David Gwynne
On Mon, May 25, 2020 at 09:44:22AM +0200, Martin Pieuchot wrote: > On 23/05/20(Sat) 15:38, Vitaliy Makkoveev wrote: > > > On 23 May 2020, at 12:54, Martin Pieuchot wrote: > > > On 22/05/20(Fri) 13:25, Vitaliy Makkoveev wrote: > > >> On Fri, May 22, 2020 at 07:57:13AM +1000, David Gwynne wrote: >

Re: fix pppx(4) with net/ifq.c rev 1.38

2020-05-25 Thread Martin Pieuchot
On 23/05/20(Sat) 15:38, Vitaliy Makkoveev wrote: > > On 23 May 2020, at 12:54, Martin Pieuchot wrote: > > On 22/05/20(Fri) 13:25, Vitaliy Makkoveev wrote: > >> On Fri, May 22, 2020 at 07:57:13AM +1000, David Gwynne wrote: > >>> [...] > >>> can you try the following diff? > >>> > >> > >> I

Re: fix pppx(4) with net/ifq.c rev 1.38

2020-05-23 Thread Vitaliy Makkoveev
> On 23 May 2020, at 12:54, Martin Pieuchot wrote: > > On 22/05/20(Fri) 13:25, Vitaliy Makkoveev wrote: >> On Fri, May 22, 2020 at 07:57:13AM +1000, David Gwynne wrote: >>> [...] >>> can you try the following diff? >>> >> >> I tested this diff and it works for me. But the problem I pointed

Re: fix pppx(4) with net/ifq.c rev 1.38

2020-05-23 Thread Martin Pieuchot
On 22/05/20(Fri) 13:25, Vitaliy Makkoveev wrote: > On Fri, May 22, 2020 at 07:57:13AM +1000, David Gwynne wrote: > > [...] > > can you try the following diff? > > > > I tested this diff and it works for me. But the problem I pointed is > about pipex(4) locking. > > pipex(4) requires NET_LOCK()

Re: fix pppx(4) with net/ifq.c rev 1.38

2020-05-22 Thread Vitaliy Makkoveev
On Fri, May 22, 2020 at 07:57:13AM +1000, David Gwynne wrote: > On Wed, May 20, 2020 at 05:42:35PM +0300, Vitaliy Makkoveev wrote: > > I got splassert with pppx(4) and net/ifq.c rev 1.38 raised by > > NET_ASSERT_LOCKED() in netinet/ip_output.c:113 and underlaying routines. > > > > net/ifq.c rev

Re: fix pppx(4) with net/ifq.c rev 1.38

2020-05-21 Thread David Gwynne
On Wed, May 20, 2020 at 05:42:35PM +0300, Vitaliy Makkoveev wrote: > I got splassert with pppx(4) and net/ifq.c rev 1.38 raised by > NET_ASSERT_LOCKED() in netinet/ip_output.c:113 and underlaying routines. > > net/ifq.c rev 1.38 is not in snapshot yet so you need to checkout and > build kernel to

Re: fix pppx(4) with net/ifq.c rev 1.38

2020-05-21 Thread Vitaliy Makkoveev
After net/ifq.c rev 1.38 was reverted pppac(4) still has this problem. pppac_output() called under NET_LOCK(). pppac_output() calls if_enqueue() which calls ifq_start(). But now ifq_start() can run pppac_input() directly under NET_LOCK() and also is can enqueue work and pppac_input() will be

Re: fix pppx(4) with net/ifq.c rev 1.38

2020-05-21 Thread Theo de Raadt
Vitaliy Makkoveev wrote: > Also 6.7 release has this problem. And I like to know, how to fix it too. Is this is a critical security fix, or an issue that lots of people will encounter? Errata creation is hours of work. We don't do it for tiny things. I actually don't appreciate seeing

fix pppx(4) with net/ifq.c rev 1.38

2020-05-20 Thread Vitaliy Makkoveev
I got splassert with pppx(4) and net/ifq.c rev 1.38 raised by NET_ASSERT_LOCKED() in netinet/ip_output.c:113 and underlaying routines. net/ifq.c rev 1.38 is not in snapshot yet so you need to checkout and build kernel to reproduce. dmesg begin splassert: ip_output: want 2 have 0