I agree.
Alexander Bluhm wrote:
> On Wed, Feb 24, 2021 at 04:27:03PM +1000, David Gwynne wrote:
> > it's a start though. cocci and i came up with this to push in after.
>
> Less casting is better. OK bluhm@
>
> > Index: arch/armv7/sunxi/sxie.c
> >
On Wed, Feb 24, 2021 at 04:27:03PM +1000, David Gwynne wrote:
> it's a start though. cocci and i came up with this to push in after.
Less casting is better. OK bluhm@
> Index: arch/armv7/sunxi/sxie.c
> ===
> RCS file:
On Tue, Feb 23, 2021 at 01:09:06PM +0100, Alexander Bluhm wrote:
> On Tue, Feb 23, 2021 at 07:31:30PM +1000, David Gwynne wrote:
> > i'm not a fan of having to cast to caddr_t when we have modern
> > inventions like void *s we can take advantage of.
>
> Shoud you remove all the (caddr_t) casts in
On Tue, Feb 23, 2021 at 07:31:30PM +1000, David Gwynne wrote:
> i'm not a fan of having to cast to caddr_t when we have modern
> inventions like void *s we can take advantage of.
Shoud you remove all the (caddr_t) casts in the callers then?
Without that step this diff does not provide more
ok mvs@
> On 23 Feb 2021, at 12:31, David Gwynne wrote:
>
> i'm not a fan of having to cast to caddr_t when we have modern
> inventions like void *s we can take advantage of.
>
> ok?
>
> Index: share/man/man9/mbuf.9
> ===
> RCS
i'm not a fan of having to cast to caddr_t when we have modern
inventions like void *s we can take advantage of.
ok?
Index: share/man/man9/mbuf.9
===
RCS file: /cvs/src/share/man/man9/mbuf.9,v
retrieving revision 1.120
diff -u -p