Re: ifconfig: Fix/improve settimeslot(), simplify get_ts_map() out

2017-06-08 Thread Stuart Henderson
On 2017/06/08 19:17, Stuart Henderson wrote: > On 2017/06/08 13:54, Ted Unangst wrote: > > Klemens Nanni wrote: > > > This fixes the primitive parsing route of settimeslot() to allow any > > > possible list of slots and/or ranges, see the update manual section. > > > > There doesn't appear to be

Re: ifconfig: Fix/improve settimeslot(), simplify get_ts_map() out

2017-06-08 Thread Stuart Henderson
On 2017/06/08 13:54, Ted Unangst wrote: > Klemens Nanni wrote: > > This fixes the primitive parsing route of settimeslot() to allow any > > possible list of slots and/or ranges, see the update manual section. > > There doesn't appear to be any use of timeslot code, is there? > > Better to delete

Re: ifconfig: Fix/improve settimeslot(), simplify get_ts_map() out

2017-06-08 Thread Ted Unangst
Klemens Nanni wrote: > This fixes the primitive parsing route of settimeslot() to allow any > possible list of slots and/or ranges, see the update manual section. There doesn't appear to be any use of timeslot code, is there? Better to delete it entirely. Index: ifconfig.8

ifconfig: Fix/improve settimeslot(), simplify get_ts_map() out

2017-06-08 Thread Klemens Nanni
This fixes the primitive parsing route of settimeslot() to allow any possible list of slots and/or ranges, see the update manual section. The old code would happily mask "1,2-" into 0b11, settimeslot() now fails on such broken ranges and also checks for inconsistencies like "4-1", etc.