Re: let bpf_mtap_hdr take a void * instead of caddr_t for the header

2019-09-11 Thread Christian Weisgerber
David Gwynne: > this makes it easier to call at least. > > it also brings it in line with bpf_tap_hdr. otherwise there's no > functional change. And remove the casts in the two calls to bpf_mtap_hdr() a few lines further down? -- Christian "naddy" Weisgerber

Re: let bpf_mtap_hdr take a void * instead of caddr_t for the header

2019-09-11 Thread Alexandr Nedvedicky
On Wed, Sep 11, 2019 at 10:02:24AM +1000, David Gwynne wrote: > this makes it easier to call at least. > > it also brings it in line with bpf_tap_hdr. otherwise there's no > functional change. > > ok? OK sashan@, consistency never hurts. sashan

Re: let bpf_mtap_hdr take a void * instead of caddr_t for the header

2019-09-11 Thread Stefan Sperling
On Wed, Sep 11, 2019 at 10:02:24AM +1000, David Gwynne wrote: > this makes it easier to call at least. > > it also brings it in line with bpf_tap_hdr. otherwise there's no > functional change. > > ok? I don't see why not if this change helps you. I suppose you're going to be passing in a

let bpf_mtap_hdr take a void * instead of caddr_t for the header

2019-09-10 Thread David Gwynne
this makes it easier to call at least. it also brings it in line with bpf_tap_hdr. otherwise there's no functional change. ok? Index: sys/net/bpf.c === RCS file: /cvs/src/sys/net/bpf.c,v retrieving revision 1.177 diff -u -p -r1.177