Re: libX11 patch for X*IfEvent() API issues, take #2

2022-11-14 Thread Walter Alejandro Iglesias
Hi Matthiew, On Nov 11 2022, Walter Alejandro Iglesias wrote: > On Nov 11 2022, Matthieu Herrb wrote: > > On Fri, Nov 11, 2022 at 03:17:21PM +0100, Walter Alejandro Iglesias wrote: > > > On Nov 11 2022, Matthieu Herrb wrote: > > > > Hi, > > > > > > > > So the patch provided by Adam Jackson upstre

Re: libX11 patch for X*IfEvent() API issues, take #2

2022-11-11 Thread Walter Alejandro Iglesias
On Nov 11 2022, Matthieu Herrb wrote: > On Fri, Nov 11, 2022 at 03:17:21PM +0100, Walter Alejandro Iglesias wrote: > > On Nov 11 2022, Matthieu Herrb wrote: > > > Hi, > > > > > > So the patch provided by Adam Jackson upstreams is completely buggy. > > > > > > - the logic to setup the new locking

Re: libX11 patch for X*IfEvent() API issues, take #2

2022-11-11 Thread Matthieu Herrb
On Fri, Nov 11, 2022 at 03:17:21PM +0100, Walter Alejandro Iglesias wrote: > On Nov 11 2022, Matthieu Herrb wrote: > > Hi, > > > > So the patch provided by Adam Jackson upstreams is completely buggy. > > > > - the logic to setup the new locking function was busted > > - I've observed cases where

Re: libX11 patch for X*IfEvent() API issues, take #2

2022-11-11 Thread Matthieu Herrb
On Fri, Nov 11, 2022 at 03:17:21PM +0100, Walter Alejandro Iglesias wrote: > On Nov 11 2022, Matthieu Herrb wrote: > > Hi, > > > > So the patch provided by Adam Jackson upstreams is completely buggy. > > > > - the logic to setup the new locking function was busted > > - I've observed cases where

Re: libX11 patch for X*IfEvent() API issues, take #2

2022-11-11 Thread Walter Alejandro Iglesias
On Nov 11 2022, Matthieu Herrb wrote: > Hi, > > So the patch provided by Adam Jackson upstreams is completely buggy. > > - the logic to setup the new locking function was busted > - I've observed cases where even the XGetIfEvent() function gets > re-rentered. So the flags does in fact need to

libX11 patch for X*IfEvent() API issues, take #2

2022-11-11 Thread Matthieu Herrb
Hi, So the patch provided by Adam Jackson upstreams is completely buggy. - the logic to setup the new locking function was busted - I've observed cases where even the XGetIfEvent() function gets re-rentered. So the flags does in fact need to be a counter. New patch which works for me with fvw