Re: mkhybrid minor fixes

> Looks good to me, though I wonder if the "check for char less than > zero" tests should be replaced with isascii((unsigned char)x), as that > smells like the intent. Indeed, especially since other ctype functions are used after that test. New diff also including feedback from jca@. Also, we do

Re: mkhybrid minor fixes

On Wed, 09 Sep 2015 13:50:21 -, Miod Vallat wrote: > New diff also including feedback from jca@. Also, we do not need to > embed the GNU getopt implementation anymore, since libc's getopt grew > support for long options quite many years ago. OK, but please remove the cast of the calloc()

Re: mkhybrid minor fixes

On Thu, Sep 3, 2015 at 10:08 AM, Miod Vallat wrote: > mkhybrid(8) does not seem to be maintained upstream. Here are a few > minor fixes to it: > - buffer overflows, spotted by -Wbounded. They are caused by the way > char name[] is defined in struct iso_directory_record in >

mkhybrid minor fixes

mkhybrid(8) does not seem to be maintained upstream. Here are a few minor fixes to it: - buffer overflows, spotted by -Wbounded. They are caused by the way char name[] is defined in struct iso_directory_record in src/iso9660.h; unfortunately too much of the code will require adjustments,