On Thu, Mar 17, 2022 at 12:47:15AM +0100, Alexander Bluhm wrote:
> My previous atempt to add a mutex to in_pcb.h was reverted as it
> broke userland build.
This diff passes make release and regress test.
I would like to commit it to proceed with pcb locking.
Generally fixing sysctl includes is
> Date: Thu, 17 Mar 2022 15:14:51 +0100
> From: Alexander Bluhm
>
> On Thu, Mar 17, 2022 at 02:09:39PM +0100, Mark Kettenis wrote:
> > I fear the fundamental problem is that we should not expose data
> > structures internal to the kernel to userland. What I don't
> > understand though is how
> From: "Ted Unangst"
> Date: Fri, 18 Mar 2022 05:04:23 -0400
>
> On 2022-03-17, Alexander Bluhm wrote:
> > On Thu, Mar 17, 2022 at 01:07:12AM +0100, Mark Kettenis wrote:
> > > > Date: Thu, 17 Mar 2022 01:01:46 +0100 (CET)
> > > > From: Mark Kettenis
> > > >
> > > > > Date: Thu, 17 Mar 2022
On 2022-03-17, Alexander Bluhm wrote:
> On Thu, Mar 17, 2022 at 01:07:12AM +0100, Mark Kettenis wrote:
> > > Date: Thu, 17 Mar 2022 01:01:46 +0100 (CET)
> > > From: Mark Kettenis
> > >
> > > > Date: Thu, 17 Mar 2022 00:47:15 +0100
> > > > From: Alexander Bluhm
> > > >
> > > > Hi,
> > > >
> >
On Thu, Mar 17, 2022 at 02:09:39PM +0100, Mark Kettenis wrote:
> I fear the fundamental problem is that we should not expose data
> structures internal to the kernel to userland. What I don't
> understand though is how that happens. The sysctl code doesn't seem
> to export "struct inpcb"
On Thu, Mar 17, 2022 at 02:09:39PM +0100, Mark Kettenis wrote:
> > Date: Thu, 17 Mar 2022 13:24:24 +0100
> > From: Alexander Bluhm
> >
> > On Thu, Mar 17, 2022 at 08:24:10AM +0100, Claudio Jeker wrote:
> > > On Thu, Mar 17, 2022 at 12:47:15AM +0100, Alexander Bluhm wrote:
> > > > Hi,
> > > >
>
> Date: Thu, 17 Mar 2022 13:24:24 +0100
> From: Alexander Bluhm
>
> On Thu, Mar 17, 2022 at 08:24:10AM +0100, Claudio Jeker wrote:
> > On Thu, Mar 17, 2022 at 12:47:15AM +0100, Alexander Bluhm wrote:
> > > Hi,
> > >
> > > My previous atempt to add a mutex to in_pcb.h was reverted as it
> > >
On Thu, Mar 17, 2022 at 08:24:10AM +0100, Claudio Jeker wrote:
> On Thu, Mar 17, 2022 at 12:47:15AM +0100, Alexander Bluhm wrote:
> > Hi,
> >
> > My previous atempt to add a mutex to in_pcb.h was reverted as it
> > broke userland build.
> >
> > Is the correct fix to include sys/mutex.h in every
On Thu, Mar 17, 2022 at 12:47:15AM +0100, Alexander Bluhm wrote:
> Hi,
>
> My previous atempt to add a mutex to in_pcb.h was reverted as it
> broke userland build.
>
> Is the correct fix to include sys/mutex.h in every .c file that
> includes netinet/in_pcb.h ? I made a release with it.
> Or
On Thu, Mar 17, 2022 at 01:07:12AM +0100, Mark Kettenis wrote:
> > Date: Thu, 17 Mar 2022 01:01:46 +0100 (CET)
> > From: Mark Kettenis
> >
> > > Date: Thu, 17 Mar 2022 00:47:15 +0100
> > > From: Alexander Bluhm
> > >
> > > Hi,
> > >
> > > My previous atempt to add a mutex to in_pcb.h was
> Date: Thu, 17 Mar 2022 01:01:46 +0100 (CET)
> From: Mark Kettenis
>
> > Date: Thu, 17 Mar 2022 00:47:15 +0100
> > From: Alexander Bluhm
> >
> > Hi,
> >
> > My previous atempt to add a mutex to in_pcb.h was reverted as it
> > broke userland build.
> >
> > Is the correct fix to include
> Date: Thu, 17 Mar 2022 00:47:15 +0100
> From: Alexander Bluhm
>
> Hi,
>
> My previous atempt to add a mutex to in_pcb.h was reverted as it
> broke userland build.
>
> Is the correct fix to include sys/mutex.h in every .c file that
> includes netinet/in_pcb.h ? I made a release with it.
> Or
Hi,
My previous atempt to add a mutex to in_pcb.h was reverted as it
broke userland build.
Is the correct fix to include sys/mutex.h in every .c file that
includes netinet/in_pcb.h ? I made a release with it.
Or should I include sys/mutex.h in netinet/in_pcb.h ?
ok?
bluhm
Index:
13 matches
Mail list logo
