syslogd: less global, more malloc, more random

2015-09-09 Thread Alexander Bluhm
Hi, Instead of having global variables containing the libevent structures, allocate them with malloc. This makes the address space layout more random. ok? bluhm Index: usr.sbin/syslogd/syslogd.c === RCS file:

Re: syslogd: less global, more malloc, more random

2015-09-09 Thread Todd C. Miller
On Wed, 09 Sep 2015 13:14:16 +0200, Alexander Bluhm wrote: > Instead of having global variables containing the libevent structures, > allocate them with malloc. This makes the address space layout > more random. That huge if() makes things a bit harder to read. Doing the NULL check separately

Re: syslogd: less global, more malloc, more random

2015-09-09 Thread Todd C. Miller
On Wed, 09 Sep 2015 18:57:05 +0200, Alexander Bluhm wrote: > Hmm, then you have another list where you can forget one of them. > ev_listen, ev_unix, ev_hup are missing in your example. Yeah, that is the downside. Looks like I deleted a little too much. - todd

Re: syslogd: less global, more malloc, more random

2015-09-09 Thread Alexander Bluhm
On Wed, Sep 09, 2015 at 08:55:12AM -0600, Todd C. Miller wrote: > On Wed, 09 Sep 2015 13:14:16 +0200, Alexander Bluhm wrote: > > > Instead of having global variables containing the libevent structures, > > allocate them with malloc. This makes the address space layout > > more random. > > That