Re: tweak msk to avoid ifq_deq_begin/commit/rollback

2017-05-31 Thread Mike Belopuhov
On Wed, May 31, 2017 at 10:28 +1000, David Gwynne wrote: > ie, do the space check before trying to dequeue and mbuf. > > this also moves it to using m_defrag. > Thanks, this looks good. Forgot to mention that you can remove the /* now we are committed to transmit the packet */ comment from both

Re: tweak msk to avoid ifq_deq_begin/commit/rollback

2017-05-30 Thread David Gwynne
> On 31 May 2017, at 10:58, Stuart Henderson wrote: > > I'll try it tomorrow.. 9 times out of 10 I hit the vp problem and have to > reboot though, so it'll be tricky to say whether it fixes what I sometimes > see with msk. > > IIRC installing on the overdrive 1000 was

Re: tweak msk to avoid ifq_deq_begin/commit/rollback

2017-05-30 Thread Stuart Henderson
I'll try it tomorrow.. 9 times out of 10 I hit the vp problem and have to reboot though, so it'll be tricky to say whether it fixes what I sometimes see with msk. IIRC installing on the overdrive 1000 was just "dd miniroot to a USB stick and boot from it". On 31 May 2017 01:29:06 David

tweak msk to avoid ifq_deq_begin/commit/rollback

2017-05-30 Thread David Gwynne
ie, do the space check before trying to dequeue and mbuf. this also moves it to using m_defrag. i dont have an msk plugged in and i dont know how to use the overdrive 1000 i have here. if someone could test and ok this, it would be great. Index: if_msk.c