Re: vi: remove awk scripts

2017-12-11 Thread Todd C. Miller
On Mon, 11 Dec 2017 17:45:07 +0100, Martijn van Duren wrote: > Updated diff OK millert@ for the updated diff. - todd

Re: vi: remove awk scripts

2017-12-11 Thread Martijn van Duren
On 12/11/17 14:14, Marc Espie wrote: >> @@ -37,6 +37,16 @@ SRCS= cl_funcs.c cl_main.c cl_read.c cl_ >> >> LINKS= ${BINDIR}/vi ${BINDIR}/ex >> LINKS+= ${BINDIR}/vi ${BINDIR}/view >> + >> +options_def.h: common/options.awk common/options.c >> +awk -f

Re: vi: remove awk scripts

2017-12-11 Thread Marc Espie
> @@ -37,6 +37,16 @@ SRCS= cl_funcs.c cl_main.c cl_read.c cl_ > > LINKS= ${BINDIR}/vi ${BINDIR}/ex > LINKS+= ${BINDIR}/vi ${BINDIR}/view > + > +options_def.h: common/options.awk common/options.c > + awk -f ${.CURDIR}/../common/options.awk ${.CURDIR}/../common/options.c \ >

Re: vi: remove awk scripts

2017-12-11 Thread Theo Buehler
On Mon, Dec 11, 2017 at 01:41:50PM +0100, Martijn van Duren wrote: > Both options have their risks and aren't particularly pretty. > Maybe the auto-generation option is a bit safer, because a comment is > harder to overlook than a separate file. > > Two minor nits on your patch (modified patch

Re: vi: remove awk scripts

2017-12-11 Thread Martijn van Duren
Both options have their risks and aren't particularly pretty. Maybe the auto-generation option is a bit safer, because a comment is harder to overlook than a separate file. Two minor nits on your patch (modified patch below): 1) You forgot to change ex/ex.awk to enum 2) I don't like the trailing

Re: vi: remove awk scripts

2017-12-11 Thread Theo Buehler
On Mon, Dec 11, 2017 at 11:35:42AM +0100, Theo Buehler wrote: > On Mon, Dec 11, 2017 at 10:11:44AM +0100, Martijn van Duren wrote: > > ping > > > > On 11/11/17 10:59, Martijn van Duren wrote: > > > Hello tech@, > > > > > > I've gotten confused by the awk scripts a few times now. > > > They seem

Re: vi: remove awk scripts

2017-12-11 Thread Theo Buehler
On Mon, Dec 11, 2017 at 10:11:44AM +0100, Martijn van Duren wrote: > ping > > On 11/11/17 10:59, Martijn van Duren wrote: > > Hello tech@, > > > > I've gotten confused by the awk scripts a few times now. > > They seem to unused and I had to really look where they were originally > > intended.

Re: vi: remove awk scripts

2017-12-11 Thread Martijn van Duren
ping On 11/11/17 10:59, Martijn van Duren wrote: > Hello tech@, > > I've gotten confused by the awk scripts a few times now. > They seem to unused and I had to really look where they were originally > intended. For the curious: > awk -f common/options.awk common/options.c > include/options_def.h

vi: remove awk scripts

2017-11-11 Thread Martijn van Duren
Hello tech@, I've gotten confused by the awk scripts a few times now. They seem to unused and I had to really look where they were originally intended. For the curious: awk -f common/options.awk common/options.c > include/options_def.h awk -f ex/ex.awk ex/ex_cmd.c > include/ex_def.h The