Hi,
I tested your patch and it is a great improvement for me.
My vms are hanging reproducible without your fix.
Thank you
Florian
Am Di., 29. Aug. 2023 um 18:01 Uhr schrieb Dave Voutila :
>
> Dave Voutila writes:
>
> > mbuhl@ found an issue where the emulated virtio block device can
> >
Dave Voutila writes:
> mbuhl@ found an issue where the emulated virtio block device can
> hang. The tl;dr: the emulated pic never injects an interrupt and the
> vioblk(4) driver in the guest starves, waiting to be told to check the
> virtqueue.
>
> Flipping the bit in the i8259 using gdb
mbuhl@ found an issue where the emulated virtio block device can
hang. The tl;dr: the emulated pic never injects an interrupt and the
vioblk(4) driver in the guest starves, waiting to be told to check the
virtqueue.
Flipping the bit in the i8259 using gdb causes the spice to flow once
again.
As mentioned before on bugs@ [1], the custom local prefix feature of vmd
broke with some of the recent changes. Since fixing this touches a lot
of parts of vmd, I'm breaking it up to make it reviewable by others and
hopefully less daunting.
This diff fixes an existing issue (predating recent
> Date: Mon, 28 Nov 2022 18:26:47 +0100
> From: Claudio Jeker
>
> On Mon, Nov 28, 2022 at 11:32:32AM -0500, Dave Voutila wrote:
> > tech@ et. al.,
> >
> > When kettenis@ introduced a newer version of BOOTARG_CONSDEV to add
> > additional params for the AMD Ryzen V1000 family, vmd's code that
>
On Mon, Nov 28, 2022 at 11:32:32AM -0500, Dave Voutila wrote:
> tech@ et. al.,
>
> When kettenis@ introduced a newer version of BOOTARG_CONSDEV to add
> additional params for the AMD Ryzen V1000 family, vmd's code that
> configures bootargs to support direct booting a ramdisk kernel didn't
>
On Mon, Nov 28, 2022 at 11:32:32AM -0500, Dave Voutila wrote:
> tech@ et. al.,
>
> When kettenis@ introduced a newer version of BOOTARG_CONSDEV to add
> additional params for the AMD Ryzen V1000 family, vmd's code that
> configures bootargs to support direct booting a ramdisk kernel didn't
>
tech@ et. al.,
When kettenis@ introduced a newer version of BOOTARG_CONSDEV to add
additional params for the AMD Ryzen V1000 family, vmd's code that
configures bootargs to support direct booting a ramdisk kernel didn't
adjust with it.
Mischa Peters found this and shared a simple reproducer on
On Sat, May 07, 2022 at 07:58:15AM -0400, Dave Voutila wrote:
> tech@:
>
> Now that vmd only accounts for memory in bytes [1], this fix is a lot
> simpler!
>
> If you use the send/receive functionality and "receive" a sent vm, it
> functions as expected. However, if that vm tries to reboot, it
tech@:
Now that vmd only accounts for memory in bytes [1], this fix is a lot
simpler!
If you use the send/receive functionality and "receive" a sent vm, it
functions as expected. However, if that vm tries to reboot, it causes
vmd to exit. (An ipc socket is closed in some error handling and
Claudio Jeker writes:
> On Wed, Jun 02, 2021 at 08:24:53AM -0400, Dave Voutila wrote:
>>
>> Martin Vahlensieck writes:
>>
>> > Index: parse.y
>> > ===
>> > retrieving revision 1.56
>> > diff -u -p -r1.56 parse.y
>> > --- parse.y
On Wed, Jun 02, 2021 at 08:24:53AM -0400, Dave Voutila wrote:
>
> Martin Vahlensieck writes:
>
> > Index: parse.y
> > ===
> > retrieving revision 1.56
> > diff -u -p -r1.56 parse.y
> > --- parse.y 23 Sep 2020 19:18:18 -
Martin Vahlensieck writes:
> Index: parse.y
> ===
> retrieving revision 1.56
> diff -u -p -r1.56 parse.y
> --- parse.y 23 Sep 2020 19:18:18 - 1.56
> +++ parse.y 2 Jun 2021 06:48:12 -
> @@ -694,6 +694,9 @@ lladdr
Hi Dave
On Tue, Jun 01, 2021 at 08:23:45PM -0400, Dave Voutila wrote:
>
> Martin Vahlensieck writes:
>
> > Hi
> >
> > The grammar for lladdr of interfaces is according to the manpage:
> >
> > [locked] lladdr [etheraddr]
> >
> > This implies that `locked lladdr' is OK but looking at parse.y
Martin Vahlensieck writes:
> Hi
>
> The grammar for lladdr of interfaces is according to the manpage:
>
> [locked] lladdr [etheraddr]
>
> This implies that `locked lladdr' is OK but looking at parse.y this
> does not seem to be the case. Making it optional would lead to a
> `lladdr' all by
Ping.
On Sat, May 22, 2021 at 09:58:46AM +0200, Martin Vahlensieck wrote:
> Hi
>
> The grammar for lladdr of interfaces is according to the manpage:
>
> [locked] lladdr [etheraddr]
>
> This implies that `locked lladdr' is OK but looking at parse.y this
> does not seem to be the case. Making
Hi
The grammar for lladdr of interfaces is according to the manpage:
[locked] lladdr [etheraddr]
This implies that `locked lladdr' is OK but looking at parse.y this
does not seem to be the case. Making it optional would lead to a
`lladdr' all by itself being valid, which I find weird. So I
On Thu, Aug 29, 2019 at 07:43:31PM +0200, Hiltjo Posthuma wrote:
> Hi,
>
> This fixes a small possible memory leak in an error handling path in vmd.c
> vm_claimid().
>
>
> diff --git usr.sbin/vmd/vmd.c usr.sbin/vmd/vmd.c
> index 654af5974d3..81be6b356d6 100644
> --- usr.sbin/vmd/vmd.c
> +++
Hi,
This fixes a small possible memory leak in an error handling path in vmd.c
vm_claimid().
diff --git usr.sbin/vmd/vmd.c usr.sbin/vmd/vmd.c
index 654af5974d3..81be6b356d6 100644
--- usr.sbin/vmd/vmd.c
+++ usr.sbin/vmd/vmd.c
@@ -1197,6 +1197,7 @@ vm_claimid(const char *name, int uid, uint32_t
Howdy.
Attached is a patch to fix the following condition:
When attempting to start a VM from vm.conf that fails (can't allocate
resources, etc...), do not remove vm from vm list.
Reported to bugs@ by mpi@.
Comments? Ok?
+--+
Carlos
Index: config.c
On Sun, Mar 26, 2017 at 04:40:03PM +0200, Mark Kettenis wrote:
> There is still a bit of an issue after the last set of changes made by
> mlarkin@. The changed get_input_data() interface takes a pointer to a
> uint32_t as an argument, but only modifies the bytes that correspond
> to the access
There is still a bit of an issue after the last set of changes made by
mlarkin@. The changed get_input_data() interface takes a pointer to a
uint32_t as an argument, but only modifies the bytes that correspond
to the access size. That means that if we read the value into an
uint32_t that is
22 matches
Mail list logo
