Re: readdir man page

2012-02-03 Thread Laurence Tratt
On Thu, Feb 02, 2012 at 09:50:45PM -0700, Philip Guenther wrote: The current man page doesn't claim that errno is always set but one might reasonably assume that it is: certainly, it seems a horribly easy way of introducing bugs (at least for idiots such as myself). [...] [Christiano]

Re: pfsync: deferred packets exit on wrong interface

2012-02-03 Thread Peter Hallin
On 2011-12-12 08:13, Peter Hallin wrote: Hello, We have a bunch of bridged firewalls and we are now looking into using the pfsync defer feature to solve some problems with async states during failover. However I discovered that the deferred packets (tcp SYN for example) are being sent

Re: readdir man page

2012-02-03 Thread Christiano F. Haesbaert
On 3 February 2012 02:50, Philip Guenther guent...@gmail.com wrote: On Thu, Feb 2, 2012 at 5:29 AM, Christiano F. Haesbaert haesba...@haesbaert.org wrote: On 2 February 2012 10:13, Laurence Tratt lau...@tratt.net wrote: To my surprise (and a couple of hours debugging later), readdir does not

Re: readdir man page

2012-02-03 Thread Christiano F. Haesbaert
On 3 February 2012 03:29, Philip Guenther guent...@gmail.com wrote: On Thu, 2 Feb 2012, Philip Guenther wrote: I also think readdir() should set errno if it detects an invalid seekdir(). EINVAL seems correct. Here's a diff for this bit. oks? Philip Guenther Index: gen/readdir.c

Re: NEW: libc getdelim(3) and getline(3)

2012-02-03 Thread Antoine Jacoutot
On Fri, Feb 03, 2012 at 05:00:55PM +0100, Jan Klemkow wrote: I decide to remove the check for the negative delimiter character, but I am not sure, with the file handle pointer check!? In my opinion this should be checked and return an minus 1 with an error for invalid input. The realloc(2)

Re: PATCH: failed spl lock release in pmap

2012-02-03 Thread Jan Klemkow
What is about this patch? thanks, Jan On Fri, Dec 02, 2011 at 06:31:47PM +0100, Jan Klemkow wrote: Hello, I've found an other spl lock lease failure. It's in an architecture which i couldn't test. But, I think the diff should work. bye, Jan Index: pmap.c

Re: PATCH: failed spl lock release in pmap

2012-02-03 Thread Miod Vallat
What is about this patch? This code is currently being rewritten. Miod

PCI_PWR_D[0-3] vs. PCI_PMCSR_STATE_D[0-3]

2012-02-03 Thread Alexey Suslikov
hello tech@ aren't these PCI_PWR_D[0-3] defines just duplicates of PCI_PMCSR_STATE_D[0-3] from pcireg.h? --- /usr/src/sys/dev/pci/pcivar.h.orig Sat Feb 4 01:28:05 2012 +++ /usr/src/sys/dev/pci/pcivar.h Sat Feb 4 01:28:41 2012 @@ -53,14 +53,6 @@ */ typedef u_int32_t pcireg_t;

sysv_msg queue id error

2012-02-03 Thread Geoff Steckel
Index: sys/kern/sysv_msg.c === RCS file: /cvs/src/sys/kern/sysv_msg.c,v retrieving revision 1.24 diff -u -r1.24 sysv_msg.c --- sys/kern/sysv_msg.c20 May 2011 16:06:25 -1.24 +++ sys/kern/sysv_msg.c3 Feb 2012 23:58:45