Re: csh: simplify strsave()

On Sat, Sep 08, 2018 at 10:13:35AM +0200, Martijn van Duren wrote: > On 09/08/18 04:57, Michael Mikonos wrote: > > Hello, > > > > The function strsave() in csh(1) is practically strdup(3). > > The only difference is memory allocation failure results in > > calling the stderror() error handler,

bgpd roa-set backend

This diff extends the existing trie code for prefix-set to also work with roa-set. Unlike prefix-set there is no need for a prefixlen mask during lookup, instead the source-as needs to be checked and also if the prefixlen of the prefix is allowed. The lookup can return 3 states: ROA_UNKNONW:

Re: bgpd roa-set backend

Dear Claudio, On Fri, Sep 14, 2018 at 04:59:51PM +0200, Claudio Jeker wrote: > This diff extends the existing trie code for prefix-set to also work with > roa-set. Unlike prefix-set there is no need for a prefixlen mask during > lookup, instead the source-as needs to be checked and also if the >

Re: csh: simplify strsave()

On Fri, 14 Sep 2018 22:30:26 +0800, Michael Mikonos wrote: > Your patch was better. Here is a version with the function renamed > and const added to the param list to match strdup(3). Looks good. OK millert@ - todd

Re: vmd: add some NULL checks after {c,m}alloc()

On Fri, Sep 14, 2018 at 02:50:18PM +0800, Michael Mikonos wrote: > On Thu, Sep 13, 2018 at 11:10:50PM -0700, Ori Bernstein wrote: > > On Fri, 14 Sep 2018 13:50:40 +0800, Michael Mikonos wrote: > > > > > On Thu, Sep 13, 2018 at 10:08:16PM -0700, Ori Bernstein wrote: > > > > On Thu, 13 Sep 2018

Re: bgpd roa-set backend

On Fri, Sep 14, 2018 at 05:27:03PM +0200, Job Snijders wrote: > Dear Claudio, > > On Fri, Sep 14, 2018 at 04:59:51PM +0200, Claudio Jeker wrote: > > This diff extends the existing trie code for prefix-set to also work with > > roa-set. Unlike prefix-set there is no need for a prefixlen mask

Re: pfctl: prevent modifying internal anchors through their tables

On Wed, Sep 12, 2018 at 02:05:25PM +0200, Alexander Bluhm wrote: > On Tue, Sep 11, 2018 at 12:17:05PM +0200, Klemens Nanni wrote: > > Now `t' under the anonymous anchors (internally named "_1") must not be > > modified through pfctl: > > > > # pfctl -a _1 -t t -T flush > > 0 addresses

imsg over network

The imsg_init(3) man page currently doesn't make it clear whether this library can be used for remote communication. The current text reads: The imsg functions provide a simple mechanism for communication between processes using sockets. Each transmitted message is guaranteed to be

[patch] Use correct data type in ldd.c

Hi tech@, Since both the return value of sizeof() and pread()'s parameter require size_t type, I think using size_t instead of int to be size's type should be more appropriate. Thanks! Index: ldd.c === RCS file:

Re: vmd: add some NULL checks after {c,m}alloc()

On Fri, 14 Sep 2018 13:50:40 +0800, Michael Mikonos wrote: > On Thu, Sep 13, 2018 at 10:08:16PM -0700, Ori Bernstein wrote: > > On Thu, 13 Sep 2018 10:30:54 +0800, Michael Mikonos wrote: > > > I think a check for !disk->base belongs here as done above for disk->l1. > I think that co ---

Re: [patch] Fix file descriptor leak in nohup.c

Hi bluhm, Thanks very much for your time and detailed explanation! I update the patch, and you can review it when you are free, thanks! Index: nohup.c === RCS file: /cvs/src/usr.bin/nohup/nohup.c,v retrieving revision 1.17 diff -u

Re: c++ headers with latest lib{c++,c++abi,unwind} update / out-of-sync sets

On Fri, Sep 14, 2018 at 06:18:12AM +0200, Sebastien Marie wrote: > Hi, > > I noticed the following new headers are installed: > > /usr/include/c++/v1/__refstring > /usr/include/c++/v1/__undef___deallocate > /usr/include/c++/v1/__undef_min_max > > but they aren't present in sets. > > The

Re: c++ headers with latest lib{c++,c++abi,unwind} update / out-of-sync sets

On Fri, Sep 14, 2018 at 05:19:47PM +1000, Jonathan Gray wrote: > On Fri, Sep 14, 2018 at 06:18:12AM +0200, Sebastien Marie wrote: > > Hi, > > > > I noticed the following new headers are installed: > > > > /usr/include/c++/v1/__refstring > > /usr/include/c++/v1/__undef___deallocate > >

Fix underlining in fortunes

Hi, >From /usr/src/games/fortune/Notes: Underlining is done on a word-by-word basis, with the underlines preceding the word, e.g., "__^H^Hhi ^H^H^H^Hthere". Two fortunes, though, do it wrong: "_^H_^Hhi _^H_^H_^H_^H_^Hthere". This manifests as an underline beneath only the first

Re: [patch] Fix an error in chmod.1

Hi Philip, Very sorry for my fault! Thanks very much for your time and explanation! On 9/14/2018 1:28 PM, Philip Guenther wrote: > On Thu, Sep 13, 2018 at 8:17 PM Nan Xiao > wrote: > > The following patch fixes an error in chmod.1, and very sorry if I am >

Re: Kernel build: clean up gapdummy.c

On Fri, Sep 14, 2018 at 12:29:07AM +0200, Christian Weisgerber wrote: > Some architectures generate a gapdummy.c file for kernel builds. > Add this to the "clean" target. > > OK? ok jsg@ > > Index: arch/arm64/conf/Makefile.arm64 >

Re: Allow building amd64/i386 kernel with lld

On Fri, Sep 14, 2018 at 12:25:42AM +0200, Christian Weisgerber wrote: > Currently, building an amd64 or i386 kernel with lld breaks in > makegap.sh. It turns out that we already have the missing pieces > (gapdummy) on some other archs, so we can just copy them. > > With this, I can successfully

Re: mount.8: clarify -a description

On Fri, Sep 14, 2018 at 02:18:22PM +0200, Klemens Nanni wrote: > "Similar" can be a bit vague; I thought `mount -a -t nfs' would mount > all NFS shares except those already mounted. > > This might be just be, but a little emphasis makes it even clearer that > this is not the case. > > Feedback?

Re: mount.8: clarify -a description

On Fri, Sep 14, 2018 at 01:23:05PM +0100, Jason McIntyre wrote: > hi. i'm not so keen - we use this syntax in a lot of pages. it is not > vague. i don;t see how changing it makes anything clearer. So is "Sames as" used in a lot of places. It seemed worth suggesting, but I won't push it as there's

mount.8: clarify -a description

"Similar" can be a bit vague; I thought `mount -a -t nfs' would mount all NFS shares except those already mounted. This might be just be, but a little emphasis makes it even clearer that this is not the case. Feedback? OK? Index: mount.8

Re: vmd: add some NULL checks after {c,m}alloc()

On Thu, Sep 13, 2018 at 11:10:50PM -0700, Ori Bernstein wrote: > On Fri, 14 Sep 2018 13:50:40 +0800, Michael Mikonos wrote: > > > On Thu, Sep 13, 2018 at 10:08:16PM -0700, Ori Bernstein wrote: > > > On Thu, 13 Sep 2018 10:30:54 +0800, Michael Mikonos wrote: > > > > > I think a check for

usr.bin/bgplg: remove ping6 leftovers

In usr.bin/bgplg, ping6/Makefile is left-over from ping(6) unification. However, there is no ping6 folder anymore: $ cd /usr/src/usr.bin/bgplg/ping6/ && make *** Parse error in /usr/src/usr.bin/bgplg/ping6: Could not find /usr/src/usr.bin/bgplg/ping6/../../../sbin/ping6/Makefile (Makefile:9)

Re: usr.bin/bgplg: remove ping6 leftovers

On Fri, Sep 14, 2018 at 12:22:13PM +0200, Clemens Goessnitzer wrote: > In usr.bin/bgplg, ping6/Makefile is left-over from ping(6) unification. > However, there is no ping6 folder anymore: > > $ cd /usr/src/usr.bin/bgplg/ping6/ && make > *** Parse error in /usr/src/usr.bin/bgplg/ping6: Could not