Re: Change vm_dsize to vsize_t

2021-09-07 Thread Todd C . Miller
On Tue, 07 Sep 2021 09:46:02 +0200, Claudio Jeker wrote: > From my understanding this is not how struct kinfo_proc should be modified. > Instead the code should add the u_int64_t version at the end and leave the > old in place. This way old userland still works with new kernel. Correct. - todd

Re: fix iwx(4) firmware loading during resume

2021-09-07 Thread Stefan Sperling
On Tue, Sep 07, 2021 at 05:16:52PM +0200, Martin Pieuchot wrote: > On 07/09/21(Tue) 15:48, Stefan Sperling wrote: > > This patch makes iwx(4) resume reliably for me. > > > > There were missing splnet() calls which leads to an obvious race > > between the interrupt handler and the code which

fix iwx(4) firmware loading during resume

2021-09-07 Thread Stefan Sperling
This patch makes iwx(4) resume reliably for me. There were missing splnet() calls which leads to an obvious race between the interrupt handler and the code which triggers firmware loading and then sleeps to wait for confirmation. This patch adds the missing splnet(). However, even with splnet()

Re: fix iwx(4) firmware loading during resume

2021-09-07 Thread Martin Pieuchot
On 07/09/21(Tue) 15:48, Stefan Sperling wrote: > This patch makes iwx(4) resume reliably for me. > > There were missing splnet() calls which leads to an obvious race > between the interrupt handler and the code which triggers firmware > loading and then sleeps to wait for confirmation. > This

Re: allow KARL with config(8)'d kernels

2021-09-07 Thread Paul de Weerd
Hi all, On Tue, Sep 07, 2021 at 02:30:43PM +0200, Robert Nagy wrote: | /etc/reorder_kernel.conf Thank you for your suggest Robert! In the mean time, I've had a few more off-list comments about this proposal - generally favorable, but no better suggestions have come along. After some more

Re: fix iwx(4) firmware loading during resume

2021-09-07 Thread Martin Pieuchot
On 07/09/21(Tue) 18:03, Stefan Sperling wrote: > On Tue, Sep 07, 2021 at 05:16:52PM +0200, Martin Pieuchot wrote: > > On 07/09/21(Tue) 15:48, Stefan Sperling wrote: > > > This patch makes iwx(4) resume reliably for me. > > > > > > There were missing splnet() calls which leads to an obvious race >

Re: Change vm_dsize to vsize_t

2021-09-07 Thread Mark Kettenis
> From: "Theo de Raadt" > Date: Tue, 07 Sep 2021 07:08:19 -0600 > > Claudio Jeker wrote: > > > > @@ -443,7 +443,7 @@ struct kinfo_proc { > > > > > > int32_t p_vm_rssize;/* SEGSZ_T: current resident set size > > > in pages */ > > > int32_t p_vm_tsize; /* SEGSZ_T:

Re: [please test] amd64: schedule clock interrupts against system clock

2021-09-07 Thread Patrick Wildt
Am Tue, Sep 07, 2021 at 09:52:42PM +0200 schrieb Martin Pieuchot: > On 07/09/21(Tue) 21:47, Patrick Wildt wrote: > > Am Tue, Sep 07, 2021 at 02:43:22PM +0200 schrieb Patrick Wildt: > > > Am Mon, Sep 06, 2021 at 09:43:29PM +0200 schrieb Patrick Wildt: > > > > Am Fri, Jul 30, 2021 at 07:55:29PM

Re: [please test] amd64: schedule clock interrupts against system clock

2021-09-07 Thread Patrick Wildt
Am Tue, Sep 07, 2021 at 02:43:22PM +0200 schrieb Patrick Wildt: > Am Mon, Sep 06, 2021 at 09:43:29PM +0200 schrieb Patrick Wildt: > > Am Fri, Jul 30, 2021 at 07:55:29PM +0200 schrieb Alexander Bluhm: > > > On Mon, Jul 26, 2021 at 08:12:39AM -0500, Scott Cheloha wrote: > > > > On Fri, Jun 25, 2021

Re: allow KARL with config(8)'d kernels

2021-09-07 Thread Paul de Weerd
On Tue, Sep 07, 2021 at 07:57:55PM +0200, Robert Nagy wrote: | On 07/09/21 19:31 +0200, Paul de Weerd wrote: | > Hi all, | > | > On Tue, Sep 07, 2021 at 02:30:43PM +0200, Robert Nagy wrote: | > | /etc/reorder_kernel.conf | > | > Thank you for your suggest Robert! In the mean time, I've had a

Re: OpenSSH: RSA/SHA1 disabled by default

2021-09-07 Thread Stuart Henderson
On 2021/09/07 14:40, Martijn van Duren wrote: > On Mon, 2021-08-30 at 10:08 +1000, Damien Miller wrote: > > Hi, > > > > RSA/SHA1, a.k.a the "ssh-rsa" signature type is now disabled by default > > in OpenSSH. > > > > While The SSH protocol confusingly uses overlapping names for key and > >

Re: [please test] amd64: schedule clock interrupts against system clock

2021-09-07 Thread Martin Pieuchot
On 07/09/21(Tue) 21:47, Patrick Wildt wrote: > Am Tue, Sep 07, 2021 at 02:43:22PM +0200 schrieb Patrick Wildt: > > Am Mon, Sep 06, 2021 at 09:43:29PM +0200 schrieb Patrick Wildt: > > > Am Fri, Jul 30, 2021 at 07:55:29PM +0200 schrieb Alexander Bluhm: > > > > On Mon, Jul 26, 2021 at 08:12:39AM

Re: allow KARL with config(8)'d kernels

2021-09-07 Thread Robert Nagy
On 07/09/21 19:31 +0200, Paul de Weerd wrote: > Hi all, > > On Tue, Sep 07, 2021 at 02:30:43PM +0200, Robert Nagy wrote: > | /etc/reorder_kernel.conf > > Thank you for your suggest Robert! In the mean time, I've had a few > more off-list comments about this proposal - generally favorable, but >

Re: OpenSSH: RSA/SHA1 disabled by default

2021-09-07 Thread Stuart Henderson
On 2021/09/08 09:03, Damien Miller wrote: > This is a case of the host key algorithm not matching, so you > should use HostKeyAlgorithms=+ssh-rsa - I'll make sure to mention > this in the release notes. People seem to really be having a hard time grasping what's being disabled by default. And it

Re: OpenSSH: RSA/SHA1 disabled by default

2021-09-07 Thread Damien Miller
On Tue, 7 Sep 2021, Martijn van Duren wrote: > On Mon, 2021-08-30 at 10:08 +1000, Damien Miller wrote: > > Hi, > > > > RSA/SHA1, a.k.a the "ssh-rsa" signature type is now disabled by default > > in OpenSSH. > > > > While The SSH protocol confusingly uses overlapping names for key and > >

Re: OpenSSH: RSA/SHA1 disabled by default

2021-09-07 Thread Theo de Raadt
Stuart Henderson wrote: > On 2021/09/08 09:03, Damien Miller wrote: > > This is a case of the host key algorithm not matching, so you > > should use HostKeyAlgorithms=+ssh-rsa - I'll make sure to mention > > this in the release notes. > > People seem to really be having a hard time grasping

Re: Change vm_dsize to vsize_t

2021-09-07 Thread Claudio Jeker
On Mon, Sep 06, 2021 at 12:39:56PM -0700, Greg Steuck wrote: > In the course of making ASan work on OpenBSD I ran into an accounting > limitation. struct vmspace declares vm_dsize as segsz_t (aka int32_t). > This effectively limits it to 2^31 pages (2^43 bytes on amd64). This > would be enough if

Re: Analyse of kernel lock contention

2021-09-07 Thread Martin Pieuchot
On 06/09/21(Mon) 17:30, Martin Pieuchot wrote: > [...] > 3) 2ytHD+make-j17+kqpoll_unlocked_arm64.svg > === This should be: 3) 2ytHD+googlemap_arm64.svg > The intend of this test is to expose where the contention is for

mutex(9): initialize some more mutexes before use?

2021-09-07 Thread Patrick Wildt
Hi, I was playing around a little with the mutex code and found that on arm64 there some uninitialized mutexes out there. I think the arm64 specific one is comparatively easy to solve. We either initialize the mtx when we initialize the rest of the pmap, or we move it into the global definition

Re: allow KARL with config(8)'d kernels

2021-09-07 Thread Robert Nagy
On 29/08/21 08:10 -0600, Theo de Raadt wrote: > Ingo Schwarze wrote: > > > One - admittedly completely unUNIXy - way would be to invent a long, > > descriptive name like /etc/kernel.config.commands or even /bsd.config.cmd > > in the root rather than the /etc directory, which is more discoverable

Re: OpenSSH: RSA/SHA1 disabled by default

2021-09-07 Thread Martijn van Duren
On Mon, 2021-08-30 at 10:08 +1000, Damien Miller wrote: > Hi, > > RSA/SHA1, a.k.a the "ssh-rsa" signature type is now disabled by default > in OpenSSH. > > While The SSH protocol confusingly uses overlapping names for key and > signature algorithms, this does not stop the use of RSA keys and

Re: [please test] amd64: schedule clock interrupts against system clock

2021-09-07 Thread Patrick Wildt
Am Mon, Sep 06, 2021 at 09:43:29PM +0200 schrieb Patrick Wildt: > Am Fri, Jul 30, 2021 at 07:55:29PM +0200 schrieb Alexander Bluhm: > > On Mon, Jul 26, 2021 at 08:12:39AM -0500, Scott Cheloha wrote: > > > On Fri, Jun 25, 2021 at 06:09:27PM -0500, Scott Cheloha wrote: > > > 1 month bump. I really

Re: Change vm_dsize to vsize_t

2021-09-07 Thread Theo de Raadt
Claudio Jeker wrote: > > @@ -443,7 +443,7 @@ struct kinfo_proc { > > > > int32_t p_vm_rssize;/* SEGSZ_T: current resident set size > > in pages */ > > int32_t p_vm_tsize; /* SEGSZ_T: text size (pages) */ > > - int32_t p_vm_dsize; /* SEGSZ_T: data

Re: ksh: add support for bracketed paste mode

2021-09-07 Thread Theo de Raadt
bracketed paste mode is complete garbage which should never have been invented. It creates as many problems as it solves. It is way too easy for a tty to get into the mode, and get stuck. Yes, getting stuck happens, especially when programs crash while in the mode. At that point, the user